Martin Polednik has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55044/2/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:
PS2, Line
gerrit-hooks has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: expose 'driver' attribute
..
hostdev: expose 'driver' attribute
Device drivers are exposed via sysfs file, and those values are exposed
in
Martin Polednik has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/55044
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 4: Code-Review+2
thanks for the updates, raising score
--
To view, visit https://gerrit.ovirt.org/55044
To
gerrit-hooks has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/55044/3/tests/devices/data/pci__00_1a_0.xml
File
Francesco Romani has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 3: Code-Review+1
(1 comment)
looks ok, but deeper review later
gerrit-hooks has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55044/2/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:
PS2, Line
Martin Polednik has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/55044/2/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:
PS2, Line
Francesco Romani has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55044/2/tests/hostdevTests.py
File tests/hostdevTests.py:
Line
Francesco Romani has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 2: Code-Review-1
(1 comment)
conceptually fine, but I'd try to avoid catching AttributeError. Let's discuss
Martin Polednik has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/55044
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 1: Verified-1
the tests must be updated
--
To view, visit https://gerrit.ovirt.org/55044
To unsubscribe,
Martin Polednik has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55044
To unsubscribe, visit
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: expose 'driver' attribute
..
hostdev: expose 'driver' attribute
Device drivers are exposed via sysfs file, and those values are exposed
in libvirt's
gerrit-hooks has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
19 matches
Mail list logo