Dan Kenigsberg has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43042
To unsubscribe, visit https://gerrit.ovirt.org/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: fix hostdev addressing
..
hostdev: fix hostdev addressing
Host devices are special in a sense that in case of PCI, there are two
addresses pre
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Francesco Romani has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 10: Code-Review+1
Thanks for the updates, I think it's good now.
--
To view, visit https://gerrit.ovirt.org/430
Martin Polednik has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 10: Verified+1
Addresses are reported correctly - meaning the VM can be freely restarted and
it's start won't fai
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Martin Polednik has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/43042/8/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/ho
Martin Polednik has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/43042/8/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/h
Francesco Romani has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 8: Code-Review-1
(2 comments)
I think we're reaching a good enough point. A couple more suggestions inside.
-1
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Martin Polednik has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/43042/7/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/h
Francesco Romani has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 7: Code-Review-1
(3 comments)
thanks, looks better. A few more questions. -1 for visibility only.
https://gerri
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Martin Polednik has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/43042
To unsubscribe, visit https://gerrit.ovirt.org/set
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Ido Barkan has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43042
To unsubscribe, visit https://gerrit.ovirt.org/setti
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Martin Polednik has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/43042/4/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/ho
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Ido Barkan has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/43042/3/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmd
Martin Polednik has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/43042/3/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/ho
Francesco Romani has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 3: Code-Review-1
(1 comment)
I'm fine with the concept, I don't really like an implementation detail. -1 for
qu
Ido Barkan has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43042
To unsubscribe, visit https://gerrit.ovirt.org/setti
Dan Kenigsberg has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43042
To unsubscribe, visit https://gerrit.ovirt.org/s
Martin Polednik has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 3: Verified+1
Address is correctly created (guest, host); type is present as expected; works
for both interface a
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
30 matches
Mail list logo
