Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-20 Thread amuller
Assaf Muller has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 3: I'd prefer to leave the decision to you as I think you're more informed on this subject, but I ga

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 3: Code-Review-1 Assaf, please use your -1 powers. I'd like to drop these HWADDRs from NM-less el6

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-20 Thread amuller
Assaf Muller has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 3: (1 comment) File lib/vdsm/config.py.in Line

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 3: (1 comment) File lib/vdsm/config.py.in Lin

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-19 Thread amuller
Assaf Muller has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 3: (1 comment) File lib/vdsm/config.py.in Line

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 3: Verified+1 verified with the functional/networkTests and manually. -- To view, visit http://ge

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 3: Failure unrelated to patch. libvirtError: authentication failed: polkit: polkit\56retains_auth

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-17 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22288 To unsubscribe, visit htt

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6132/ : SUCCESS

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 2: (1 comment) File vdsm/netconf/ifcfg.py Lin

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 2: (1 comment) File vdsm/netconf/ifcfg.py Lin

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-15 Thread amuller
Assaf Muller has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 2: (1 comment) File vdsm/netconf/ifcfg.py Line

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-15 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/22288 To unsubscribe, visit http://gerrit.

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 2: Code-Review+1 Thanks for the change Dan! -- To view, visit http://gerrit.ovirt.org/222

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6036/ : SUCCESS http:

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 1: Not in netconf/__init__, just that vdsm/nm.py should be vdsm/netconf/nm.py as it is onl

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 1: Toni, what belongs to netconf.__init__? _nm_around? What would is its usage for something other

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 1: Code-Review-1 I think it belongs in the netconf package. -- To view, visit http://gerr

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 1: (1 comment) File vdsm/netconf/ifcf

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6027/ : SUCCESS

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-11 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: ifcfg: include HWADDR line only if NM is around .. ifcfg: include HWADDR line only if NM is around In prehistoric days, our ifcfg files included HWADDR lines f