gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit htt
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 6:
Lets move faster, If Adam has issues with this we will enhance this later.
--
To view, visit https://gerrit.
Nir Soffer has submitted this change and it was merged.
Change subject: qemuimg: Add the command to QImgError
..
qemuimg: Add the command to QImgError
Change-Id: I226a54b29ae4afc3854056efea78767383b89619
Signed-off-by: Ala Hino
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65179
To unsubscribe, visit https://gerrit.ovirt.org
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 6: Code-Review+1
Waiting for Adam review.
--
To view, visit https://gerrit.ovirt.org/65179
To unsubscribe, visi
Ala Hino has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/65179
To unsubscribe, visit https://gerrit.ovirt.org/sett
Ala Hino has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/65179/5/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 223:
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 5: Code-Review+1
(2 comments)
Looks good, just minor indentation issue.
https://gerrit.ovirt.org/#/c/65179/4/li
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 4:
Please make pep8 tool happy:
23:29:30 ./lib/vdsm/qemuimg.py:100:80: E501 line too long (81 > 79 characters)
2
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65179
To unsubscribe, visit https://gerrit.ovirt.org
Ala Hino has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/65179/3/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 218
Line 2
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/65179/3/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 218
Line
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ala Hino has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 2:
> (1 comment)
how do I get the cmd from the CPopen instance?
--
To view, visit https://gerrit.ovirt.org/65179
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65179/2/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 279:
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65179
To unsubscribe, visit https://gerrit.ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ala Hino has uploaded a new change for review.
Change subject: qemuimg: Add the command to QImgError
..
qemuimg: Add the command to QImgError
Change-Id: I226a54b29ae4afc3854056efea78767383b89619
Signed-off-by: Ala Hino
---
M li
22 matches
Mail list logo
