automat...@ovirt.org has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerr
Nir Soffer has abandoned this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Abandoned
Cannot be fix in current code.
--
To view, visit https://gerrit.ovirt.org/25284
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
Saggi, I think the order suggested in this patch *is* the logical order. Even
if the
Saggi Mizrahi has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
It's not about returning the RequestRef it's about hoping nothing fails between.
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
Saggi, in registerResource, a new request object is created for each call. This
obje
Saggi Mizrahi has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
Another possibility
Maybe panic() in case of an unexpected error.
--
To view, vi
Saggi Mizrahi has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4: Code-Review-1
This update is actually wrong.
You can't call resource.grant() befor
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25284/4/vdsm/storage/resourceManager.py
File
Yoav Kleinberger has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25284
To unsubscribe,
Federico Simoncelli has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
Saggi can you review this? Thanks.
--
To view, visit http://gerrit.ovirt.o
Federico Simoncelli has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25284/4/vdsm/storage/resourceManage
Itamar Heim has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
ping?
--
To view, visit http://gerrit.ovirt.org/25284
To unsubscribe, visit http:/
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
ping!
--
To view, visit http://gerrit.ovirt.org/25284
To unsubscribe, visit http://
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
Waking up reviewers
--
To view, visit http://gerrit.ovirt.org/25284
To unsubscribe,
Liron Ar has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/25284/4/tests/resourceManagerTes
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25284/4/tests/resourceManagerTests.py
File t
Liron Ar has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25284/4/tests/resourceManagerTests.py
File tes
oVirt Jenkins CI Server has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
Changes:
- Make pep8 happy
- "timeout=0" is more clear than "0"
--
To view, visit h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 3: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vds
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25284/2/tests/resourceManagerTests.py
File t
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 3:
Changes:
- When checking if resource can be acquired, check both exclusive and shared
Liron Ar has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 2:
(6 comments)
http://gerrit.ovirt.org/#/c/25284/2/tests/resourceManagerTests.py
File te
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 2:
Changes:
- Extract helper assertions
- Move tests higher to acquireResource, so we do
oVirt Jenkins CI Server has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25284/1/vdsm/storage/resourceManager.py
File
Liron Ar has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25284/1/vdsm/storage/resourceManager.py
File v
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25284/1/vdsm/storage/resourceManager.py
File
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/25284/1/tests/resourceManagerTests.py
File
Liron Ar has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 1:
(4 comments)
http://gerrit.ovirt.org/#/c/25284/1/tests/resourceManagerTests.py
File te
oVirt Jenkins CI Server has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/
Nir Soffer has uploaded a new change for review.
Change subject: resourceManager: Keep resource state if registerResource fails
..
resourceManager: Keep resource state if registerResource fails
Previous code was increasing resou
32 matches
Mail list logo
