Adam Litke has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 8: Code-Review+2
(2 comments)
Some minor comments (ok for a separate patch later).
Nir Soffer has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 8: Code-Review-1
I discussed this with Dan, and we agreed to remove the support for sectors from
Nir Soffer has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 8: Code-Review+1
(1 comment)
Looks good, but I want to discuss the ugly bytes/sectors interface
Nir Soffer has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 7: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/46417/7/tests/miscTests.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 8:
* Update tracker::#1221603::OK
* Check Bug-Url::OK
* Check Public Bug::#1221603::OK,
Freddy Rolland has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/46417/7/tests/miscTests.py
File tests/miscTests.py:
Freddy Rolland has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 6:
(15 comments)
https://gerrit.ovirt.org/#/c/46417/6//COMMIT_MSG
Commit Message:
Line 14: is a
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 7:
* Update tracker::#1221603::OK
* Check Bug-Url::OK
* Check Public Bug::#1221603::OK,
Nir Soffer has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46417/4/tests/blockVolumeTests.py
File
Adam Litke has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46417/4/tests/blockVolumeTests.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 6:
* Update tracker::#1221603::OK
* Check Bug-Url::OK
* Check Public Bug::#1221603::OK,
Freddy Rolland has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 5:
(7 comments)
https://gerrit.ovirt.org/#/c/46417/5/client/vdsClient.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 6: Code-Review-1
(15 comments)
This is full of nice things. Just need to fix validateSize and
Nir Soffer has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 5: Code-Review-1
(3 comments)
Partial review
Nir Soffer has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 5:
(4 comments)
https://gerrit.ovirt.org/#/c/46417/5/client/vdsClient.py
File client/vdsClient.py:
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 5:
* Update tracker::#1221603::OK
* Check Bug-Url::OK
* Check Public Bug::#1221603::OK,
Freddy Rolland has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 3:
(17 comments)
https://gerrit.ovirt.org/#/c/46417/3//COMMIT_MSG
Commit Message:
Line 6:
Line
Freddy Rolland has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 4:
(18 comments)
https://gerrit.ovirt.org/#/c/46417/4/tests/blockVolumeTests.py
File
Adam Litke has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 4:
(5 comments)
https://gerrit.ovirt.org/#/c/46417/4/tests/blockVolumeTests.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 4: Code-Review-1
(18 comments)
https://gerrit.ovirt.org/#/c/46417/4/tests/blockVolumeTests.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 4:
* Update tracker::#1221603::OK
* Check Bug-Url::OK
* Check Public Bug::#1221603::OK,
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/46417
to review the following change.
Change subject: storage: Initial size for thin provisioning disk
..
storage: Initial size
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1221603::ERROR, private
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1221603::ERROR, private
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1221603::ERROR, private
Nir Soffer has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/46417/3/vdsm/storage/fileVolume.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 3: Code-Review-1
(14 comments)
https://gerrit.ovirt.org/#/c/46417/3//COMMIT_MSG
Commit Message:
Nir Soffer has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 3:
(1 comment)
Partial review, will review rest later.
Arik Hadas has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 3: Code-Review+1
(2 comments)
minor comments inside. very important patch for import VMs using
29 matches
Mail list logo
