gerrit-hooks has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: add tests for sampling.VMBulkSampler
..
tests: add tests for sampling.VMBulkSampler
The VMBulkSampler class is responsible of the bulk stats
Dan Kenigsberg has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 5: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/55856
To unsubscribe,
Martin Polednik has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55856
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 5:
seems worse than that:
00:09:05.507 ../tests/run_tests_local.sh: line 6: 17806 Segmentation
Martin Polednik has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 5: Code-Review-1
seems like bulk_samping_test.py missing in specfile
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55856
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 5: Verified+1
verified running the tests
--
To view, visit https://gerrit.ovirt.org/55856
To
gerrit-hooks has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Polednik has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 4: Code-Review+1
(1 comment)
I'm fine with the code as is (and would prefer it in with minor glitch
Francesco Romani has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 4:
(5 comments)
https://gerrit.ovirt.org/#/c/55856/4/tests/bulk_sampling_test.py
File
Martin Polednik has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 4: Code-Review-1
(5 comments)
Some questions inside, not sure I prefer the context managers to
Francesco Romani has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 4: Verified+1
changed only in comments
--
To view, visit https://gerrit.ovirt.org/55856
To
gerrit-hooks has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 3: Verified+1
verified running the tests
--
To view, visit https://gerrit.ovirt.org/55856
To
Francesco Romani has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/55856/3/tests/bulk_sampling_test.py
File
gerrit-hooks has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 2:
(6 comments)
https://gerrit.ovirt.org/#/c/55856/2/tests/bulk_sampling_test.py
File
Francesco Romani has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 2:
(7 comments)
https://gerrit.ovirt.org/#/c/55856/2/tests/bulk_sampling_test.py
File
gerrit-hooks has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 49:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/40053
To
Francesco Romani has abandoned this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Abandoned
too messy, let's restart from scratch in https://gerrit.ovirt.org/55856
--
To view, visit
Francesco Romani has uploaded a new change for review.
Change subject: tests: add tests for sampling.VMBulkSampler
..
tests: add tests for sampling.VMBulkSampler
The VMBulkSampler class is responsible of the bulk stats
gerrit-hooks has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 48:
(2 comments)
https://gerrit.ovirt.org/#/c/40053/48/tests/virt/bulk_sampling_test.py
File
Milan Zamazal has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 48:
(1 comment)
https://gerrit.ovirt.org/#/c/40053/48/tests/virt/bulk_sampling_test.py
File
Francesco Romani has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 49: Verified+1
fixed comments from Martin: I don't actually need anymore to clear the
_skip_doms
gerrit-hooks has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 49:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 48:
(5 comments)
https://gerrit.ovirt.org/#/c/40053/48/lib/vdsm/virt/sampling.py
File
Martin Polednik has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 48: Code-Review-1
(4 comments)
Mostly okay, minor things, I could live without them being in at the
gerrit-hooks has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 48:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 47:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 46: Verified+1
verified running the tests themselves
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 46:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 45:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 44:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 42:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 41:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 43:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 40:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 39:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 38:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 37:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 33:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 34:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 35:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 36:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Milan Zamazal has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 36: Code-Review-1
(3 comments)
The tests take relatively long time to run. It would be nice to make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 32:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 31:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 29:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 30:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Martin Polednik has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 28: Code-Review+1
(3 comments)
Tests with very steep understanding curve. Few notes inside, but I'd
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 28:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 27:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 24:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 25:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 26:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 23:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
59 matches
Mail list logo
