Francesco Romani has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 3:
(1 comment)
Tomas: yes, your explanation about overloading this API and not adding a new
one is
Martin Polednik has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/57418/3//COMMIT_MSG
Commit Message:
PS3, Line 7: Lazy
> What
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/57418/3//COMMIT_MSG
Commit Message:
PS3, Line 7: Lazy
>
Martin Polednik has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/57418/3//COMMIT_MSG
Commit Message:
PS3, Line 7: Lazy
Martin Polednik has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/57418/3/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Shahar Havivi has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57418
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57418
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 3:
* #1294629::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1294629::OK, public bug
* Check
Milan Zamazal has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 2:
(1 comment)
Just one PEP8 issue, otherwise fine for me now.
gerrit-hooks has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 2:
* #1294629::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1294629::OK, public bug
* Check
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 1:
(3 comments)
Francesco: You mean why not add another API call? The name 'getExternalVMs'
seems
Francesco Romani has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 1:
(1 comment)
initial review.
Have you explored the possibility of adding a new verb instead of adding
Milan Zamazal has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/57418/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 413:
Shahar Havivi has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/57418/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 1: Verified+1
(1 comment)
https://gerrit.ovirt.org/#/c/57418/1/lib/api/vdsm-api.yml
File
Tomas Golembiovsky has uploaded a new change for review.
Change subject: v2v: Lazy loading of external VMs info
..
v2v: Lazy loading of external VMs info
API changes allowing implementation of lazy loading of information about
gerrit-hooks has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 1:
* #1294629::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1294629::OK, public bug
* Check
17 matches
Mail list logo
