gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
virt: Move Vm._getUnderlyingDriveInfo() out of Vm
This generally follows the Sound device
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/53677/11/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Francesco Romani has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 13: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53677
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 13: Code-Review+1
Thanks, looks better now.
--
To view, visit https://gerrit.ovirt.org/53677
To
Nir Soffer has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/53677/11/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 13: Verified+1
--
To view, visit https://gerrit.ovirt.org/53677
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 11:
(3 comments)
https://gerrit.ovirt.org/#/c/53677/11/vdsm/virt/vm.py
File vdsm/virt/vm.py:
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 11:
(3 comments)
https://gerrit.ovirt.org/#/c/53677/11/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Francesco Romani has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 11: Code-Review+1
waiting for ACK from Nir (or other storage dev)
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 11: Verified+1
Verified by running a VM from Engine, migrating it to another host and back,
and
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 7: Code-Review+2
question answered, seems ok -> raising score
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/53677/7/tests/devices/data/testComplexVm.xml
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/53677/7/tests/devices/data/testComplexVm.xml
File
Francesco Romani has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 7: Code-Review+1
(1 comment)
partial ACK because of one inline question (but looks good
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
24 matches
Mail list logo
