Francesco Romani has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 3: Code-Review+1
(1 comment)
looks OK, question inside, trying to find a more specific option
Nir Soffer has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/49535/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3129:
Francesco Romani has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 3: Code-Review+2
(1 comment)
raising score after last comment(s).
Adam Litke has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49535
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 3:
I agree that memory snapshots without disks are a valid use case. Consider
LiveCD environments.
--
Nir Soffer has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 3: Code-Review+2
Thanks for the reviews!
--
To view, visit https://gerrit.ovirt.org/49535
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 4:
* #1287066::Update tracker: OK
* Set MODIFIED::bug 1287066#1287066OK
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: vm: enabling memory snapshot without disks
..
vm: enabling memory snapshot without disks
Taking a memory snapshot of a VM without disks should be
Arik Hadas has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 2: Code-Review+1
yeah, if memory snapshot is not taken along with disk snapshots, as it seems to
be the
Nir Soffer has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/49535/2//COMMIT_MSG
Commit Message:
Line 11:
Line 12: Hence,
Daniel Erez has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 2:
Verified the flows mentioned in the commit message. I.e. memory snapshot on a
VM with Cinder disks or
Nir Soffer has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 2: Code-Review+1
Waiting for reviews from virt guys, Adam.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 2:
Daniel, can you explain how you tested this? what flows were tested? what was
not tested?
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 3:
* #1287066::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1287066::OK, public bug
*
Daniel Erez has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 2:
Thanks Michal and Arik.
@Nir/Francesco - can we move forward with this then?
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 2:
* #1287066::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1287066::OK, public bug
*
16 matches
Mail list logo
