Milan Zamazal has posted comments on this change.
Change subject: virt: Fix of uninitialized variable access in
Vm.setLinkAndNetwork()
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53061/1/vdsm/virt/vm.py
File
Milan Zamazal has posted comments on this change.
Change subject: Make VM._correctGraphicsConfiguration use DomainDescriptor
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52823/1/vdsm/virt/domain_descriptor.py
File
Milan Zamazal has posted comments on this change.
Change subject: Make VM._correctGraphicsConfiguration use DomainDescriptor
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52823/1/vdsm/virt/domain_descriptor.py
File
Milan Zamazal has posted comments on this change.
Change subject: XML helper for virt introduced
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/52821/1//COMMIT_MSG
Commit Message:
Line 14:
Line 15: The rough plan
Milan Zamazal has posted comments on this change.
Change subject: virt: rng: Rng device should not depend on caps.py
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53558/1/vdsm/virt/vmdevices/core.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: rng: Rng device should not depend on caps.py
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53558
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: rng: Rng device should not depend on caps.py
..
Patch Set 1: Code-Review-1
(3 comments)
Good change, just some stylistic issues.
Milan Zamazal has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 4: Code-Review-1
Please take care about other objects related to those and only to those
methods.
Milan Zamazal has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 5: Code-Review-1
testGraphicsDeviceLegacy should probably be also removed (it fails now). Other
test
Milan Zamazal has posted comments on this change.
Change subject: virt: recovery: tests: exercise more recovery code
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53690
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: tests: improve vmstats.disks coverage
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53994
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: tests: extend coverage for vmstats.disks()
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53993
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: periodic: ignore known-benign libvirt errors
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53999
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48417
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: extract destroyVm helper
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53932/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3878:
Milan Zamazal has posted comments on this change.
Change subject: virt: extract destroyVm helper
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53932/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3878:
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Move Vm._getUnderlyingBalloonDeviceInfo() out of Vm
..
virt: Move Vm._getUnderlyingBalloonDeviceInfo() out of Vm
This is just a simple move of code,
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Move Vm._getUnderlyingWatchdogDeviceInfo() out of Vm
..
virt: Move Vm._getUnderlyingWatchdogDeviceInfo() out of Vm
This is just a simple move of code,
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Move Vm._getUnderlyingSmartcardDeviceInfo() out of Vm
..
virt: Move Vm._getUnderlyingSmartcardDeviceInfo() out of Vm
This is just a simple move of code,
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Move Vm._getUnderlyingControllerDeviceInfo() out of Vm
..
virt: Move Vm._getUnderlyingControllerDeviceInfo() out of Vm
This is just a simple move of
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Move Vm._getUnderlyingRngDeviceInfo() out of Vm
..
virt: Move Vm._getUnderlyingRngDeviceInfo() out of Vm
This is just a simple move of code, following
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Move Vm._getUnderlyingVideoDeviceInfo() out of Vm
..
virt: Move Vm._getUnderlyingVideoDeviceInfo() out of Vm
This is just a simple move of code,
Milan Zamazal has uploaded a new change for review.
Change subject: virt: New method Vm.get_devices
..
virt: New method Vm.get_devices
This is a preparation step for moving Vm._getUnderlying*() methods from
Vm to device
Milan Zamazal has posted comments on this change.
Change subject: virt: extract destroyVm helper
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53932/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3862:
Milan Zamazal has posted comments on this change.
Change subject: virt: extract destroyVm helper
..
Patch Set 1: Code-Review+1
(2 comments)
Conditional +1, see the comments in the code.
Milan Zamazal has posted comments on this change.
Change subject: virt: clean and modernize the destroy() path
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53931
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: destroy: try harder destroying a Vm
..
Patch Set 2:
+1 for the fix AFAICT... Playing the catch-up game is not nice, but probably
still better than data
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingConsoleDeviceInfo() out of Vm
..
Patch Set 7:
Yes, the methods should be generalized, yes, only after the move.
I split the patch to
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/53618/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53679/1/vdsm/virt/vmdevices/core.py
File
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py
..
virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py
This is a preparation step for the next
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingSoundDeviceInfo() out of Vm
..
Patch Set 2:
underlying* methods renamed, docstring moved to a base method.
@classmethod retained.
Milan Zamazal has posted comments on this change.
Change subject: virt: Vm._getUnderlyingSoundDeviceInfo() moved to core.py
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/53616/2/vdsm/virt/vmdevices/core.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Add `vm' argument to underlying_device_info methods
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/53676/1//COMMIT_MSG
Commit Message:
Line
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py
..
Patch Set 5:
> not sure if this is more xml processing or more device handling.
It should probably
Milan Zamazal has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: migration: set timeout to 10 mins
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52548
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: safer removal of the recovery file
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52515
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: Return deep copy from GuestAgent.getGuestInfo()
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52499/1/vdsm/virt/guestagent.py
File
Milan Zamazal has posted comments on this change.
Change subject: Return deep copy from GuestAgent.getGuestInfo()
..
Patch Set 2: Verified+1
Verified by running tests.
I also checked performance with a rather large list in
Milan Zamazal has posted comments on this change.
Change subject: virt: Switch from minidom to etree in DomainDescriptor
..
Patch Set 2:
(1 comment)
The size of the patch worries me too as it makes checking the code a bit
Milan Zamazal has posted comments on this change.
Change subject: vm: extract cleanupRecoveryFile() helper
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52514
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: make _deleteVm() more robust
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52516
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: delete recovery file only after destroy()
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52517
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: stats: make compute_latency more robust
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/50593/9/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:
Milan Zamazal has posted comments on this change.
Change subject: caps: refactor cpuinfo parsing
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/51523/4/vdsm/caps.py
File vdsm/caps.py:
Line 115:
Milan Zamazal has posted comments on this change.
Change subject: net: Enable VDSM to perform migration over IPv6
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51933
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: caps: refactor cpuinfo parsing
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51523
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: Simplify filter using list comprehension
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53503
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Fix of uninitialized variable access in
Vm.setLinkAndNetwork()
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/53061
To
Milan Zamazal has posted comments on this change.
Change subject: tests: use new proxy method for virt functional tests
..
Patch Set 1: Code-Review+1
Thanks, let's make functional tests working again!
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: recovery: tests: exercise more recovery code
..
Patch Set 5: Code-Review-1
(2 comments)
Not liking code duplication, otherwise fine for me.
Milan Zamazal has posted comments on this change.
Change subject: virt: Don't use Vm device configuration in clientIF
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/53482/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Milan Zamazal has posted comments on this change.
Change subject: virt: Don't use Vm device configuration in clientIF
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/53482/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Don't use Vm device configuration in clientIF
..
virt: Don't use Vm device configuration in clientIF
clientIF retrieves device configuration from
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
virt: Make Vm.devSpecMapFromConf() private
There is currently no reason to expose the method outside Vm.
Actually
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Make Vm.devMapFromDevSpecMap() private
..
virt: Make Vm.devMapFromDevSpecMap() private
There is currently no reason to expose the method outside Vm.
Milan Zamazal has posted comments on this change.
Change subject: virt: Move legacy sound conf from Vm to vmdevices
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/53485/3/vdsm/virt/vmdevices/core.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Move video legacy conf out of Vm
..
Patch Set 4:
Split by the devices.
--
To view, visit https://gerrit.ovirt.org/53486
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Move graphics legacy conf processing out of Vm
..
Patch Set 4:
legacy_conf() is @staticmethod everywhere now.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Use PEP8 identifiers in vmxml.device_address
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54511/1/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Milan Zamazal has posted comments on this change.
Change subject: virt: more moving under site-packages
..
Patch Set 4: Code-Review-1
guestagentTests.py tests fail. It's probably due to "from virt.guestagent"
embedded in two
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm
..
Patch Set 11: Verified+1
Verified by running a VM from Engine, migrating it to another host and
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 11: Verified+1
Verified by running a VM from Engine, migrating it to another host and back,
and
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm
..
Patch Set 12: Verified+1
Verified by running a VM from Engine, migrating it to another host and
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingControllerDeviceInfo() out of Vm
..
Patch Set 5: Verified+1
Verified by running a VM from Engine, migrating it to another host and
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingBalloonDeviceInfo() out of Vm
..
Patch Set 5: Verified+1
Verified by running a VM from Engine, migrating it to another host and
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingSoundDeviceInfo() out of Vm
..
Patch Set 9: Verified+1
Verified by running a VM with a sound device enabled, migrating it to another
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingVideoDeviceInfo() out of Vm
..
Patch Set 4: Verified+1
Verified by running a VM from Engine, migrating it to another host and back,
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py
..
Patch Set 8: Verified+1
Verified by running a VM, migrating it to another host and back, and stopping
Milan Zamazal has posted comments on this change.
Change subject: virt: Use PEP8 identifiers in vmxml.device_address
..
Patch Set 3: Verified+1
Verified by running a VM, migrating it to another host and back, and stopping
it.
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm
..
Patch Set 11: Verified+1
Verified by running a VM from Engine, migrating it to another host and
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingRngDeviceInfo() out of Vm
..
Patch Set 5: Verified+1
Verified by running a VM with a rng device enabled, migrating it to another
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingSmartcardDeviceInfo() out of Vm
..
Patch Set 5: Verified+1
Verified by running a VM with a smartcard device enabled, migrating it to
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingConsoleDeviceInfo() out of Vm
..
Patch Set 10: Verified+1
Verified by running a VM from Engine, migrating it to another host and
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingWatchdogDeviceInfo() out of Vm
..
Patch Set 5: Verified+1
Verified by running a VM with a watchdog device enabled, migrating it to
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm
..
Patch Set 8:
> please fix 53678 before
Done.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: more moving under site-packages
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54366
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm
..
Patch Set 12: Verified+1
Verified by running a VM from Engine, migrating it to another host and back,
Milan Zamazal has posted comments on this change.
Change subject: guest-agent: Fix API version negotiation
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54871
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: guest-agent: Fix API version negotiation
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54896
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingNetworkInterfaceInfo() out of Vm
..
Patch Set 12: Verified+1
Verified by running a VM from Engine, migrating it to another host and
Milan Zamazal has posted comments on this change.
Change subject: travis: Add python-ioprocess
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55738
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: build: Make sure run_tests*.sh scripts are executable
..
Patch Set 1:
(3 comments)
Indeed, the commit message is inaccurate (my confusion). I can be happy with
Milan Zamazal has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 22: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit
Milan Zamazal has uploaded a new change for review.
Change subject: tests/functional: Remove storage tests references from virtTests
..
tests/functional: Remove storage tests references from virtTests
Milan Zamazal has uploaded a new change for review.
Change subject: tests: Use integer division for array index in SchedulerTests
..
tests: Use integer division for array index in SchedulerTests
In Python 3 the standard
Milan Zamazal has posted comments on this change.
Change subject: Remove debian install files from vdsm
..
Patch Set 2: Code-Review+1
Vdsm builds fine now.
--
To view, visit https://gerrit.ovirt.org/55717
To unsubscribe,
Milan Zamazal has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 7: Code-Review+1
Looks basically OK to me.
--
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe,
Milan Zamazal has posted comments on this change.
Change subject: build: Make sure run_tests*.sh scripts are executable
..
Patch Set 1: Code-Review-1
The patch is wrong, because @top_srcdir@ in run_tests*.sh.in is replaced by
Milan Zamazal has posted comments on this change.
Change subject: tests/functional: Remove storage tests references from virtTests
..
Patch Set 1: Verified+1
I verified that virTests passes.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: build: Make sure run_tests*.sh scripts are executable
..
Patch Set 1:
(1 comment)
> can you elaborate the questions..
With this patch, resulting
Milan Zamazal has posted comments on this change.
Change subject: schedule: Port schedule module to Python 3
..
Patch Set 2: Code-Review-1
(2 comments)
Just some typos, otherwise `make check-all' works fine for me now.
Milan Zamazal has posted comments on this change.
Change subject: vm: graphics: fill legacy display parameters
..
Patch Set 3: Code-Review+1
(1 comment)
Just a typo in the commit message, otherwise fine for me.
Milan Zamazal has posted comments on this change.
Change subject: schedule: Port schedule module to Python 3
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55880
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: Remove debian install files from vdsm
..
Patch Set 1: Code-Review-1
There are more changes needed -- Vdsm doesn't build with this patch.
Otherwise we are
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm
..
Patch Set 11:
This final patch depends on all previous patches, so we must wait for
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm
..
Patch Set 12:
Some test code added to better cover the moved code.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm
..
Patch Set 12: Verified+1
Verified by running a VM from Engine, migrating it to another host and
Milan Zamazal has posted comments on this change.
Change subject: virt: Storage device legacy conf processing moved out of Vm
..
Patch Set 11:
Yes, I'm going to delete this whole patch series (in favor of
301 - 400 of 805 matches
Mail list logo
