Milan Zamazal has posted comments on this change. Change subject: caps: refactor cpuinfo parsing ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/51523/4/vdsm/caps.py File vdsm/caps.py: Line 115: self.fields['frequency'] = value[:-3] Line 116: Line 117: if key == 'model name' or key == 'cpu': Line 118: self.fields['model'] = value Line 119: Why all the empty lines in this method? Line 120: if len(self.fields) == 3: Line 121: break Line 122: Line 123: def flags(self): -- To view, visit https://gerrit.ovirt.org/51523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib705bba4789bd1938bf26ae387af72b079020ce7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
