Piotr Kliczewski has posted comments on this change.
Change subject: protocoldetecor: SSLError handled not correctly
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/42206/3/vdsm/protocoldetector.py
File vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: status: adding elapsed time in millis
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/40904/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 404
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/19/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1181
Piotr Kliczewski has posted comments on this change.
Change subject: status: logging status values before sending event
..
Patch Set 4: Verified+1
Verified with the engine containing event changes to see that events are send
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 19: Verified+1
Verified with the engine containing event changes to see that events are send
on vm status
Piotr Kliczewski has posted comments on this change.
Change subject: status: adding elapsed time in millis
..
Patch Set 9: Verified+1
Verified with the engine containing event changes to see that events are send
on vm status
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: events
..
Patch Set 28: Verified+1
Verified with the engine containing event changes to see that events are send
on vm status changes.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/19/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 393
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 20: Verified+1
Rebased and fixed 2 comments (removals). Copying verify flag from previous
patch set
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: allow single stomp reactor
..
Patch Set 9:
Test failure not related to this change.
--
To view, visit https://gerrit.ovirt.org/41070
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 24: Verified+1
Added separate queue for events.
Verified by testing vm status change.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: add an option to create a stomp client
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/38491/10/vdsm/clientIF.py
File vdsm/clientIF.py
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: use subscription when creating a client
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40307
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: migration: Use jsonrpc during migration of vms
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/36701/14/vdsm/virt/migration.py
File vdsm/virt
Piotr Kliczewski has posted comments on this change.
Change subject: sslutils: move createSSLContext from clientIF
..
Patch Set 11: Code-Review+1
I agree with Nir's last comment.
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc
..
Patch Set 10: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/39203/10/lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: vdscliTests: add a test for connect with a timeout
..
Patch Set 12: Code-Review-1
I do not understand what we want to push certs and keys to repo. We already
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: events
..
Patch Set 26:
Build failure not related to this change.
--
To view, visit https://gerrit.ovirt.org/38069
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: status: adding elapsed time in millis
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/40904/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 407
Piotr Kliczewski has abandoned this change.
Change subject: stomp: creation of outbox class
..
Abandoned
This patch is no longer needed.
--
To view, visit https://gerrit.ovirt.org/41067
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: status: adding elapsed time in millis
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/40904/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 387
Line
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 26: Verified-1
This patch set is broken due to wrong squash with Outbox class.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: reactor: move creation to clientIF
..
Patch Set 13: Verified+1
Verified by running with latest engine containing event changes.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 27: Verified+1
Verified by running with latest engine containing event changes.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: status: logging status values before sending event
..
Patch Set 3: Verified+1
Verified by running with latest engine containing event changes.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: status: adding elapsed time in millis
..
Patch Set 8: Verified+1
Verified by running with latest engine containing event changes.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: status: adding elapsed time in millis
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/40904/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 404
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: calling super explicitly
..
Patch Set 4: Verified+1
Verified by running with latest engine containing event changes.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: allow single stomp reactor
..
Patch Set 7: Verified+1
Verified by running with latest engine containing event changes.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 21: Verified+1
Verified by running with latest engine containing event changes.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 26: Verified+1
Verified by running with latest engine containing event changes.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: status: adding elapsed time in millis
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/40904/7/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi
Piotr Kliczewski has posted comments on this change.
Change subject: vdscliTests: add a test for connect with a timeout
..
Patch Set 13: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/38806/13/tests/Makefile.am
File
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: add an option to create a stomp client
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/38491/10/vdsm/clientIF.py
File vdsm/clientIF.py
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 28:
(2 comments)
https://gerrit.ovirt.org/#/c/38451/28/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc
Piotr Kliczewski has posted comments on this change.
Change subject: stompReactor: fix naming of default destination
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/40345/13//COMMIT_MSG
Commit Message:
Line 3
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: create pv with custom dataalignment value
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42782
To unsubscribe, visit
Piotr Kliczewski has abandoned this change.
Change subject: tests: skip jsonrpc tests
..
Abandoned
This patch is not needed anymore.
--
To view, visit https://gerrit.ovirt.org/42774
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: tests: functional - convert to run over jsonrpc
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/43092/2/lib/vdsm/jsonrpcvdscli.py
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: do not block forever when waiting on incoming messages
..
Patch Set 3: Verified+1
Verified by updating a vdsm and changing the protocol to xmlrpc
Piotr Kliczewski has posted comments on this change.
Change subject: events: make sure to send only one event per status
..
Patch Set 4: Verified+1
Verified by running latest engine and vdsm and by creating and suspending a vm
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: vdscli: migration: fix migrationCreate
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42970
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: tests: restore default timeout value
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42918/1/tests/jsonRpcTests.py
File tests/jsonRpcTests.py
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: do not block forever when waiting on incoming messages
..
Patch Set 3:
It is not about blocking the server but closing it properly. I checked
Piotr Kliczewski has posted comments on this change.
Change subject: tests: ignore empty frame
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42919/1/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 355
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: check whether the connection is still open before
processing
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42920/1/lib/yajsonrpc
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: do not block forever when waiting on incoming messages
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/42915/4/lib/vdsm/xmlrpc.py
File lib
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: Improve logging during shutdown
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43194
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: standalone client
..
Patch Set 2:
Build issues not related to this change.
--
To view, visit https://gerrit.ovirt.org/42850
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: standalone client
..
Patch Set 2:
(5 comments)
https://gerrit.ovirt.org/#/c/42850/2//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2015-07-02 11:36
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: standalone client
..
Patch Set 2: Verified+1
Verified by running provided tests.
--
To view, visit https://gerrit.ovirt.org/42850
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: do not block forever when waiting on incoming messages
..
Patch Set 3:
Yes, we need to solve it for 3.5. Will try to provide as simple as possible
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonrpc: handle timeout in callMethod
..
jsonrpc: handle timeout in callMethod
When we do not receive any response from the server JsonRpcClient fails
when
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: handle timeout in callMethod
..
Patch Set 1: Verified+1
Verified by running local build.
--
To view, visit https://gerrit.ovirt.org/43167
Piotr Kliczewski has posted comments on this change.
Change subject: test: customize destination for an event
..
Patch Set 1: Verified+1
Verified by running local build.
--
To view, visit https://gerrit.ovirt.org/43168
Piotr Kliczewski has uploaded a new change for review.
Change subject: test: customize destination for an event
..
test: customize destination for an event
During test run we need to customize destinations where events are sent
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: standalone client
..
Patch Set 3: Verified+1
Verified by running local build.
--
To view, visit https://gerrit.ovirt.org/42850
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: vdscli: migration: fix migrationCreate
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42970
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: vdscli: return raw error description
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42969
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: do not block forever when waiting on incoming messages
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/42915/7//COMMIT_MSG
Commit Message
Piotr Kliczewski has posted comments on this change.
Change subject: iscsicred: Protect sensitive return value in supervdsm log
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43178
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: do not block forever when waiting on incoming messages
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/42915/7//COMMIT_MSG
Commit Message
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: do not block forever when waiting on incoming messages
..
Patch Set 4:
Yes, I do. Sent it to you via email.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: do not block forever when waiting on incoming messages
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/42915/5//COMMIT_MSG
Commit Message
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: ssl protocol configurable
..
Patch Set 3:
BUild failed due to jenkins issue. Not related to this change.
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: do not block forever when waiting on incoming messages
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/42915/7//COMMIT_MSG
Commit Message
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: use deque for incoming requests
..
Patch Set 8: Verified+1
Verified with latest engine. Protocol was set to xmlrpc and there were no
issues
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: do not block forever when waiting on incoming messages
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/42915/7//COMMIT_MSG
Commit Message
Piotr Kliczewski has posted comments on this change.
Change subject: tests: restore default timeout value
..
Patch Set 1:
I will mark the slowest test but from time to time all of them timeout. It
depends on particular slave
Piotr Kliczewski has posted comments on this change.
Change subject: tests: marking slow tests with decorator
..
Patch Set 2: Verified+1
Verified by running local test.
--
To view, visit https://gerrit.ovirt.org/42918
):
--
To view, visit https://gerrit.ovirt.org/43183
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb4889cb30f23c5e3e9221893cf07a02d051d8b5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: ssl protocol configurable
..
Patch Set 1: Verified+1
Backported from master so copying verification flag.
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: do not block forever when waiting on incoming messages
..
Patch Set 4: Verified+1
Verified by running local build.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: net: maintain legacy addNetwork/delNetwork APIs
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43187
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: net tests: skip test_setupNetworks_on_external_bond
..
Patch Set 5:
When building on f20 I get:
./tests/functional/networkTests.py:93: redefinition
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
..
Patch Set 12: Verified+1
Verified with latest engine changes containing events.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: status: logging status values before sending event
..
Patch Set 1: Verified+1
Verified with latest engine changes containing events.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: status: adding elapsed time in millis
..
Patch Set 6: Verified+1
Verified with latest engine changes containing events.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: reactor: move creation to clientIF
..
Patch Set 11: Verified+1
Verified with latest engine changes containing events.
--
To view, visit https
Piotr Kliczewski has uploaded a new change for review.
Change subject: status: logging status values before sending event
..
status: logging status values before sending event
Change-Id
Piotr Kliczewski has posted comments on this change.
Change subject: virt: Trigger event on guest agent status changes
..
Patch Set 4: Verified+1
Verified with latest engine changes containing events.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 16: Verified+1
Verified with latest engine changes containing events.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: calling super explicitly
..
Patch Set 2: Verified+1
Verified with latest engine changes containing events.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: allow single stomp reactor
..
Patch Set 5:
Test failure not related to this change
--
To view, visit https://gerrit.ovirt.org/41070
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: gluster:fix NoneType error for some devices does not contain
sysfsPath
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41262
Piotr Kliczewski has posted comments on this change.
Change subject: tests: fix redefinition pyflakes error
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41402
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: schema: fix getMigrationStatus return value
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41414
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: status: adding elapsed time in millis
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/40904/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 411
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
..
Patch Set 11: Verified+1
Verified by running vdsm with the latest engine change. Tested vm status
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: calling super explicitly
..
Patch Set 1: Verified+1
Verified by running vdsm with the latest engine change. Tested vm status
changes:
- starting a vm
Piotr Kliczewski has posted comments on this change.
Change subject: status: adding elapsed time in millis
..
Patch Set 5: Verified+1
Verified by running vdsm with the latest engine change. Tested vm status
changes
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 15: Verified+1
Verified by running vdsm with the latest engine change. Tested vm status
changes:
- starting
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: events
..
Patch Set 24: Verified+1
Verified by running vdsm with the latest engine change. Tested vm status
changes:
- starting a vm
- suspending
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 18: Verified+1
Verified by running vdsm with the latest engine change. Tested vm status
changes
Piotr Kliczewski has posted comments on this change.
Change subject: virt: Trigger event on guest agent status changes
..
Patch Set 3: Verified+1
Verified by running vdsm with the latest engine change. Tested vm status
Piotr Kliczewski has posted comments on this change.
Change subject: status: adding elapsed time in millis
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/40904/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 407
Piotr Kliczewski has posted comments on this change.
Change subject: reactor: move creation to clientIF
..
Patch Set 10: Verified+1
Verified by running vdsm with the latest engine change. Tested vm status
changes:
- starting
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: ignore not needed transport
..
Patch Set 10: Verified+1
Verified by running vdsm with the latest engine change. Tested vm status
changes
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: allow single stomp reactor
..
Patch Set 4: Verified+1
Verified by running vdsm with the latest engine change. Tested vm status
changes:
- starting
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: calling super explicitly
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41269/1/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line
801 - 900 of 2901 matches
Mail list logo