[Viking-devel] another portability nit

2020-03-18 Thread Greg Troxel
In configure, we patch $(INTLTOOL_V_MERGE)_it_tmp_dir=tmp.intltool.$$RANDOM to $(INTLTOOL_V_MERGE)_it_tmp_dir=tmp.intltool.not-random $RANDOM is a bashism not specified by POSIX, and not available in a number of shells. (It is available in NetBSD's /bin/sh, but pkgsrc has a bunch of

Re: [Viking-devel] pkgsrc updated to 1.8, stray visibility defines fix

2020-03-18 Thread Greg Troxel
Robert Norris writes: >> #define _XOPEN_SOURCE > > Simply removing it is the best option, as it compiles and runs on Linux OK > without this line. > I've no idea why it was put in, but the line originates from the initial code > creation back in 2005. > Some background on this define: > >