Re: patch 7.1.080 (extra)

2007-08-19 Fir de Conversatie Mike Williams
On 19/08/2007 00:04, Nico Weber wrote: Hi, On Aug 18, 2007, at 5:00 PM, Bram Moolenaar wrote: Problem:Compiler warnings for using const char * for char *. Solution: Add type casts. (Chris Sutcliffe) at least in C++. this is a very dangerous patch. If you cast a const char* to a

Re: Filename completion broken in Vim 7.1.82

2007-08-19 Fir de Conversatie Martin Toft
On Sat, Aug 18, 2007 at 10:29:04PM -0700, Yegappan Lakshmanan wrote: Hi all, It looks like filename completion in the command-line mode is broken in Vim 7.1.82. I am running Vim 7.1.82 on Linux and see the following issue. $ cd vim7/src $ vim :edit *unix*Tab When I press

Re: Pseudo-verbosity of was set in error handler

2007-08-19 Fir de Conversatie Bram Moolenaar
Suresh Govindachar wrote: The following response to :verbose set foo? was set in error handler is not informative. To be informative, the message should mention something to indicate who/what/when/where was trying to set the illegal value. For example, I

Re: patch 7.1.080 (extra)

2007-08-19 Fir de Conversatie Bram Moolenaar
Nico Weber wrote: On Aug 18, 2007, at 5:00 PM, Bram Moolenaar wrote: Problem:Compiler warnings for using const char * for char *. Solution: Add type casts. (Chris Sutcliffe) at least in C++. this is a very dangerous patch. If you cast a const char* to a char* and then modify

Re: patch to fix bug in cscope feature

2007-08-19 Fir de Conversatie Bram Moolenaar
Dominique Pelle wrote: I don't think that skipping white space before the pattern is a problem. I would rather call it an improvement. However, I think your solution also has the effect that it's not possible to have a space in the pattern. That is undesired. I found another way to

Re: patch to fix bug in cscope feature

2007-08-19 Fir de Conversatie Dominique Pelle
Your solution depends on strtok() changing the space after the command to a NUL. What if there are several spaces: :cs find e a? I don't think it is defined what strtok() does with the extra spaces. They could be replaced with NUL or not. Another solution, which is not clean either, is

Re: Filename completion broken in Vim 7.1.82

2007-08-19 Fir de Conversatie Bram Moolenaar
Martin Toft wrote: On Sat, Aug 18, 2007 at 10:29:04PM -0700, Yegappan Lakshmanan wrote: Hi all, It looks like filename completion in the command-line mode is broken in Vim 7.1.82. I am running Vim 7.1.82 on Linux and see the following issue. $ cd vim7/src $ vim

Re: Patch for mac-specific bug in :winpos

2007-08-19 Fir de Conversatie Jjgod Jiang
Hi, 2007/8/19, Bram Moolenaar [EMAIL PROTECTED]: So is Michael's solution preferred? Simpler doesn't always mean better. Yes, I prefer his solution. - Jiang --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit

Re: Filename completion broken in Vim 7.1.82

2007-08-19 Fir de Conversatie Martin Toft
On Sun, Aug 19, 2007 at 05:52:56PM +0200, Bram Moolenaar wrote: My proposal is that you fix it :-) We have mch_has_wildcard(), but it applies to a whole string, so you need to do some more work. Okidoki :-) I'm sorry to be slow, but my parents suddenly decided to pay me a visit, and you don't

Re: Filename completion broken in Vim 7.1.82

2007-08-19 Fir de Conversatie Bram Moolenaar
Martin Toft wrote: On Sun, Aug 19, 2007 at 05:52:56PM +0200, Bram Moolenaar wrote: My proposal is that you fix it :-) We have mch_has_wildcard(), but it applies to a whole string, so you need to do some more work. Okidoki :-) I'm sorry to be slow, but my parents suddenly decided to

patch to fix buffer overflow in cscope feature

2007-08-19 Fir de Conversatie Dominique Pelle
Hi Valgrind memory checker finds the following bug in cscope feature of vim. I am using vim-7.1 (patches 1-82) on Linux x86. ==8606== Invalid write of size 1 ==8606==at 0x80D17C0: cs_fgets (if_cscope.c:267) ==8606==by 0x818F1E6: find_tags (tag.c:1670) ==8606==by 0x818D0F4: do_tag

Re: Filename completion broken in Vim 7.1.82

2007-08-19 Fir de Conversatie Martin Toft
On Sun, Aug 19, 2007 at 09:11:41PM +0200, Bram Moolenaar wrote: Good catch with ]. By itself it's not recognized, only the matching [ is. How about making a bit cleaner: You are overwriting the string and restoring the character in four places. If we make a vim_isfilec_or_wc() function

Re: patch to fix buffer overflow in cscope feature

2007-08-19 Fir de Conversatie Bram Moolenaar
Dominique Pelle wrote: Valgrind memory checker finds the following bug in cscope feature of vim. I am using vim-7.1 (patches 1-82) on Linux x86. ==8606== Invalid write of size 1 ==8606==at 0x80D17C0: cs_fgets (if_cscope.c:267) ==8606==by 0x818F1E6: find_tags (tag.c:1670)

Re: Filename completion broken in Vim 7.1.82

2007-08-19 Fir de Conversatie Bram Moolenaar
Martin Toft wrote: On Sun, Aug 19, 2007 at 09:11:41PM +0200, Bram Moolenaar wrote: Good catch with ]. By itself it's not recognized, only the matching [ is. How about making a bit cleaner: You are overwriting the string and restoring the character in four places. If we make a