Re: [PATCH] remove hacking code for old IM

2012-08-16 Thread Yukihiro Nakadaira
Attached files is latest patch. This patch adds 'imactivatefunc' and 'imstatusfunc' option. This patch does not break IME because it does nothing when the option is not set. This is only yet another workaround for IM control feature. But it slightly better than 'imactivatekey' because some IM h

Re: [PATCH] remove hacking code for old IM

2012-08-15 Thread Bram Moolenaar
Yasuhiro Matsumoto wrote: > On Thursday, July 19, 2012 8:36:43 PM UTC+9, 依云 wrote: > > On Wed, Jul 18, 2012 at 05:07:23AM -0700, mattn wrote: > > > Please try previous patch. > > > > > > https://gist.github.com/3135711 > > > > I tried this patch. Unfortunately, I don't see any difference. > >

Re: [PATCH] remove hacking code for old IM

2012-07-20 Thread lilydjwg
On Fri, Jul 20, 2012 at 07:48:25PM +0900, Yukihiro Nakadaira wrote: > Here is a quick hack to try out. Hi, I can't try out your example_ibus.vim because when I import ibus from Vim it says "ImportError: /lib/libpyglib-2.0-python2.so.0: undefined symbol: _Py_ZeroStruct" (It's ok outsite Vim). I wro

Re: [PATCH] remove hacking code for old IM

2012-07-20 Thread Yukihiro Nakadaira
Here is a quick hack to try out. -- Yukihiro Nakadaira - yukihiro.nakada...@gmail.com -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php imactivate_user_func

Re: [PATCH] remove hacking code for old IM

2012-07-19 Thread lilydjwg
On Thu, Jul 19, 2012 at 12:40:43AM +0900, Yukihiro Nakadaira wrote: > I think your patch does not fix Lily's problem because it still uses > im_shutdown() and xim_init() to re-create im-context. > > [...] Hi, please refer me as lilydjwg; I don't have an English name yet. -- Best regards, lilydj

Re: [PATCH] remove hacking code for old IM

2012-07-19 Thread lilydjwg
On Thu, Jul 19, 2012 at 09:15:46AM -0700, mattn wrote: > On Thursday, July 19, 2012 8:36:43 PM UTC+9, 依云 wrote: > > [...] > > > > So, my suggestion is to use an option to let Vim not control the IM (those > > codes in #ifdef USE_IM_CONTROL) (maybe in addtion to cleaning up the old > > code). Is th

Re: [PATCH] remove hacking code for old IM

2012-07-19 Thread mattn
On Thursday, July 19, 2012 8:36:43 PM UTC+9, 依云 wrote: > On Wed, Jul 18, 2012 at 05:07:23AM -0700, mattn wrote: > > Please try previous patch. > > > > https://gist.github.com/3135711 > > I tried this patch. Unfortunately, I don't see any difference. > > (I finally find out that) the problem I ha

Re: [PATCH] remove hacking code for old IM

2012-07-19 Thread lilydjwg
On Wed, Jul 18, 2012 at 05:07:23AM -0700, mattn wrote: > Please try previous patch. > > https://gist.github.com/3135711 I tried this patch. Unfortunately, I don't see any difference. (I finally find out that) the problem I have is, Vim will shutdown the IM when entering and leaving normal mode.

Re: [PATCH] remove hacking code for old IM

2012-07-18 Thread mattn
On Monday, July 16, 2012 7:38:53 PM UTC+9, 依云 wrote: > The problem is, without my patch, and with pre-edit enabled, the IM > context is destroyed and re-created, making fcitx tries to activate > the former destroyed IM context. How this work with fcitx? gtk_im_multicontext_set_context_id( xic,

Re: [PATCH] remove hacking code for old IM

2012-07-18 Thread Yukihiro Nakadaira
On Wed, Jul 18, 2012 at 7:22 PM, mattn wrote: > I make sure that some IM is work fine with following patch. > ... I think your patch does not fix Lily's problem because it still uses im_shutdown() and xim_init() to re-create im-context. We need both "activate" and "inactivate" feature to control

Re: [PATCH] remove hacking code for old IM

2012-07-18 Thread mattn
> I updated patch once again. > > https://gist.github.com/3135784 > > Fixed: > > > * Don't work with 'cfX' (X is multi-byte) > > Someone, would you please try this patch. > > Thanks. Ooops. Latest patch does not work with xim-skk. Please try previous patch. https://gist.github.com/3135711

Re: [PATCH] remove hacking code for old IM

2012-07-18 Thread mattn
On Wednesday, July 18, 2012 8:33:52 PM UTC+9, mattn wrote: > On Wednesday, July 18, 2012 7:37:57 PM UTC+9, mattn wrote: > > > * ibus > > > * uim-anthy > > > * uim-skk > > > * uim-xim with skk > > > * uim-xim with anthy > > > > I make sure following IMs are works fine. > > > > * ibu

Re: [PATCH] remove hacking code for old IM

2012-07-18 Thread mattn
On Wednesday, July 18, 2012 7:37:57 PM UTC+9, mattn wrote: > > * ibus > > * uim-anthy > > * uim-skk > > * uim-xim with skk > > * uim-xim with anthy > > I make sure following IMs are works fine. > > * ibus-skk > * ibus-anthy > * ibus-mozc I updated patch. https://gist.github.com/3135711 > * Car

Re: [PATCH] remove hacking code for old IM

2012-07-18 Thread mattn
> * ibus > * uim-anthy > * uim-skk > * uim-xim with skk > * uim-xim with anthy I make sure following IMs are works fine. * ibus-skk * ibus-anthy * ibus-mozc -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more in

Re: [PATCH] remove hacking code for old IM

2012-07-18 Thread mattn
On Wednesday, July 18, 2012 1:39:09 AM UTC+9, Xuetian Weng wrote: > On Tuesday, July 17, 2012 10:39:33 PM UTC+8, Yukihiro Nakadaira wrote: > > Sorry, I misunderstood your suggestion. I understood you suggested to > > remove hack for Ami. But you suggested to remove hack for IM control > > feature

Re: [PATCH] remove hacking code for old IM

2012-07-17 Thread Xuetian Weng
On Tuesday, July 17, 2012 10:39:33 PM UTC+8, Yukihiro Nakadaira wrote: > Sorry, I misunderstood your suggestion. I understood you suggested to > remove hack for Ami. But you suggested to remove hack for IM control > feature. Right? > I think that it is slightly problematic. Although I don't kno

Re: [PATCH] remove hacking code for old IM

2012-07-17 Thread lilydjwg
On Tue, Jul 17, 2012 at 11:39:33PM +0900, Yukihiro Nakadaira wrote: > Sorry, I misunderstood your suggestion. I understood you suggested to > remove hack for Ami. But you suggested to remove hack for IM control > feature. Right? > I think that it is slightly problematic. Although I don't know h

Re: [PATCH] remove hacking code for old IM

2012-07-17 Thread Yukihiro Nakadaira
Sorry, I misunderstood your suggestion. I understood you suggested to remove hack for Ami. But you suggested to remove hack for IM control feature. Right? I think that it is slightly problematic. Although I don't know how many user depend on it. -- Yukihiro Nakadaira - yukihiro.nakada...@gmai

Re: [PATCH] remove hacking code for old IM

2012-07-17 Thread Yukihiro Nakadaira
On Tue, Jul 17, 2012 at 9:10 PM, Yukihiro Nakadaira wrote: > On Tue, Jul 17, 2012 at 8:46 PM, Yukihiro Nakadaira > wrote: >> Your patch removes the code to inactivate Input Method by using >> 'imactivatekey' settings. I don't use 'imactivatekey' because it >> doesn't work in my environment. But

Re: [PATCH] remove hacking code for old IM

2012-07-17 Thread Yukihiro Nakadaira
On Tue, Jul 17, 2012 at 8:46 PM, Yukihiro Nakadaira wrote: > Your patch removes the code to inactivate Input Method by using > 'imactivatekey' settings. I don't use 'imactivatekey' because it > doesn't work in my environment. But removing it is safe? s/inactivate/activate/ -- Yukihiro Nakadai

Re: [PATCH] remove hacking code for old IM

2012-07-17 Thread Yukihiro Nakadaira
Your patch removes the code to inactivate Input Method by using 'imactivatekey' settings. I don't use 'imactivatekey' because it doesn't work in my environment. But removing it is safe? -- Yukihiro Nakadaira - yukihiro.nakada...@gmail.com -- You received this message from the "vim_dev" mailli

Re: [PATCH] remove hacking code for old IM

2012-07-17 Thread Yukihiro Nakadaira
I agree to clean that code. I am using Ubuntu and ibus-anthy. Currently ":set imdisable" doesn't work immediately. 1) :set imdisable 2) Enter insert mode 3) Press IM activate key=> Input Method is activated 4) Leave insert mode with 5) Enter insert mode again 6) Press IM activat

Re: [PATCH] remove hacking code for old IM

2012-07-16 Thread Bram Moolenaar
lilydjwg wrote: > I find some hacking code in src/mbyte.c preventing correct behaviours > for the input method "fcitx", a popular IM among the Chinese and able to > input in other languages, under actively developing. And Google tells > the "Ami" Vim is hacking is outdated and few people mention

[PATCH] remove hacking code for old IM

2012-07-16 Thread lilydjwg
Hi, I find some hacking code in src/mbyte.c preventing correct behaviours for the input method "fcitx", a popular IM among the Chinese and able to input in other languages, under actively developing. And Google tells the "Ami" Vim is hacking is outdated and few people mention it. The wrong behavi