[PATCH] testdir: Add test88 to check +conceal with tabulators. (Was: [PATCH 2/2] doc/autocmd.txt: Fix indentation with conceal.)

2012-09-06 Fir de Conversatie Simon Ruderich
On Wed, Sep 05, 2012 at 10:22:34AM -0700, ZyX wrote: It works from inside expression mappings, like nnoremap expr GG :echom .screenrow(). .screencol().\n . I believe it is fine and correct behavior: always reporting real cursor position. Not very convenient, but correct, and completely

Re: [PATCH] testdir: Add test88 to check +conceal with tabulators. (Was: [PATCH 2/2] doc/autocmd.txt: Fix indentation with conceal.)

2012-09-06 Fir de Conversatie Bram Moolenaar
Simon Ruderich wrote: Thanks for the hint. Attached is a testcase which ports my old tests to use your suggestion. I noticed that screencol()/screenrow() start from zero while the other *col() functions start from one. Should I update my screencol()/screenrow() patch? Yes, it would be

Re: [PATCH 2/2] doc/autocmd.txt: Fix indentation with conceal.

2012-09-05 Fir de Conversatie Bram Moolenaar
Simon Ruderich wrote: [...] There is a patch pending which fixes those alignment issues among other problems (whether Vim uses conceal feature or not). Thanks for pointing me to this patch. It fixes a few tab related issues I just noticed (and tried to fix - you saved me some time,

Re: [PATCH 2/2] doc/autocmd.txt: Fix indentation with conceal.

2012-09-05 Fir de Conversatie Bram Moolenaar
Simon Ruderich wrote: diff --git a/runtime/doc/autocmd.txt b/runtime/doc/autocmd.txt index 7a5fa04..fe77265 100644 --- a/runtime/doc/autocmd.txt +++ b/runtime/doc/autocmd.txt @@ -203,7 +203,7 @@ Name triggered by ~ Reading |BufNewFile| starting to edit

Re: [PATCH 2/2] doc/autocmd.txt: Fix indentation with conceal.

2012-09-05 Fir de Conversatie Simon Ruderich
On Wed, Sep 05, 2012 at 03:46:00PM +0200, Bram Moolenaar wrote: Thanks for pointing me to this patch. It fixes a few tab related issues I just noticed (and tried to fix - you saved me some time, thanks). Which patch is that, who sent it? It's Dominique Pellé's patch:

Re: [PATCH 2/2] doc/autocmd.txt: Fix indentation with conceal.

2012-09-05 Fir de Conversatie ZyX
I tried to add the functions (patch attached - as I'm new to Vim internals, please tell me if that's the correct way to do it), but there is one major problem. screen_cur_col and screen_cur_row report the current cursor position - which is of course the command line where the current command

Re: [PATCH 2/2] doc/autocmd.txt: Fix indentation with conceal.

2012-09-05 Fir de Conversatie Charles Campbell
Simon Ruderich wrote: On Wed, Sep 05, 2012 at 03:46:00PM +0200, Bram Moolenaar wrote: Thanks for pointing me to this patch. It fixes a few tab related issues I just noticed (and tried to fix - you saved me some time, thanks). Which patch is that, who sent it? It's Dominique

Re: [PATCH 2/2] doc/autocmd.txt: Fix indentation with conceal.

2012-09-05 Fir de Conversatie Charles Campbell
Charles Campbell wrote: Simon Ruderich wrote: On Wed, Sep 05, 2012 at 03:46:00PM +0200, Bram Moolenaar wrote: Thanks for pointing me to this patch. It fixes a few tab related issues I just noticed (and tried to fix - you saved me some time, thanks). Which patch is that, who sent it? It's

[PATCH 2/2] doc/autocmd.txt: Fix indentation with conceal.

2012-09-04 Fir de Conversatie Simon Ruderich
--- runtime/doc/autocmd.txt | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/runtime/doc/autocmd.txt b/runtime/doc/autocmd.txt index 7a5fa04..fe77265 100644 --- a/runtime/doc/autocmd.txt +++ b/runtime/doc/autocmd.txt @@ -203,7 +203,7 @@ Name

Re: [PATCH 2/2] doc/autocmd.txt: Fix indentation with conceal.

2012-09-04 Fir de Conversatie Dominique Pellé
Simon Ruderichwrote: --- runtime/doc/autocmd.txt | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/runtime/doc/autocmd.txt b/runtime/doc/autocmd.txt index 7a5fa04..fe77265 100644 --- a/runtime/doc/autocmd.txt +++

Re: [PATCH 2/2] doc/autocmd.txt: Fix indentation with conceal.

2012-09-04 Fir de Conversatie Simon Ruderich
On Tue, Sep 04, 2012 at 06:14:19PM +0200, Dominique Pellé wrote: Hi Simon I can see why you want to patch this, but I think that the patch should not be applied. It's a work around for a bug in Vim. It's also breaking indentation when using set concealllevel=0 or when conceal feature is not

Re: [PATCH 2/2] doc/autocmd.txt: Fix indentation with conceal.

2012-09-04 Fir de Conversatie Simon Ruderich
--- /dev/null +++ b/src/testdir/test88.ok @@ -0,0 +1,34 @@ [snip] +[8;1H +[8;9H +[8;17H +[8;25H +[8;26H +[24;1H :q- +[24;1H - Hm, looks like the patch was mangled. In both marked spots (-) there's a ^M (\r) missing at the end-of-line. Regards, Simon