Re: Patch 7.4.1996

Nikolay Pavlov wrote: > >> I am also wondering why evalcmd()? When discussing the name in Neovim > >> bug tracker I was against `evalcmd()` because for `eval('expr')` > >> expression result is expected to be the only effect (though it is not > >> necessary, most expressions used with `eval()` do

Re: Patch 7.4.1996

Hi Nikolay! On Sa, 09 Jul 2016, Nikolay Aleksandrovich Pavlov wrote: > 2016-07-08 13:36 GMT+03:00 Bram Moolenaar : > > > > Nikolay Pavlov wrote: > > > >> I am also wondering why evalcmd()? When discussing the name in Neovim > >> bug tracker I was against `evalcmd()` because

Re: Patch 7.4.1996

2016-07-08 13:36 GMT+03:00 Bram Moolenaar : > > Nikolay Pavlov wrote: > >> I am also wondering why evalcmd()? When discussing the name in Neovim >> bug tracker I was against `evalcmd()` because for `eval('expr')` >> expression result is expected to be the only effect (though it

Re: Patch 7.4.1996

Christian Brabandt wrote: > On Do, 07 Jul 2016, Bram Moolenaar wrote: > > > > > Patch 7.4.1996 > > Problem:Capturing the output of a command takes a few commands. > > Solution: Add evalcmd(). > > Files: src/eval.c, runtime/doc/eval.txt, src/testdi

Re: Patch 7.4.1996

Hi Bram! On Fr, 08 Jul 2016, Bram Moolenaar wrote: > > Christian Brabandt wrote: > > > On Fr, 08 Jul 2016, Bram Moolenaar wrote: > > > > > It's not just adding spaces, it's incrementing the column. Some > > > commands will get stuck trying to advance to a certain column. > > > This was a bug

Re: Patch 7.4.1996

Nikolay Pavlov wrote: > I am also wondering why evalcmd()? When discussing the name in Neovim > bug tracker I was against `evalcmd()` because for `eval('expr')` > expression result is expected to be the only effect (though it is not > necessary, most expressions used with `eval()` do not have >

Re: Patch 7.4.1996

Christian Brabandt wrote: > On Fr, 08 Jul 2016, Bram Moolenaar wrote: > > > It's not just adding spaces, it's incrementing the column. Some > > commands will get stuck trying to advance to a certain column. > > This was a bug for :redir that got fixed at some point. > > I don't find a

Re: Patch 7.4.1996

Hi Bram! On Do, 07 Jul 2016, Bram Moolenaar wrote: > > Patch 7.4.1996 > Problem:Capturing the output of a command takes a few commands. > Solution: Add evalcmd(). > Files: src/eval.c, runtime/doc/eval.txt, src/testdir/test_alot.vim, > src/Mak

Re: Patch 7.4.1996

On Fr, 08 Jul 2016, Bram Moolenaar wrote: > So, all these plugins would need to be changed to use evalcmd() for > things like that. I thought of making :redir nested, but it's not so > easy. It's not so easy even thinking of how it should work. That's why > I made using :redir inside evalcmd()

Re: Patch 7.4.1996

Hi skywind3000! On Fr, 08 Jul 2016, skywind3...@163.com wrote: > the report said version 7.4.1999 could not pass test 101 in mac > is this the same problem in win32 gvim ? Yes. > could win32 gvim version just ignore 7.4.1999 and just build 7.4.1998 ? Not easily. Simplest fix is to wait one

Re: Patch 7.4.1996

Hi Bram! On Fr, 08 Jul 2016, Bram Moolenaar wrote: > It's not just adding spaces, it's incrementing the column. Some > commands will get stuck trying to advance to a certain column. > This was a bug for :redir that got fixed at some point. I don't find a corresponding patch. Do you remember

Re: Patch 7.4.1996

I am also wondering why evalcmd()? When discussing the name in Neovim bug tracker I was against `evalcmd()` because for `eval('expr')` expression result is expected to be the only effect (though it is not necessary, most expressions used with `eval()` do not have side-effects). Commands on the

Re: Patch 7.4.1996

Christian Brabandt wrote: > On Do, 07 Jul 2016, Bram Moolenaar wrote: > > > Hmm, wasn't aware that people wanted nested redirection. > > It's not so difficult to make that work, use another redir flag instead > > of reusing redir_vname. > > It's not necessarily needed. The problem is, since

Re: Patch 7.4.1996

Ken Takata wrote: > 2016/7/8 Fri 5:32:58 UTC+9 Bram Moolenaar wrote: > > Christian Brabandt wrote: > > > > > > > On Do, 07 Jul 2016, Bram Moolenaar wrote: > > > > > > > > > > > > > > > > > Patch 7.4.19

Re: Patch 7.4.1996

James McCoy wrote: > On Thu, Jul 07, 2016 at 10:32:52PM +0200, Bram Moolenaar wrote: > > The neovim implementation is similar, but not better. > > It skips adding spaces where needed. > > What do you mean by "adding spaces where needed"? Why would a function > that's just supposed to capture

Re: Re: Patch 7.4.1996

the report said version 7.4.1999 could not pass test 101 in mac is this the same problem in win32 gvim ? could win32 gvim version just ignore 7.4.1999 and just build 7.4.1998 ? skywind3...@163.com From: Ken Takata Date: 2016-07-08 12:29 To: vim_dev CC: skywind3000 Subject: Re: Re: Patch

Re: Patch 7.4.1996

Hi Bram! On Do, 07 Jul 2016, Bram Moolenaar wrote: > Hmm, wasn't aware that people wanted nested redirection. > It's not so difficult to make that work, use another redir flag instead > of reusing redir_vname. It's not necessarily needed. The problem is, since some functionality is Vim can

Re: Re: Patch 7.4.1996

Hi, 2016/7/8 Fri 12:38:35 UTC+9 skywi...@163.com wrote: > Christian, > > Would you please have a look at the gvim daily build ? > Binaries are missing and it has only imported a tag of 7.4.1999. It is because the build failed. You can see a badge on the top page of vim-win32-installer.

Re: Re: Patch 7.4.1996

Christian, Would you please have a look at the gvim daily build ? Binaries are missing and it has only imported a tag of 7.4.1999. skywind3...@163.com From: Christian Brabandt Date: 2016-07-08 03:36 To: vim_dev Subject: Re: Patch 7.4.1996 Hi Bram! On Do, 07 Jul 2016, Bram Moolenaar wrote

Re: Patch 7.4.1996

On Thu, Jul 07, 2016 at 10:32:52PM +0200, Bram Moolenaar wrote: > The neovim implementation is similar, but not better. > It skips adding spaces where needed. What do you mean by "adding spaces where needed"? Why would a function that's just supposed to capture the display of a command add

Re: Patch 7.4.1996

Hi, 2016/7/8 Fri 5:32:58 UTC+9 Bram Moolenaar wrote: > Christian Brabandt wrote: > > > > > On Do, 07 Jul 2016, Bram Moolenaar wrote: > > > > > > > > > > > > > > Patch 7.4.1996 > > > > > Problem:Capturing the

Re: Patch 7.4.1996

Christian Brabandt wrote: > > > On Do, 07 Jul 2016, Bram Moolenaar wrote: > > > > > > > > > > > Patch 7.4.1996 > > > > Problem:Capturing the output of a command takes a few commands. > > > > Solution: Add evalcmd().

Re: Patch 7.4.1996

Hi Bram! On Do, 07 Jul 2016, Bram Moolenaar wrote: > Christian Brabandt wrote: > > > On Do, 07 Jul 2016, Bram Moolenaar wrote: > > > > > > > > Patch 7.4.1996 > > > Problem:Capturing the output of a command takes a few commands. > > > S

Re: Patch 7.4.1996

Christian Brabandt wrote: > On Do, 07 Jul 2016, Bram Moolenaar wrote: > > > > > Patch 7.4.1996 > > Problem:Capturing the output of a command takes a few commands. > > Solution: Add evalcmd(). > > Files: src/eval.c, runtime/doc/eval.txt, src/testdi

Re: Patch 7.4.1996

Hi Bram! On Do, 07 Jul 2016, Bram Moolenaar wrote: > > Patch 7.4.1996 > Problem:Capturing the output of a command takes a few commands. > Solution: Add evalcmd(). > Files: src/eval.c, runtime/doc/eval.txt, src/testdir/test_alot.vim, > src/Mak

Patch 7.4.1996

Patch 7.4.1996 Problem:Capturing the output of a command takes a few commands. Solution: Add evalcmd(). Files: src/eval.c, runtime/doc/eval.txt, src/testdir/test_alot.vim, src/Makefile, src/testdir/test_evalcmd.vim *** ../vim-7.4.1995/src/eval.c 2016-07-07 14:50