Re: [virt-tools-list] [PATCH] timed-revealer: listen to the "grab-notify" signal

On 06/29/2016 10:36 AM, Fabiano Fidêncio wrote: > The "grab-notify" signal lets us know when our widget becomes > shadowed by a Gtk+ grab on another widget, or when it becomes unshadowed > due to a grab being removed. > > That's exactly the case we face when dealing with "usb-redirection" and >

Re: [virt-tools-list] [PATCH v2 virt-viewer] Get rid of deprecated functions to customize widget colors

On Wed, 2016-06-29 at 10:24 -0300, Eduardo Lima (Etrunko) wrote: > On 06/29/2016 05:08 AM, Pavel Grunt wrote: > > > > Hi, > > > > Imo the commit message should say that there are issues with the font / > > background colour since commit ... in some gtk versions - like you said in > > the > >

[virt-tools-list] [PATCH] timed-revealer: listen to the "grab-notify" signal

The "grab-notify" signal lets us know when our widget becomes shadowed by a Gtk+ grab on another widget, or when it becomes unshadowed due to a grab being removed. That's exactly the case we face when dealing with "usb-redirection" and "close" items of the fullscreen toolbar. And, currently, when

Re: [virt-tools-list] [PATCH v2 virt-viewer] Get rid of deprecated functions to customize widget colors

On 06/29/2016 05:08 AM, Pavel Grunt wrote: > Hi, > > Imo the commit message should say that there are issues with the font / > background colour since commit ... in some gtk versions - like you said in the > comment for v1, because that is the reason for this patch. Getting rid of > deprecated

Re: [virt-tools-list] [PATCH virt-viewer] window: Factor out common code for toolbar items

On Tue, 2016-06-28 at 16:30 -0300, Eduardo Lima (Etrunko) wrote: > On 06/28/2016 12:16 PM, Fabiano Fidêncio wrote: > > > > On Tue, Jun 28, 2016 at 5:10 PM, Pavel Grunt wrote: > > > > > > Create toolbar widget in the loop > > > > NACK from my side. > > There is any gain on

Re: [virt-tools-list] [PATCH v2 virt-viewer] Get rid of deprecated functions to customize widget colors

Hi, Imo the commit message should say that there are issues with the font / background colour since commit ... in some gtk versions - like you said in the comment for v1, because that is the reason for this patch. Getting rid of deprecated functions is a "side effect". On Tue, 2016-06-28 at