Re: [virt-tools-list] [virt-viewer PATCH] Show errors generated by connection dialog

> On 8 Feb 2017, at 20:34, Eduardo Lima (Etrunko) wrote: > > Patch looks good, I personally also like to check for error->message > before dereferencing it, but I don't really know what others think about it. I had wondered about that, but I checked, and apparently, all

Re: [virt-tools-list] [virt-viewer PATCH] Show errors generated by connection dialog

On 08/02/17 14:48, Christophe de Dinechin wrote: > When running 'remote-viewer' without arguments, > and selecting a non-supported protocol, e.g. ssh://foo, > the generated error was silently swallowed by the retry loop. > This was introduced in 06b2c382468876a19600374bd59475e66d488af8. > --- >

[virt-tools-list] [virt-viewer PATCH] Show errors generated by connection dialog

When running 'remote-viewer' without arguments, and selecting a non-supported protocol, e.g. ssh://foo, the generated error was silently swallowed by the retry loop. This was introduced in 06b2c382468876a19600374bd59475e66d488af8. --- src/remote-viewer.c | 3 +++ 1 file changed, 3 insertions(+)

[virt-tools-list] [virt-manager PATCH 3/4] inspection: consider also epoch for pkg version

When composing the string of the version of packages, prepend also the epoch, as it is an important part of the package version. --- virtManager/details.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/virtManager/details.py b/virtManager/details.py index 20a61f7..0503a44