> On 8 Feb 2017, at 20:34, Eduardo Lima (Etrunko) <etru...@redhat.com> wrote: > > Patch looks good, I personally also like to check for error->message > before dereferencing it, but I don't really know what others think about it.
I had wondered about that, but I checked, and apparently, all other places that look at error->message only check error != NULL, except for a single exceptions in spice-widget… But you made me doubt, so I checked. The examples in https://developer.gnome.org/glib/stable/glib-Error-Reporting.html don’t check, and it seems like the only valid way to get a GError is with some “new” that has message as input arguments. Christophe _______________________________________________ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
