Re: [virt-tools-list] [virt-manager PATCH] Tiny inspection improvements

On 02/08/2017 10:55 AM, Pino Toscano wrote: > Hi, > > this patch series improves the integration with libguestfs for > inspection of guests: > - show the actual OS of each guest, in addition to the product name > - fix the version of installed packages, by taking epochs into account > - use also

Re: [virt-tools-list] [virt-manager PATCH] virtManager/viewers: fix connection to remote SPICE with password

On 02/07/2017 12:00 PM, Pavel Hrdina wrote: > When connecting to remote SPICE we use ssh tunnel if the SPICE is > listening only on "localhost". Our ssh tunnel scheduler uses locks > to serialize the requests for FD in order to not spam user for ssh > password. > > However when the main_channel

Re: [virt-tools-list] [PATCH virt-viewer v2] session-spice: Pass hostname to authentication dialog

On 09/02/17 17:22, Pavel Grunt wrote: > On Thu, 2017-02-09 at 15:32 -0200, Eduardo Lima (Etrunko) wrote: >> With this patch the dialog now shows the host we are connecting to. >> >> Signed-off-by: Eduardo Lima (Etrunko) > Acked-by: Pavel Grunt Thanks,

Re: [virt-tools-list] [PATCH virt-viewer v2] iso-dialog: Avoid crash when closing dialog early

On 09/02/17 17:19, Pavel Grunt wrote: > Hi Eduardo, > > On Thu, 2017-02-09 at 15:13 -0200, Eduardo Lima (Etrunko) wrote: >> We must take into account that users can close the dialog at >> anytime, >> even during an operation of fetch or set ISO has not been finished. >> This >> will cause the

[virt-tools-list] [PATCH virt-viewer 08/10] virt-viewer-auth: Use GtkHeaderBar

The auxiliary text is now presented as the subtitle of the dialog Signed-off-by: Eduardo Lima (Etrunko) --- src/resources/ui/virt-viewer-auth.ui | 148 --- src/virt-viewer-auth.c | 35 + 2 files changed, 86

[virt-tools-list] [PATCH virt-viewer 09/10] file-transfer-dialog: Use GtkHeaderBar

This dialog now presents the progress as a level bar, and also shows the percentage as on the text. The cancel button is not necessary anymore, because the all transfers are cancelled automatically when the dialog is closed before they finish. Signed-off-by: Eduardo Lima (Etrunko)

[virt-tools-list] [PATCH virt-viewer 10/10] usb_device_selection: Use GtkHeaderBar

We could get rid of the auxiliary text and present it as the subtitle of the dialog, but this is handled by the widget itself. In this case, all we have to do is to set the "use-headerbar" property, and like other dialogs, the close button is not necessary anymore. Signed-off-by: Eduardo Lima

[virt-tools-list] [PATCH virt-viewer 01/10] Update Gtk+ requirements to 3.12

This is new version ships with GtkHeaderBar code, which we will require for the dialogs on the application. In the future the main window could also make use of this widget, following the style of other applications. Signed-off-by: Eduardo Lima (Etrunko) --- configure.ac | 4

[virt-tools-list] [PATCH virt-viewer 02/10] iso-dialog: Use GtkHeaderBar

We now display the current ISO as subtitle on the HeaderBar. On the glade UI file, we get rid of the GtkAlignment object that was used to put some space between the tree view and dialog buttons. The "Select ISO" label is gone too. Signed-off-by: Eduardo Lima (Etrunko) ---

[virt-tools-list] [PATCH virt-viewer 06/10] virt-viewer-preferences: Use GtkHeaderBar

This dialog changed very little when compared to the old version. I did change the way widgets are organized within the dialog, as it now groups the file selector together with the read-only checkbox. Signed-off-by: Eduardo Lima (Etrunko) ---

[virt-tools-list] [PATCH virt-viewer 05/10] remote-viewer-connect: Use GtkHeaderBar

Just like the virt-viewer-connect dialog, the connect button has been moved to the header bar. Additionally, the example text is now presented as the subtitle. Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer-connect.c | 20 +---

[virt-tools-list] [PATCH virt-viewer 04/10] virt-viewer-vm-connection: Use GtkHeaderBar

Here we moved the connect button to the header bar. Unfortunately, I could not find a "connect-symbolic" icon to be used here, so I ended up with the stock icon. Signed-off-by: Eduardo Lima (Etrunko) --- src/resources/ui/virt-viewer-vm-connection.ui | 83

[virt-tools-list] [PATCH virt-viewer 03/10] guest-details-dialog: Use GtkHeaderBar

This is the simplest dialog on the application, there was not much to change here. In order to not leave a big amount of unused space on the HeaderBar, we set the guest name as the subtitle. Signed-off-by: Eduardo Lima (Etrunko) ---

[virt-tools-list] [PATCH virt-viewer 07/10] about-dialog: Use GtkHeaderBar

For this one, we use the application version as the subtitle. Signed-off-by: Eduardo Lima (Etrunko) --- src/resources/ui/virt-viewer-about.ui | 20 ++-- src/virt-viewer-window.c | 9 ++--- 2 files changed, 20 insertions(+), 9 deletions(-)

Re: [virt-tools-list] [PATCH virt-viewer v2] iso-dialog: Avoid crash when closing dialog early

Hi Eduardo, On Thu, 2017-02-09 at 15:13 -0200, Eduardo Lima (Etrunko) wrote: > We must take into account that users can close the dialog at > anytime, > even during an operation of fetch or set ISO has not been finished. > This > will cause the callbacks for those operations to be invoked with an

Re: [virt-tools-list] [virt-viewer updated PATCH] Show errors generated by connection dialog

On Thu, 2017-02-09 at 13:00 +0100, Christophe de Dinechin wrote: > When running 'remote-viewer' without arguments, > and selecting a non-supported protocol, e.g. ssh://foo, > the generated error was silently swallowed by the retry loop. > This was introduced in

Re: [virt-tools-list] [virt-viewer PATCH] Test error->message and, if NULL, use a default message

I tend to agree. I don’t see how any legitimate GError * (from g_error_new or the like) would have a NULL message. So this is really defensive coding. Alternate solution would be to assert, but I don’t like killing the viewer if this ever happens. Christophe > On 9 Feb 2017, at 17:44,

[virt-tools-list] [PATCH virt-viewer v2] session-spice: Pass hostname to authentication dialog

With this patch the dialog now shows the host we are connecting to. Signed-off-by: Eduardo Lima (Etrunko) --- v2: Use proper uri if connecting via proxy. --- src/virt-viewer-session-spice.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [virt-tools-list] [PATCH virt-viewer v2] iso-dialog: Avoid crash when closing dialog early

On 09/02/17 15:13, Eduardo Lima (Etrunko) wrote: > We must take into account that users can close the dialog at anytime, > even during an operation of fetch or set ISO has not been finished. This > will cause the callbacks for those operations to be invoked with an > invalid object, crashing the

[virt-tools-list] [PATCH virt-viewer v2] iso-dialog: Avoid crash when closing dialog early

We must take into account that users can close the dialog at anytime, even during an operation of fetch or set ISO has not been finished. This will cause the callbacks for those operations to be invoked with an invalid object, crashing the application. To fix this issue we need to pass a

Re: [virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

Looks like this v2 never made to the list? I am sending it again. On 03/02/17 15:28, Eduardo Lima (Etrunko) wrote: > We must take into account that users can close the dialog at anytime, > even during an operation of fetch or set ISO has not been finished. This > will cause the callbacks for

Re: [virt-tools-list] [virt-viewer PATCH] Test error->message and, if NULL, use a default message

...now I see that this was discussed in the review thread for your other patch. I still think this should not be necessary. If error is non-NULL, it should be guaranteed to have a non-NULL message. Jonathon On Thu, 2017-02-09 at 10:40 -0600, Jonathon Jongsma wrote: > Out of curiosity, what was

Re: [virt-tools-list] [virt-viewer PATCH] Test error->message and, if NULL, use a default message

Out of curiosity, what was the situation where you encountered a non- NULL error with a NULL error->message? It doesn't seem like this should be necessary. Jonathon On Thu, 2017-02-09 at 13:02 +0100, Christophe de Dinechin wrote: > --- >  src/ovirt-foreign-menu.c   | 14

Re: [virt-tools-list] [virt-viewer PATCH] Show errors generated by connection dialog

On Thu, 2017-02-09 at 14:22 +0100, Christophe de Dinechin wrote: > > > > > > If the message is NULL, we should still display something like > > > “unknown error”. If we think it’s worth testing for error- > > > >message > > > != NULL, then I suggest another patch just for that, that fixes > > >

Re: [virt-tools-list] [virt-viewer PATCH] Show errors generated by connection dialog

>> >> If the message is NULL, we should still display something like >> “unknown error”. If we think it’s worth testing for error->message >> != NULL, then I suggest another patch just for that, that fixes all >> places and not just this one. > I agree Separate patch sent. >> BTW, I did not

Re: [virt-tools-list] [virt-viewer PATCH] Show errors generated by connection dialog

On Thu, 2017-02-09 at 12:10 +0100, Christophe de Dinechin wrote: > Thanks for the comments. > > > On 9 Feb 2017, at 11:23, Pavel Grunt wrote: > > > > Hello Christophe, > > > > On Wed, 2017-02-08 at 17:48 +0100, Christophe de Dinechin wrote: > > > When running 'remote-viewer'

[virt-tools-list] [virt-viewer PATCH] Test error->message and, if NULL, use a default message

--- src/ovirt-foreign-menu.c | 14 +++--- src/remote-viewer.c| 22 -- src/virt-viewer-app.c | 14 +++--- src/virt-viewer-file-transfer-dialog.c | 2 +- src/virt-viewer-file.c | 6 +++---

[virt-tools-list] [virt-viewer updated PATCH] Show errors generated by connection dialog

When running 'remote-viewer' without arguments, and selecting a non-supported protocol, e.g. ssh://foo, the generated error was silently swallowed by the retry loop. This was introduced in 06b2c382468876a19600374bd59475e66d488af8. --- src/remote-viewer.c | 3 +++ 1 file changed, 3 insertions(+)

Re: [virt-tools-list] [virt-viewer PATCH] Show errors generated by connection dialog

Thanks for the comments. > On 9 Feb 2017, at 11:23, Pavel Grunt wrote: > > Hello Christophe, > > On Wed, 2017-02-08 at 17:48 +0100, Christophe de Dinechin wrote: >> When running 'remote-viewer' without arguments, >> and selecting a non-supported protocol, e.g. ssh://foo, >>

Re: [virt-tools-list] [virt-viewer PATCH] Show errors generated by connection dialog

Hello Christophe, On Wed, 2017-02-08 at 17:48 +0100, Christophe de Dinechin wrote: > When running 'remote-viewer' without arguments, > and selecting a non-supported protocol, e.g. ssh://foo, > the generated error was silently swallowed by the retry loop. > This was introduced in