2017-09-21 14:02 GMT+02:00 Christophe Fergeau :
> On Thu, Sep 21, 2017 at 10:12:01AM +0100, Daniel P. Berrange wrote:
> > On Thu, Sep 21, 2017 at 10:16:56AM +0200, Christophe Fergeau wrote:
> > > The man page spice-gtk ships is named "spice-client", not "spice-gtk"
> > >
> > > Signed-off-by: Chris
Hi,
2017-08-04 23:53 GMT+02:00 Eduardo Lima (Etrunko) :
> This can save us some bandwidth, as we are searching for the specific
> virtual machine instead of retrieving the collection with all VMs, and
> then iterating over the results after the transfer finishes.
>
> Signed-off-by: Eduardo Lima (
Hello Eric,
On Mon, 2017-07-24 at 17:00 -0600, Eric Abreu wrote:
> Hello folks, I would like to change the RAM for the QXL Video device from
> default 16 MB to 64 MB or more whether is this possible. I do not have the
> option to change it, I tried to delete the device and add a new one and
> neith
On Mon, 2017-07-24 at 05:47 -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > wixl-heat does it itself since its commit 9273514c95e343340d18067b4f1
> >
> > otherwise msi generation fails with:
> > Couldn't find file
> > $/tmp/tmp.1MYrxTLd1U/usr/x86_64-w64-mingw32/sys-root/
On Mon, 2017-07-24 at 10:17 +0200, Christophe Fergeau wrote:
> On Mon, Jul 24, 2017 at 10:10:02AM +0200, Pavel Grunt wrote:
> > Hi,
> >
> > On Mon, 2017-07-24 at 08:54 +0100, Christophe Fergeau wrote:
> > > Hey,
> > >
> > > On Fri, Jul
Hi,
On Mon, 2017-07-24 at 08:54 +0100, Christophe Fergeau wrote:
> Hey,
>
> On Fri, Jul 21, 2017 at 07:27:45PM +0200, Pavel Grunt wrote:
> > wixl-heat does it itself since its commit 9273514c95e343340d18067b4f1
> >
> > otherwise msi generation fails with:
>
wixl-heat does it itself since its commit 9273514c95e343340d18067b4f1
otherwise msi generation fails with:
Couldn't find file
$/tmp/tmp.1MYrxTLd1U/usr/x86_64-w64-mingw32/sys-root/mingw/bin/debug-helper.exe
---
data/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
splay a dialog asking
> whether the user wants to overwrite it. But if we then append a ".png"
> extension to the filename and save it, we may be overwriting an existing
> file without warning. By returning an error for unrecognized file types,
> we avoid this problem.
>
on
On Wed, 2017-07-19 at 16:49 -0500, Jonathon Jongsma wrote:
> Currently, the user gets no feedback if the screenshot fails (e.g. if
> they don't have permission to write in the chosen directory, etc). This
> patch adds a simple dialog showing the error message when a screenshot
> fails.
Ack,
Pavel
On Wed, 2017-07-19 at 16:49 -0500, Jonathon Jongsma wrote:
> Since the code attempts to append ".png" to filenames without an
> extension, it doesn't make much sense to have the default filename be
> extensionless. Including the extension on the default filename makes
> things more straightforward
Use .png as the default
Related: rhbz#1455832
---
src/virt-viewer-window.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
index 3ba4e2c..9531f15 100644
--- a/src/virt-viewer-window.c
+++ b/src/virt-viewer-window.c
@@
uth error dialog if user has
> cancelled or closed
> + * the dialog */
> +self->priv->pass_try = 0;
I'd first change the value and after that emit the signal.
Acked-by: Pavel Grunt
Thanks,
Pavel Grunt
> } else {
> gboolean
On Fri, 2017-06-02 at 12:40 +0200, Victor Toso wrote:
> From: Victor Toso
>
> Who is trying to collect the credentials might need to know if a
> given
> failure is due bad user input of credentionals or if the user has
> cancel/closed the dialog (which is also consider failure prior this
> patch)
On Tue, 2017-05-30 at 10:49 -0400, R Kendal wrote:
> furthermore, when i downloaded virt-viewer-x64-5.0.msi from https://
> virt-manager.org/download/
>
> Chrome tells me the download came from:
> https://releases.pagure.org...
virt-viewer is hosted at pagure.org so its releases are hosted at
pag
On Mon, 2017-05-22 at 15:50 +0200, Victor Toso wrote:
> On Mon, May 22, 2017 at 10:39:15AM -0300, Eduardo Lima (Etrunko)
> wrote:
> > On 21/05/17 04:23, Xiaodai Wang wrote:
> > >
> > > - Original Message -
> > > > From: "Victor Toso"
> > > > To: "Eduardo Lima (Etrunko)"
> > > > Cc: virt-
looks good, ack
Pavel
On Thu, 2017-05-11 at 16:16 +0200, Victor Toso wrote:
> From: Victor Toso
>
> When the transfer of a file finishes we stop considering that file's
> size in the progress bar which makes it move back due the new
> 'transfer size' and 'transferred bytes' - for all the other
Take a look at the shutdown event detail before killing
the connection. Otherwise it breaks the SPICE seamless migration
feature.
Regression since commit a62827d28c6b69e90102e4c1c8043cbddad8929a
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1442929
Signed-off-by: Pavel Grunt
---
src
Take a look at the shutdown event detail before killing
the connection.
Regression since commit a62827d28c6b69e90102e4c1c8043cbddad8929a
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1442929
Signed-off-by: Pavel Grunt
---
src/virt-viewer.c | 6 +-
1 file changed, 5 insertions(+), 1
On Thu, 2017-05-11 at 15:03 +0200, Lentes, Bernd wrote:
> Hi,
>
> sorry for asking a simple question, but i'm confused. What is virt-
> viewer intended to be ?
> To connect directly to virtual machine consoles, e.g. with VNC ?
and SPICE
> Or connect to libvirtd which runs e.g. on a remote linux h
Support for more than one key combo for accelerator is available
since GTK 3.12 through GAction. It is currently not possible to
use mnemonics also for numpad keys, for more info see:
https://bugzilla.gnome.org/show_bug.cgi?id=699823
Resolves: rhbz#1337575
---
v3:
use a designated initializer to
Support for more than one key combo for accelerator is available
since GTK 3.12 through GAction. It is currently not possible to
use mnemonics also for numpad keys, for more info see:
https://bugzilla.gnome.org/show_bug.cgi?id=699823
Resolves: rhbz#1337575
---
configure.ac | 4 ++--
On Wed, 2017-05-03 at 10:31 -0400, Cole Robinson wrote:
> On 05/03/2017 05:09 AM, Pavel Grunt wrote:
> > It relies on the presence of X cursor fonts in the system. Use
> > recommended gdk_cursor_new_from_name and use cursor names that
> > works
> > on different backends
It relies on the presence of X cursor fonts in the system. Use
recommended gdk_cursor_new_from_name and use cursor names that works
on different backends.
Deprecated since Gdk 3.16
https://bugzilla.redhat.com/show_bug.cgi?id=1442612
---
virtManager/asyncjob.py | 5 +++--
virtManager/baseclass.
Build with libvirt only when libvirt-glib is present
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index d5eb258..0081375 100644
--- a/configure.ac
+++ b/configure.ac
@@ -118,7 +118,7 @@ AC_ARG_WITH([libvirt],
AS_HELP_STRING([
---
src/virt-viewer-util.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/virt-viewer-util.c b/src/virt-viewer-util.c
index 6b63133..226c9fa 100644
--- a/src/virt-viewer-util.c
+++ b/src/virt-viewer-util.c
@@ -309,7 +309,7 @@ void virt_viewer_util_init(const char
Hi,
On Fri, 2017-04-07 at 14:57 +, Marc-André Lureau wrote:
>
>
> On Thu, Apr 6, 2017 at 4:07 PM Pavel Grunt
> wrote:
> > Support for more than one key combo for accelerator is available
> > since GTK 3.12 through GAction.
> >
> > Resolves: rhbz#1337
Since libvirt 0.9.4 there is a new listen element which can be used
to specify address instead of using the attributes of graphics element.
Also add support for listen type socket - available for Qemu since
libvirt 2.0.0
Resolves: rhbz#1411765
---
src/virt-viewer.c | 14 --
1 file ch
Only method for connecting to channel opened later was ssh, however
this method failes when unix socket is used:
Related: rhbz#1335832, rhbz#1411765
---
src/virt-viewer-app.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/src/v
:
Change the graphics type to vnc and virt-viewer connects without issues.
Pavel Grunt (2):
virt-viewer: Support newer libvirt xml format
app: Allow to connect to channel using unix socket
src/virt-viewer-app.c | 29 +++--
src/virt-viewer.c | 14 --
2
Support for more than one key combo for accelerator is available
since GTK 3.12 through GAction.
Resolves: rhbz#1337575
---
Hello,
this patch fixes an old bug we attempted to fix several times in the past
when it was not possible to use more than a single key combo to do action.
GTK 3.12 fixed th
Ack
Thanks,
Pavel
On Wed, 2017-04-05 at 10:23 -0500, Jonathon Jongsma wrote:
> Add some tests that specify different numbers of client monitors to
> ensure that the parsing handles those situations correctly.
> ---
> tests/test-monitor-mapping.c | 65 -
> -
On Tue, 2017-04-04 at 10:40 -0500, Jonathon Jongsma wrote:
> On Mon, 2017-04-03 at 08:58 +0200, Pavel Grunt wrote:
> > Hi Jonathon,
> >
> > On Wed, 2017-03-29 at 15:24 -0500, Jonathon Jongsma wrote:
> > > When started in fullscreen mode with a monitor-mapping
> &
On Wed, 2017-03-29 at 14:39 -0300, Eduardo Lima (Etrunko) wrote:
> On 29/03/17 07:36, Pavel Grunt wrote:
> > It will enable some functionality, like zoom.
> >
>
> You could maybe elaborate a bit better, as you are also setting
> enabled
> to FALSE it when the ses
Hi Jonathon,
On Wed, 2017-03-29 at 15:24 -0500, Jonathon Jongsma wrote:
> When started in fullscreen mode with a monitor-mapping configuration
> option, we are getting the following warnings on the terminal:
I haven't seen it. wayland ?
>
> (process:27428): Gdk-CRITICAL **: gdk_screen_get_n
---
src/virt-viewer-app.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/virt-viewer-app.h b/src/virt-viewer-app.h
index 8381631..16b1c8c 100644
--- a/src/virt-viewer-app.h
+++ b/src/virt-viewer-app.h
@@ -68,7 +68,6 @@ void virt_viewer_app_free_connect_info(VirtViewerApp *self);
gboolean
It will enable some functionality, like zoom.
Regression since 9c77a78af2ef85f3fcdce21b42d89566a9f7ee17
Resolves: rhbz#1436991
---
src/virt-viewer-display-vnc.c | 1 +
src/virt-viewer-session-vnc.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/virt-viewer-display-vnc.c b/src/virt-vie
Available in GLib since the version 2.30
---
src/remote-viewer.c | 4
1 file changed, 4 deletions(-)
diff --git a/src/remote-viewer.c b/src/remote-viewer.c
index 451fb1d..2db76bc 100644
--- a/src/remote-viewer.c
+++ b/src/remote-viewer.c
@@ -48,10 +48,6 @@
#include "remote-viewer.h"
#inclu
On Fri, 2017-03-24 at 14:51 +0100, Christophe Fergeau wrote:
> The spice-controller integration code is only needed when a browser
> plugin is in use. This has been deprecated in favour of .vv files
> for
> several years now. This commit makes this code optional, if
> spice-controller.pc cannot be
Related: rhbz#1399077
---
src/virt-viewer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/virt-viewer.c b/src/virt-viewer.c
index 65c0546..b50db16 100644
--- a/src/virt-viewer.c
+++ b/src/virt-viewer.c
@@ -110,7 +110,7 @@ opt_domain_selection_cb(const gchar *option_name,
Ack
On Fri, 2017-03-03 at 16:01 +0100, Victor Toso wrote:
> From: Victor Toso
>
> > remote-viewer.c: In function 'remote_viewer_get_property':
> > remote-viewer.c:227:26: warning: unused variable 'priv' [-Wunused-
> > variable]
> > RemoteViewerPrivate *priv = self->priv;
> >
Ack,
Pavel
On Fri, 2017-03-03 at 15:37 +0100, Victor Toso wrote:
> From: Victor Toso
>
> As remote_viewer_iso_list_dialog_new() is defined on
> remote-viewer-iso-list-dialog.h which is only build with oVirt
> integration.
>
> > undefined reference to `remote_viewer_iso_list_dialog_new'
>
> No
Ack
On Fri, 2017-03-03 at 15:37 +0100, Victor Toso wrote:
> From: Victor Toso
>
> Function is not used without oVirt.
>
> > virt-viewer-window.c:1063:1: warning: 'iso_dialog_response'
> > defined
> > but not used [-Wunused-function]
>
> Signed-off-by: Victor Toso
> ---
> src/virt-viewer-wind
virt-viewer by default chooses the VM by its id, then uuid
and then by name. Adjust the comment to match the implementation.
Related: rhbz#1399077
---
man/virt-viewer.pod | 2 +-
src/virt-viewer.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/man/virt-viewer.pod b/m
Theoretically a VM name can be a valid VM id or uuid. In that case
connecting to the VMs may be problematic since virt-viewer selects
the VM by its id then by uuid if not found then by its name.
Introduce new command line options to cover this situation:
"--id" to connect to the VM by its id
"--
Display correct text and make it translatable
Resolves:
https://bugs.freedesktop.org/show_bug.cgi?id=99980
---
src/resources/ui/virt-viewer-file-transfer-dialog.ui | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/resources/ui/virt-viewer-file-transfer-dialog.ui
b/src/resou
On Thu, 2017-03-02 at 08:40 -0600, Jonathon Jongsma wrote:
> On Thu, 2017-03-02 at 10:36 +0100, Christophe de Dinechin wrote:
> > > On 1 Mar 2017, at 22:36, Jonathon Jongsma
> > > wrote:
> > >
> > > On Fri, 2017-02-24 at 15:57 +0100, Pavel Grunt wrote:
&
On Thu, 2017-03-02 at 09:44 +, Daniel P. Berrange wrote:
> On Fri, Feb 24, 2017 at 03:57:23PM +0100, Pavel Grunt wrote:
> > Theoretically a VM name can be a valid VM id or uuid. In that case
> > connecting to the VMs may be problematic since virt-viewer selects
> > the
On Thu, 2017-03-02 at 10:31 +0100, Christophe de Dinechin wrote:
> > On 2 Mar 2017, at 09:56, Pavel Grunt wrote:
> >
> > Theoretically a VM name can be a valid VM id or uuid. In that case
> > connecting to the VMs may be problematic since virt-viewer selects
> > th
Theoretically a VM name can be a valid VM id or uuid. In that case
connecting to the VMs may be problematic since virt-viewer selects
the VM by its id then by uuid if not found then by its name.
Introduce new command line options to cover this situation:
"--domain-name" to connect to the VM by it
On Wed, 2017-03-01 at 15:36 -0600, Jonathon Jongsma wrote:
> On Fri, 2017-02-24 at 15:57 +0100, Pavel Grunt wrote:
> > Theoretically a VM name can be a valid VM id or uuid. In that case
> > connecting to the VMs may be problematic since virt-viewer selects
> > the VM by its i
Theoretically a VM name can be a valid VM id or uuid. In that case
connecting to the VMs may be problematic since virt-viewer selects
the VM by its id then by uuid if not found then by its name.
Introduce new command line options to cover this situation:
"--domain-name" to connect to the VM by it
virt-viewer by default chooses the VM by its id, then uuid
and then by name. Adjust the comment to match the implementation.
Related: rhbz#1399077
---
man/virt-viewer.pod | 2 +-
src/virt-viewer.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/man/virt-viewer.pod b/m
Ack
On Fri, 2017-02-17 at 13:36 +0100, Christophe Fergeau wrote:
> Two statements in virt_viewer_session_spice_main_channel_event() are
> wrapped in a { } block, but this is unneeded.
>
> Signed-off-by: Christophe Fergeau
> ---
> src/virt-viewer-session-spice.c | 10 --
> 1 file changed
Ack
On Fri, 2017-02-17 at 11:28 +0100, Christophe Fergeau wrote:
> The 'system' path was missing: qemu+ssh://example.org/system
>
> Resolves: rhbz#1377283
> ---
> man/virt-viewer.pod | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man/virt-viewer.pod b/man/virt-viewer.p
Hi,
On Thu, 2017-02-09 at 17:22 -0200, Eduardo Lima (Etrunko) wrote:
> This whole series is the result of the initial idea of having the
> new
> iso-dialog to use this widget. Having it done only for the iso-
> dialog
> would not make much sense, so I went on and ported all other
> dialogs.
> The
On Thu, 2017-02-09 at 18:46 +0100, Christophe de Dinechin wrote:
> I tend to agree. I don’t see how any legitimate GError * (from
> g_error_new or the like) would have a NULL message. So this is
> really defensive coding.
>
nothing prevents calling g_error_new with a NULL message :) I know it
is n
On Thu, 2017-02-09 at 15:32 -0200, Eduardo Lima (Etrunko) wrote:
> With this patch the dialog now shows the host we are connecting to.
>
> Signed-off-by: Eduardo Lima (Etrunko)
Acked-by: Pavel Grunt
> ---
> v2: Use proper uri if connecting via proxy.
> ---
> src/virt-viewe
Hi Eduardo,
On Thu, 2017-02-09 at 15:13 -0200, Eduardo Lima (Etrunko) wrote:
> We must take into account that users can close the dialog at
> anytime,
> even during an operation of fetch or set ISO has not been finished.
> This
> will cause the callbacks for those operations to be invoked with an
On Thu, 2017-02-09 at 14:22 +0100, Christophe de Dinechin wrote:
> > >
> > > If the message is NULL, we should still display something like
> > > “unknown error”. If we think it’s worth testing for error-
> > > >message
> > > != NULL, then I suggest another patch just for that, that fixes
> > > al
On Thu, 2017-02-09 at 12:10 +0100, Christophe de Dinechin wrote:
> Thanks for the comments.
>
> > On 9 Feb 2017, at 11:23, Pavel Grunt wrote:
> >
> > Hello Christophe,
> >
> > On Wed, 2017-02-08 at 17:48 +0100, Christophe de Dinechin wrote:
> > > W
Hello Christophe,
On Wed, 2017-02-08 at 17:48 +0100, Christophe de Dinechin wrote:
> When running 'remote-viewer' without arguments,
> and selecting a non-supported protocol, e.g. ssh://foo,
> the generated error was silently swallowed by the retry loop.
> This was introduced in 06b2c382468876a196
On Tue, 2017-02-07 at 16:29 -0200, Eduardo Lima (Etrunko) wrote:
> On 06/02/17 09:20, Pavel Grunt wrote:
> > On Fri, 2017-02-03 at 16:11 -0200, Eduardo Lima (Etrunko) wrote:
> > > With this patch the dialog now shows the host we are trying to
> > > connect to.
> >
On Tue, 2017-02-07 at 17:23 +0100, Christophe Fergeau wrote:
> Acked-by: Christophe Fergeau
>
Thanks, pushed
https://pagure.io/virt-viewer/c/b7f8644429e034523ec91ab18c53b82f7cceb5
53
Pavel
> On Tue, Jan 17, 2017 at 06:42:51PM +0100, Pavel Grunt wrote:
> > Do not show a len
It is needed to use the 'foreign' init option otherwise autotools
requires README
---
v2: add README.md to EXTRA_DIST
with this I was able to build the rpm
---
Makefile.am | 1 +
configure.ac| 2 +-
virt-viewer.spec.in | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff
On Mon, 2017-02-06 at 18:04 +0100, Christophe Fergeau wrote:
> On Mon, Feb 06, 2017 at 05:55:58PM +0100, Pavel Grunt wrote:
> > On Fri, 2017-02-03 at 14:42 -0200, Eduardo Lima (Etrunko) wrote:
> > > On 03/02/17 14:34, Christophe Fergeau wrote:
> > > > Hey,
> >
On Fri, 2017-02-03 at 14:42 -0200, Eduardo Lima (Etrunko) wrote:
> On 03/02/17 14:34, Christophe Fergeau wrote:
> > Hey,
> >
> > On Thu, Jan 26, 2017 at 06:01:23PM -0200, Eduardo Lima (Etrunko)
> > wrote:
> > > We must take into account that users can close the dialog at
> > > anytime,
> > > even
Fixes -Werror=format-security used when creating the rpm
---
see:
https://copr-be.cloud.fedoraproject.org/results/pgrunt/spice-upstream/fedora-25-x86_64/00507878-virt-viewer/build.log.gz
---
src/remote-viewer-iso-list-dialog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sr
On Mon, 2017-02-06 at 12:18 +0100, Christophe Fergeau wrote:
> On Mon, Feb 06, 2017 at 12:06:25PM +0100, Pavel Grunt wrote:
> > It is needed to use the 'foreign' init option otherwise autotools
> > requires README
> > ---
> > I am sorry for breaking the bui
On Fri, 2017-02-03 at 16:11 -0200, Eduardo Lima (Etrunko) wrote:
> With this patch the dialog now shows the host we are trying to
> connect to.
I would mention that we use the "host" property of SpiceSession
>
> Signed-off-by: Eduardo Lima (Etrunko)
---
> src/virt-viewer-session-spice.c | 9
It is needed to use the 'foreign' init option otherwise autotools
requires README
---
I am sorry for breaking the build again.
An alternative for this patch would be to generate README from README.md
or reverting the previous commit
---
configure.ac| 2 +-
virt-viewer.spec.in | 2 +-
2 fil
Acked-by: Fabiano Fidêncio
---
README | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/README b/README
index e9fe5b9..ea1c633 100644
--- a/README
+++ b/README
@@ -14,12 +14,12 @@ the last release that supported GTK2.
Virt Viewer uses the GTK-VNC (>= 0.4.0) widget to pr
To render nicely on the project git page:
https://pagure.io/virt-viewer
---
README => README.md | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
rename README => README.md (92%)
diff --git a/README b/README.md
similarity index 92%
rename from README
rename to README.md
index ea1c633
On Thu, 2017-01-19 at 16:12 +0100, Fabiano Fidêncio wrote:
> On Thu, Jan 19, 2017 at 1:17 PM, Pavel Grunt
> wrote:
> > To render nicely on the project git page:
> > https://pagure.io/virt-viewer
> > ---
> > README => README.md | 5 +
> > 1 fi
---
README | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/README b/README
index e9fe5b9..ea1c633 100644
--- a/README
+++ b/README
@@ -14,12 +14,12 @@ the last release that supported GTK2.
Virt Viewer uses the GTK-VNC (>= 0.4.0) widget to provide a
display of the VNC
To render nicely on the project git page:
https://pagure.io/virt-viewer
---
README => README.md | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
rename README => README.md (97%)
diff --git a/README b/README.md
similarity index 97%
rename from README
rename to README.md
index ea1c633..f
Do not show a length since it is sensitive info as well.
Resolves: rhbz#1410030
---
src/virt-viewer.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/virt-viewer.c b/src/virt-viewer.c
index 1121146..1f99552 100644
--- a/src/virt-viewer.c
+++ b/src/virt-viewer.c
Looks good to me
On Thu, 2017-01-05 at 18:47 +0200, Snir Sheriber wrote:
> Information about connection issues during display
> activation will appear in virt-viewer's window
>
> Related: rhbz#1386630
Acked-by: Pavel Grunt
> ---
> src/virt-viewer-app.c | 2 ++
> 1
On Wed, 2017-01-04 at 11:23 +0100, Pavel Grunt wrote:
> Resolves: rhbz#1410030
> ---
> src/virt-viewer.c | 11 ++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/src/virt-viewer.c b/src/virt-viewer.c
> index 1121146..05e6dbc 100644
> --- a/s
Resolves: rhbz#1410030
---
src/virt-viewer.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/virt-viewer.c b/src/virt-viewer.c
index 1121146..05e6dbc 100644
--- a/src/virt-viewer.c
+++ b/src/virt-viewer.c
@@ -928,6 +928,11 @@
virt_viewer_auth_libvirt_credential
Resolves: rhbz#1410030
---
src/virt-viewer.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/virt-viewer.c b/src/virt-viewer.c
index 1121146..4da5cd5 100644
--- a/src/virt-viewer.c
+++ b/src/virt-viewer.c
@@ -936,7 +936,6 @@
virt_viewer_auth_libvirt_credentials(virConnectCredentialPtr cred
Avoid showing the "Unknown" name in the guest detail dialog when
waiting for the domain to be started.
---
src/virt-viewer.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/virt-viewer.c b/src/virt-viewer.c
index 3a3b64d..1121146 100644
--- a/src/virt-viewer.c
+++ b/
On Tue, 2016-12-27 at 13:58 +0100, Fabiano Fidêncio wrote:
> On Tue, Dec 27, 2016 at 10:57 AM, Snir Sheriber > wrote:
> > Warning "Display can only be attached through libvirt with --
> > attach" is
> > now appears also in virt-viewer's window (as in the cmd prompt)
> > when
> > virt-viewer is wai
On Fri, 2016-12-30 at 00:56 +0100, Fabiano Fidêncio wrote:
> Snir,
>
> Sorry, I didn't pay attention to the bug report while reviewing the
> v1
> and by checking it now, I kinda agree with Pavel that the message
> shouldn't be a warning (but I'd be okay with a debug message).
>
oh, by my comment
On Mon, 2016-12-19 at 13:32 +0100, Fabiano Fidêncio wrote:
> On Mon, Dec 19, 2016 at 1:05 PM, Pavel Grunt
> wrote:
> > Hey, would you mind splitting the usb icon change ?
>
> I really don't see a good reason for that.
The commit would be shorter
The change of the icon
Hey, would you mind splitting the usb icon change ? The icon is
provided by some icon package or gtk ?
Pavel
On Sat, 2016-12-17 at 17:50 +0100, Fabiano Fidêncio wrote:
> From: Sagar Ghuge
>
> In order to give a modern look to {virt,remote}-viewer let's replace
> the
> old toolbar for a headerba
Hey,
On Sat, 2016-12-17 at 17:50 +0100, Fabiano Fidêncio wrote:
> GApplication's resource base path is based on the application-id,
> for
> instamce:
> - virt-viewer's resource base path: /org/virt-manager/virt-viewer,
> as
> the virt-viewer's application id is: org.virt-manager.virt-
> viewer
Hi,
On Thu, 2016-12-01 at 17:32 +0100, Christophe Fergeau wrote:
> When using a tunneled SPICE connection, the user will get a dozen
> authentication prompts if they are not using ssh-agent.
Please add a reference to the bug
https://bugzilla.redhat.com/show_bug.cgi?id=1377283
Pavel
> ---
> man
On Thu, 2016-11-24 at 12:59 +, Daniel P. Berrange wrote:
> On Thu, Nov 24, 2016 at 12:17:23PM +, Daniel P. Berrange wrote:
> > On Mon, Oct 10, 2016 at 04:05:32PM +0100, Daniel P. Berrange
> > wrote:
> > > On Mon, Oct 10, 2016 at 04:26:29PM +0200, Fabiano Fidêncio
> > > wrote:
> > > > On Mon
On Tue, 2016-11-22 at 16:37 +0100, Victor Toso wrote:
> Hi,
>
> On Tue, Nov 22, 2016 at 03:13:44PM +, 张 余歌 wrote:
> > recently,i meet some issues: when i try to install remote-viewer
> > in
> > debian8.6(i see remoteviewer version is 1.0.0) to use my win7
> > vm,it is
> > strange that the para
On Wed, 2016-11-16 at 08:09 +0100, Pavel Grunt wrote:
> Hi,
>
> run ./configure --with-spice-gtk
>
> As Christophe said it will tell you that you need higher version of
> spice-gtk dev packages. You can get the tarball from our website
> https://www.spice-space.org/downloa
Hi,
run ./configure --with-spice-gtk
As Christophe said it will tell you that you need higher version of
spice-gtk dev packages. You can get the tarball from our website
https://www.spice-space.org/download.html and install it somewhere,
then configure virt-viewer with spice-gtk (adjust PKG_CONF
On Thu, 2016-10-27 at 14:37 -0500, Jonathon Jongsma wrote:
> ---
> Here's a possible alternative solution. I chose not to 'continue' in
> the case
> of a NULL filename since you might end up with a message like:
>
> An error caused the following file transfers to fail:
yeah, it is the reason I
On Thu, 2016-10-27 at 14:33 -0500, Jonathon Jongsma wrote:
> ---
> Includes fixes from Pavel and Fabiano's reviews
Ack from me
Pavel
>
> src/resources/ui/virt-viewer-file-transfer-dialog.ui | 12 +++
> -
> src/virt-viewer-file-transfer-dialog.c | 6 +++---
> 2 files chang
Hi,
On Mon, 2016-10-24 at 16:04 -0500, Jonathon Jongsma wrote:
> When transferring a large number of files, the file transfer dialog
> was
> unusable because the window size would be larger than the client
> desktop.
The another issue is that it is always on the top
> To solve this, remove the
Hi Jonathon,
it looks good, I put some comments inline
On Mon, 2016-10-24 at 16:04 -0500, Jonathon Jongsma wrote:
> After all ongoing file transfers are finished, save a list of the
> file
> transfer tasks that had errors and display the list of failed files
> to
> the user so that they know that
On Mon, 2016-10-10 at 16:26 +0200, Fabiano Fidêncio wrote:
> On Mon, Oct 10, 2016 at 2:38 PM, Daniel P. Berrange .com> wrote:
> > The 4.0 release was in June, and there have not been very many
> > changes
> > since then, but there are a couple of significant ones
> >
> > - Fix resizing of window
On Wed, 2016-10-05 at 14:37 +0200, Christophe Fergeau wrote:
> Hey,
>
> On Wed, Oct 05, 2016 at 11:29:18AM +0200, Pavel Grunt wrote:
> > ---
> > src/virt-viewer-app.c | 14 ++
> > 1 file changed, 6 insertions(+), 8 deletions(-)
> >
> > diff -
Use errno to get the reason of the failure
Resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=1377100
---
src/virt-viewer-app.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
index ee3800b..a771a47 100644
--- a
On Wed, 2016-10-05 at 14:13 +0200, Christophe Fergeau wrote:
> On Wed, Oct 05, 2016 at 01:54:57PM +0200, Pavel Grunt wrote:
> > If the errors are going to be presented to the user, g_strerror()
> > is
> > not
> > the nicest message we can show.
>
>
> Yes,
On Wed, 2016-10-05 at 13:47 +0200, Christophe Fergeau wrote:
> On Wed, Oct 05, 2016 at 11:29:22AM +0200, Pavel Grunt wrote:
> > Use errno to get the reason of the failure
> >
> > Resolves:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1377100
> > --
1 - 100 of 440 matches
Mail list logo
