[virtio-dev] Re: [PATCH RFC 0/3] virtio-rng based entropy leak reporting

2023-01-11 Thread Michael S. Tsirkin
On Mon, Nov 21, 2022 at 11:30:19AM -0500, Michael S. Tsirkin wrote: > Generally, entropy only grows. However, there are cases where > it goes down - for example, consider generating a one time > pad where someone managed to use a side channel to > steal its contents. By combining the seemingly

Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

2023-01-11 Thread Michael S. Tsirkin
On Wed, Jan 11, 2023 at 10:12:38PM +0100, Halil Pasic wrote: > On Wed, 11 Jan 2023 19:08:53 +0800 > Xuan Zhuo wrote: > > > > > +The device shares memory to the driver based on shared memory regions > > > > +\ref{sec:Basic Facilities of a Virtio Device / Shared Memory Regions}. > > > > +However,

Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

2023-01-11 Thread Michael S. Tsirkin
On Thu, Jan 12, 2023 at 10:01:25AM +0800, Jason Wang wrote: > On Wed, Jan 11, 2023 at 11:11 PM Halil Pasic wrote: > > > > On Wed, 11 Jan 2023 19:08:53 +0800 > > Xuan Zhuo wrote: > > > > > > > +ISM(Internal Shared Memory) device provides the ability to share > > > > > memory between > > > > >

[virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-01-11 Thread Alexandre Courbot
Hi Alex (are we having too many Alexes in this discussion? ^_^;) On Thu, Jan 12, 2023 at 5:20 AM Alex Bennée wrote: > > > Alexander Gordeev writes: > > > Hi Alexandre, > > > > On 27.12.22 08:31, Alexandre Courbot wrote: > >> Hi Alexander, > >> > >> > >> On Tue, Dec 20, 2022 at 1:59 AM Alexander

[virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-01-11 Thread Alexandre Courbot
On Thu, Jan 12, 2023 at 3:42 AM Alexander Gordeev wrote: > > Hi Alexandre, > > On 27.12.22 08:31, Alexandre Courbot wrote: > > Hi Alexander, > > > > > > On Tue, Dec 20, 2022 at 1:59 AM Alexander Gordeev > > wrote: > >> Hello Alexandre, > >> > >> Thanks for the update. Please check my comments

[virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-01-11 Thread Alexandre Courbot
Hi Alexander, On Thu, Jan 12, 2023 at 2:04 AM Alexander Gordeev wrote: > > +\subsubsection{Bitstream formats}\label{sec:Device Types / Video Device / > > Supported formats / Bitstream formats} > > + > > +The fourcc code of each supported bitstream format is given, as well as > > +the unit of

Re: [virtio-dev] [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-01-11 Thread Alexandre Courbot
Hi Cornelia, On Wed, Jan 11, 2023 at 5:45 PM Cornelia Huck wrote: > >> > + > >> > +The device MUST set the \field{caps_length} field to a value equal to > >> > +the response size of VIRTIO\_VIDEO\_CMD\_DEVICE\_QUERY\_CAPS. > >> > >> Could the device also support a minimum response size that only

Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

2023-01-11 Thread Jason Wang
On Wed, Jan 11, 2023 at 11:11 PM Halil Pasic wrote: > > On Wed, 11 Jan 2023 19:08:53 +0800 > Xuan Zhuo wrote: > > > > > +ISM(Internal Shared Memory) device provides the ability to share > > > > memory between > > > > +different VMs launched from the same entity. > > > > > > Launched by instead

Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

2023-01-11 Thread Halil Pasic
On Wed, 11 Jan 2023 19:08:53 +0800 Xuan Zhuo wrote: > > > +The device shares memory to the driver based on shared memory regions > > > +\ref{sec:Basic Facilities of a Virtio Device / Shared Memory Regions}. > > > +However, it does not need to allocate physical memory during > > >

Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

2023-01-11 Thread Halil Pasic
On Wed, 11 Jan 2023 19:08:53 +0800 Xuan Zhuo wrote: > > > +\subsection{Permissions}\label{sec:Device Types / Network Device / > > > Device Operation / Permission} > > > + > > > +The permissions of a ism region determine whether this ism region can be > > > +attached and the read and write

[virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-01-11 Thread Alex Bennée
Alexander Gordeev writes: > Hi Alexandre, > > On 27.12.22 08:31, Alexandre Courbot wrote: >> Hi Alexander, >> >> >> On Tue, Dec 20, 2022 at 1:59 AM Alexander Gordeev >> wrote: >>> Hello Alexandre, >>> >>> Thanks for the update. Please check my comments below. >>> I'm new to the virtio video

[virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-01-11 Thread Alexander Gordeev
Hi Alexandre, On 08.12.22 08:23, Alexandre Courbot wrote: Add the specification of the video decoder and encoder devices, which can be used to provide host-accelerated video operations to the guest. Signed-off-by: Keiichi Watanabe Signed-off-by: Alexandre Courbot -- Here is the long-overdue

[virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-01-11 Thread Alexander Gordeev
Hi Alexandre, On 27.12.22 08:31, Alexandre Courbot wrote: Hi Alexander, On Tue, Dec 20, 2022 at 1:59 AM Alexander Gordeev wrote: Hello Alexandre, Thanks for the update. Please check my comments below. I'm new to the virtio video spec development, so I may lack some historic perspective. I

[virtio-dev] Re: [PATCH v2] virtio_net: support low and high rate of notification coalescing

2023-01-11 Thread Alvaro Karsz
After another inspection, I found some typos in the patch, will be fixed in the next version. > > This patch adds a new feature, VIRTIO_NET_F_NOTF_COAL_LOW_HIGH, while > clarifying/fixing existing coalescing concepts. > > The new feature adds 4 new commands to VIRTIO_NET_CTRL_NOTF_COAL class: >

[virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-01-11 Thread Alexander Gordeev
Hello, Sorry for the delay. I'm still gathering data in the old emails... On 08.12.22 08:23, Alexandre Courbot wrote: Add the specification of the video decoder and encoder devices, which can be used to provide host-accelerated video operations to the guest. Signed-off-by: Keiichi Watanabe

RE: [virtio-dev] [PATCH v3 06/20] virtio-mem-balloon: Maintain mem balloon device spec in separate directory

2023-01-11 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, January 11, 2023 11:22 AM > > > Also, I want to drop the prefix "virtio_" in the directory names. > > Any opinion on that? > > I'm fine with this. But I agree mem-balloon is not a good file name, let's > just > stick with balloon. It's unambigous

Re: [virtio-dev] [PATCH v3 06/20] virtio-mem-balloon: Maintain mem balloon device spec in separate directory

2023-01-11 Thread Michael S. Tsirkin
On Wed, Jan 11, 2023 at 04:01:42PM +, Parav Pandit wrote: > > > From: Cornelia Huck > > Sent: Wednesday, January 11, 2023 10:57 AM > > > > On Wed, Jan 11 2023, David Hildenbrand wrote: > > > > > On 11.01.23 16:01, Parav Pandit wrote: > > >> Hi David, > > > > > > Hi Parav, > > > > > >> > >

RE: [virtio-dev] [PATCH v3 06/20] virtio-mem-balloon: Maintain mem balloon device spec in separate directory

2023-01-11 Thread Parav Pandit
> From: Cornelia Huck > Sent: Wednesday, January 11, 2023 10:57 AM > > On Wed, Jan 11 2023, David Hildenbrand wrote: > > > On 11.01.23 16:01, Parav Pandit wrote: > >> Hi David, > > > > Hi Parav, > > > >> > >>> From: David Hildenbrand > >>> Sent: Wednesday, January 11, 2023 9:14 AM > >>> To:

Re: [virtio-dev] [PATCH v3 06/20] virtio-mem-balloon: Maintain mem balloon device spec in separate directory

2023-01-11 Thread Cornelia Huck
On Wed, Jan 11 2023, David Hildenbrand wrote: > On 11.01.23 16:01, Parav Pandit wrote: >> Hi David, > > Hi Parav, > >> >>> From: David Hildenbrand >>> Sent: Wednesday, January 11, 2023 9:14 AM >>> To: Parav Pandit ; m...@redhat.com; >>> virtio-dev@lists.oasis- >>> open.org; coh...@redhat.com

Re: [virtio-dev] [PATCH v3 06/20] virtio-mem-balloon: Maintain mem balloon device spec in separate directory

2023-01-11 Thread David Hildenbrand
On 11.01.23 16:01, Parav Pandit wrote: Hi David, Hi Parav, From: David Hildenbrand Sent: Wednesday, January 11, 2023 9:14 AM To: Parav Pandit ; m...@redhat.com; virtio-dev@lists.oasis- open.org; coh...@redhat.com Cc: virtio-comm...@lists.oasis-open.org Subject: Re: [virtio-dev] [PATCH v3

Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

2023-01-11 Thread Halil Pasic
On Wed, 11 Jan 2023 19:08:53 +0800 Xuan Zhuo wrote: > > > +\begin{description} > > > +\item[\field{ev_type}] The type of event, the driver can get the size of > > > the > > > +structure based on this. > > > + > > > +\item[\field{offset}] The offset of ism regions with the event. > > > >

Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

2023-01-11 Thread Halil Pasic
On Wed, 11 Jan 2023 19:08:53 +0800 Xuan Zhuo wrote: > > > > > +Large shared memories are divided into multiple chunks, and one > > > time > > > > "Memories" sounds wrong here. I guess what you used to call "regions" > > you now call "chunks". But I may be wrong. > > A ism region

[virtio-dev] [PATCH v2] virtio_net: support low and high rate of notification coalescing

2023-01-11 Thread Alvaro Karsz
This patch adds a new feature, VIRTIO_NET_F_NOTF_COAL_LOW_HIGH, while clarifying/fixing existing coalescing concepts. The new feature adds 4 new commands to VIRTIO_NET_CTRL_NOTF_COAL class: - VIRTIO_NET_CTRL_NOTF_COAL_LOW_TX_SET - coalescing parameters to use when the packet

Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

2023-01-11 Thread Halil Pasic
On Wed, 11 Jan 2023 19:08:53 +0800 Xuan Zhuo wrote: > > > +ISM(Internal Shared Memory) device provides the ability to share memory > > > between > > > +different VMs launched from the same entity. > > > > Launched by instead of from? Maybe introduce a catchy name for the > > "entity that

RE: [virtio-dev] [PATCH v3 06/20] virtio-mem-balloon: Maintain mem balloon device spec in separate directory

2023-01-11 Thread Parav Pandit
Hi David, > From: David Hildenbrand > Sent: Wednesday, January 11, 2023 9:14 AM > To: Parav Pandit ; m...@redhat.com; virtio-dev@lists.oasis- > open.org; coh...@redhat.com > Cc: virtio-comm...@lists.oasis-open.org > Subject: Re: [virtio-dev] [PATCH v3 06/20] virtio-mem-balloon: Maintain mem >

Re: [virtio-dev] [PATCH v3 06/20] virtio-mem-balloon: Maintain mem balloon device spec in separate directory

2023-01-11 Thread Michael S. Tsirkin
On Wed, Jan 11, 2023 at 03:14:10PM +0100, David Hildenbrand wrote: > On 11.01.23 00:03, Parav Pandit wrote: > > Move virtio memory balloon device specification to its own file > > similar to recent virtio devices. > > While at it, place device specification, its driver and device > > conformance

Re: [virtio-dev] [PATCH v3 06/20] virtio-mem-balloon: Maintain mem balloon device spec in separate directory

2023-01-11 Thread David Hildenbrand
On 11.01.23 00:03, Parav Pandit wrote: Move virtio memory balloon device specification to its own file similar to recent virtio devices. While at it, place device specification, its driver and device conformance into its own directory to have self contained device specification. Fixes:

[virtio-dev] Re: [PATCH RFC 3/3] rng: leak detection support

2023-01-11 Thread Babis Chalios
CCing Amit On 21/11/22 17:30, Michael S. Tsirkin wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. Add virtqueues to support reporting entropy leaks (similar to

[virtio-dev] RE: [PATCH v3 19/20] virtio-gpio: Maintain gpio device spec in separate directory

2023-01-11 Thread Parav Pandit
> From: Cornelia Huck > Sent: Wednesday, January 11, 2023 5:52 AM > > On Wed, Jan 11 2023, Parav Pandit wrote: > > > Place device specification, its driver and device conformance into its > > own directory to have self contained device specification. > > > > Fixes:

[virtio-dev] Re: [PATCH v3 11/20] virtio-vsock: Maintain socket device spec in separate directory

2023-01-11 Thread Cornelia Huck
On Wed, Jan 11 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

[virtio-dev] Re: [PATCH v3 19/20] virtio-gpio: Maintain gpio device spec in separate directory

2023-01-11 Thread Cornelia Huck
On Wed, Jan 11 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-11 Thread Michael S. Tsirkin
On Wed, Jan 11, 2023 at 12:45:06PM +0800, Jason Wang wrote: > On Wed, Jan 11, 2023 at 11:23 AM Heng Qi wrote: > > > > > > > > 在 2023/1/10 下午3:26, Heng Qi 写道: > > > On Tue, Jan 10, 2023 at 12:57:38AM -0500, Michael S. Tsirkin wrote: > > >> On Tue, Jan 10, 2023 at 12:25:02AM -0500, Michael S.

[virtio-dev] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-11 Thread Michael S. Tsirkin
On Wed, Jan 04, 2023 at 03:14:01PM +0800, Heng Qi wrote: > If the tunnel is used to encapsulate the packets, the hash calculated > using the outer header of the receive packets is always fixed for the > same flow packets, i.e. they will be steered to the same receive queue. > > We add a feature

Re: [virtio-dev] [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-01-11 Thread Cornelia Huck
On Tue, Dec 27 2022, Alexandre Courbot wrote: > Hi Cornelia, thanks for the feedback! I have directly reported the > comments snipped from this answer to the source document. > > On Fri, Dec 9, 2022 at 12:01 AM Cornelia Huck wrote: >> >> On Thu, Dec 08 2022, Alexandre Courbot wrote: >> >> >