[virtio-dev] [PATCH 11/11] conformance: Add transitional MMR interface conformance

2023-03-30 Thread Parav Pandit
Add conformance section for the transitional MMR interface. Basically transitional MMR interface follows same requirements as that of the transitional device with few exceptions to it. List such delta requirements in the conformance section. Co-developed-by: Satananda Burla Signed-off-by: Parav

[virtio-dev] [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-03-30 Thread Parav Pandit
Legacy virtio configuration registers and adjacent device configuration registers are located somewhere in a memory BAR. A new capability supplies the location of these registers which a driver can use to map I/O access to legacy memory mapped registers. This gives the ability to locate legacy

[virtio-dev] [PATCH 10/11] transport-pci: Use driver notification PCI capability

2023-03-30 Thread Parav Pandit
PCI devices support memory BAR regions for performant driver notifications using the notification capability. Enable transitional MMR devices to use it in simpler manner. Co-developed-by: Satananda Burla Signed-off-by: Parav Pandit --- transport-pci.tex | 28 1

[virtio-dev] [PATCH 06/11] introduction: Introduce transitional MMR interface

2023-03-30 Thread Parav Pandit
Introduce terminology for the transitional MMR device and transitional MMR driver. Add description of the transitional MMR device. It is a PCI device that implements legacy virtio common configuration registers followed by legacy device specific registers in a memory region at an offset. This

[virtio-dev] [PATCH 05/11] introduction: Add missing helping verb

2023-03-30 Thread Parav Pandit
The terminology of Transitional device and driver is missing the helping verb 'is' similar to other terminologies. Hence, add them to complete the sentence. Signed-off-by: Parav Pandit --- introduction.tex | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/introduction.tex

[virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-03-30 Thread Parav Pandit
PCI device configuration space for capabilities is limited to only 192 bytes shared by many PCI capabilities of generic PCI device and virtio specific. Hence, introduce virtio extended capability that uses PCI Express extended capability. Subsequent patch uses this virtio extended capability.

[virtio-dev] [PATCH 03/11] transport-pci: Split notes of PCI Device Layout

2023-03-30 Thread Parav Pandit
Currently single legacy interface section describes PCI common configuration layout and feature bits operation for the legacy interface. Hence, split PCI Device Layout legacy interface section into two parts. First subsection for common configuration and second subsection for feature bits.

[virtio-dev] [PATCH 01/11] transport-pci: Use lowecase alphabets

2023-03-30 Thread Parav Pandit
Use uniformly lowercase alphabets to write PCI vendor id and device id. Signed-off-by: Parav Pandit --- transport-pci.tex | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/transport-pci.tex b/transport-pci.tex index 85b2dae..7f27107 100644 ---

[virtio-dev] [PATCH 02/11] transport-pci: Move transitional device id to legacy section

2023-03-30 Thread Parav Pandit
Currently PCI device discovery details for the transitional device are documented in two different sections. For example, PCI device and vendor ID registers are documented in 'Device Requirements: PCI Device Discovery' section, while PCI revision id is documented in 'Legacy Interfaces: A Note on

[virtio-dev] [PATCH 07/11] transport-pci: Introduce transitional MMR device id

2023-03-30 Thread Parav Pandit
Transitional MMR device PCI Device IDs are unique. Hence, any of the existing drivers do not bind to it. This further maintains the backward compatibility with existing drivers. Co-developed-by: Satananda Burla Signed-off-by: Parav Pandit --- transport-pci.tex | 45

[virtio-dev] [PATCH 04/11] transport-pci: Rename and move legacy PCI Device layout section

2023-03-30 Thread Parav Pandit
Current 'Legacy Interfaces: A Note on PCI Device Layout' explains virtio legacy registers which consist of common configuration structure and device specific registers. It has little to do with the existing PCI Device layout section. For example, non transitional device's common configuration

[virtio-dev] [PATCH 00/11] Introduce transitional mmr pci device

2023-03-30 Thread Parav Pandit
Overview: - The Transitional MMR device is a variant of the transitional PCI device. It has its own small Device ID range. It does not have I/O region BAR; instead it exposes legacy configuration and device specific registers at an offset in the memory region BAR. Such transitional MMR

[virtio-dev] [PATCH v2 2/2] virtio-blk: fix ZBD probe in kernels without ZBD support

2023-03-30 Thread Dmitry Fomichev
When the kernel is built without support for zoned block devices, virtio-blk probe needs to error out any host-managed device scans to prevent such devices from appearing in the system as non-zoned. The current virtio-blk code simply bypasses all ZBD checks if CONFIG_BLK_DEV_ZONED is not defined

[virtio-dev] [PATCH v2 1/2] virtio-blk: migrate to the latest patchset version

2023-03-30 Thread Dmitry Fomichev
The merged patch series to support zoned block devices in virtio-blk is not the most up to date version. The merged patch can be found at https://lore.kernel.org/linux-block/20221016034127.330942-3-dmitry.fomic...@wdc.com/ , but the latest and reviewed version is

[virtio-dev] [PATCH v2 0/2] virtio-blk: fix a few problems in ZBD-related code

2023-03-30 Thread Dmitry Fomichev
This two-part series contains code fixes that are related to the recently added support for zoned block devices in virtio-blk driver. The original ZBD patchset that was merged to the kernel -next was not the latest and greatest version. The first patch of this series is essentially a diff between

RE: [virtio-dev] [PATCH v10 0/8] Rename queue index to queue number

2023-03-30 Thread Parav Pandit
> From: Halil Pasic > Sent: Thursday, March 30, 2023 1:11 PM > I argue that using a different term in that context than in the rest of the > specification makes sense, because in the context of notifications the > virtqueue > isn't always identified by its index. Using single term as number

[virtio-dev] RE: [virtio-comment] [PATCH v10 2/8] transport-pci: Refer to the vq by its number

2023-03-30 Thread Parav Pandit
> From: Halil Pasic > Sent: Thursday, March 30, 2023 1:10 PM > > -The driver will use this value to put it in the 'virtqueue number' > > field > > +The driver uses this value in the field \field{vqn} > > This is one of the problems with this approach... > Instead of vqn, it

Re: [virtio-dev] [PATCH v10 0/8] Rename queue index to queue number

2023-03-30 Thread Halil Pasic
On Thu, 30 Mar 2023 00:23:33 +0300 Parav Pandit wrote: > 1. Currently, virtqueue is identified between driver and device > interchangeably using either number or index terminology. > > 2. Between PCI and MMIO transport the queue size (depth) is > defined as queue_size and QueueNum respectively.

[virtio-dev] Re: [virtio-comment] [PATCH v10 2/8] transport-pci: Refer to the vq by its number

2023-03-30 Thread Halil Pasic
On Thu, 30 Mar 2023 00:23:35 +0300 Parav Pandit wrote: > Currently specification uses virtqueue index and > number interchangeably to refer to the virtqueue. > > Instead refer to it by its number. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163 > Reviewed-by: Cornelia Huck >

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH v9] virtio-net: support inner header hash

2023-03-30 Thread Heng Qi
在 2023/3/21 上午3:48, Michael S. Tsirkin 写道: On Wed, Mar 15, 2023 at 08:55:45PM +0800, Heng Qi wrote: We use the most basic GRE header fields (not NVGRE), not even optional fields. I'd say yes, the most convincing usecase is with legacy GRE. Yes. But we still have a strong need for VXLAN

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH v9] virtio-net: support inner header hash

2023-03-30 Thread Heng Qi
在 2023/3/21 上午3:45, Michael S. Tsirkin 写道: On Thu, Mar 16, 2023 at 09:17:26PM +0800, Heng Qi wrote: On Wed, Mar 15, 2023 at 10:57:40AM -0400, Michael S. Tsirkin wrote: On Wed, Mar 15, 2023 at 08:55:45PM +0800, Heng Qi wrote: 在 2023/3/15 下午7:58, Michael S. Tsirkin 写道: On Sat, Mar 11, 2023

[virtio-dev] Re: [PATCH v10 8/8] virtio-net: Describe RSS using rss rq id

2023-03-30 Thread Cornelia Huck
On Thu, Mar 30 2023, Parav Pandit wrote: > The content of indirection table and unclassified_queue which are > based on math calculation historically. To better describe this, to > avoid intermixing array index with virtqueue index and to use virtqueue > number > > introduce a field rq_handle

[virtio-dev] Re: [PATCH v10 7/8] virtio-net: Avoid duplicate receive queue example

2023-03-30 Thread Cornelia Huck
On Thu, Mar 30 2023, Parav Pandit wrote: > Receive queue number/index example is duplicate which is already defined > in the Setting RSS parameters section. > > Hence, avoid such duplicate example and prepare it for the subsequent > patch to describe using receive queue handle. > > Fixes:

[virtio-dev] Re: [PATCH v10 6/8] transport-ccw: Refer to the vq by its number

2023-03-30 Thread Cornelia Huck
On Thu, Mar 30 2023, Parav Pandit wrote: > Currently specification uses virtqueue index and > number interchangeably to refer to the virtqueue. > > Instead refer to it by its number. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163 > Signed-off-by: Parav Pandit > > --- >

[virtio-dev] Re: [PATCH v10 1/8] content: Add vq number text

2023-03-30 Thread Cornelia Huck
On Thu, Mar 30 2023, Parav Pandit wrote: > Introduce vq number and its range so that subsequent patches can refer > to it. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163 > Signed-off-by: Parav Pandit > --- > changelog: > v9->v10: > - added braces around vq number wording > -