[PATCH] virtio-spec: fix thinko in multiport documentation

2012-09-09 Thread Michael S. Tsirkin
spec numbers ports port0, port 1 etc, then goes on to say "ports 2 onwards only if MULTIPORT is set". An obvious thinko, should be port 1 onwards. Signed-off-by: Michael S. Tsirkin --- virtio-spec.lyx | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/virtio-spec.lyx b/vi

[PATCH] virtio-spec: balloon: MUST_TELL_HOST is optional

2012-09-09 Thread Michael S. Tsirkin
Drivers treat MUST_TELL_HOST as optional: windows drivers do not ack it and expect this means they can tell host *after* deflate. This was not the intent but the documentation was not very clear on this point. Luckily hyprevisors did not implement this feature yet so to provide guidance for futur

[PATCH] virtio-spec: serial: english tweak

2012-09-09 Thread Michael S. Tsirkin
"A number of virtqueues are created" seems clearer than "the number of virtqueues": it's virtqueues that are created not the number. Signed-off-by: Michael S. Tsirkin --- I'm not a native english speaker but the below seems correct to me. Rusty? virtio-spec.lyx | 2 +- 1 file changed, 1 insert

Re: [PATCHv3] virtio-spec: virtio network device multiqueue support

2012-09-09 Thread Michael S. Tsirkin
On Fri, Sep 07, 2012 at 02:17:08AM +0200, Sasha Levin wrote: > Hi Michael, > > On 09/06/2012 02:08 PM, Michael S. Tsirkin wrote: > > Add multiqueue support to virtio network device. > > Add a new feature flag VIRTIO_NET_F_MULTIQUEUE for this feature, a new > > configuration field max_virtqueue_pai

[PATCHv4] virtio-spec: virtio network device multiqueue support

2012-09-09 Thread Michael S. Tsirkin
Add multiqueue support to virtio network device. Add a new feature flag VIRTIO_NET_F_MULTIQUEUE for this feature, a +new configuration field max_virtqueue_pairs to detect supported number +of virtqueues as well as a new command VIRTIO_NET_CTRL_STEERING to +program packet steering. Signed-off-by:

Re: [PATCH] virtio: console: fix error handling in init() function

2012-09-09 Thread Amit Shah
Hi Alexey, On (Sat) 01 Sep 2012 [23:49:37], Alexey Khoroshilov wrote: > If register_virtio_driver() fails, virtio-ports class is not destroyed. > The patch adds error handling of register_virtio_driver(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexe

Re: [PATCH] virtio-spec: serial: english tweak

2012-09-09 Thread Amit Shah
On (Sun) 09 Sep 2012 [15:11:17], Michael S. Tsirkin wrote: > "A number of virtqueues are created" seems clearer > than "the number of virtqueues": it's > virtqueues that are created not the number. > > Signed-off-by: Michael S. Tsirkin Acked-by: Amit Shah Amit _

Re: [PATCH] virtio-spec: fix thinko in multiport documentation

2012-09-09 Thread Amit Shah
On (Sun) 09 Sep 2012 [14:08:37], Michael S. Tsirkin wrote: > spec numbers ports port0, port 1 etc, then goes on to say > "ports 2 onwards only if MULTIPORT is set". > An obvious thinko, should be port 1 onwards. > > Signed-off-by: Michael S. Tsirkin Acked-by: Amit Shah Amit ___

Re: [PATCH] virtio: console: fix error handling in init() function

2012-09-09 Thread Rusty Russell
Amit Shah writes: > On (Sat) 01 Sep 2012 [23:49:37], Alexey Khoroshilov wrote: >> If register_virtio_driver() fails, virtio-ports class is not destroyed. >> The patch adds error handling of register_virtio_driver(). >> >> Found by Linux Driver Verification project (linuxtesting.org). >> >> Signe

Re: [PATCHv4] virtio-spec: virtio network device multiqueue support

2012-09-09 Thread Rusty Russell
OK, I read the spec (pasted below for easy of reading), but I'm still confused over how this will work. I thought normal net drivers have the hardware provide an rxhash for each packet, and we map that to CPU to queue the packet on[1]. We hope that the receiving process migrates to that CPU, so x

Re: [PATCH] virtio-balloon spec: provide a version of the "silent deflate" feature that works

2012-09-09 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Sat, Sep 08, 2012 at 02:36:00PM +0930, Rusty Russell wrote: >> "Michael S. Tsirkin" writes: >> > On Fri, Sep 07, 2012 at 04:09:50PM +0930, Rusty Russell wrote: >> >> > So it looks like a bug: we should teach driver to tell host first on >> >> > leak? >> >> > Yan

Re: [PATCH] virtio-balloon spec: provide a version of the "silent deflate" feature that works

2012-09-09 Thread Paolo Bonzini
Il 09/09/2012 00:22, Michael S. Tsirkin ha scritto: >> Almost. One is "the guest, if really needed, can tell the host of >> pages". If not negotiated, and the host does not support it, the host >> must break the guest (e.g. fail to offer any virtqueues). > > There is no way in spec to break the

Re: [PATCH] virtio-balloon spec: provide a version of the "silent deflate" feature that works

2012-09-09 Thread Michael S. Tsirkin
On Mon, Sep 10, 2012 at 11:13:12AM +0930, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > On Sat, Sep 08, 2012 at 02:36:00PM +0930, Rusty Russell wrote: > >> "Michael S. Tsirkin" writes: > >> > On Fri, Sep 07, 2012 at 04:09:50PM +0930, Rusty Russell wrote: > >> >> > So it looks like a bug

Re: [PATCH] virtio-balloon spec: provide a version of the "silent deflate" feature that works

2012-09-09 Thread Paolo Bonzini
Il 10/09/2012 03:43, Rusty Russell ha scritto: >> Now that vfio is upstream and work on qemu integration >> is being worked on, we might finally see people using this bit >> to allow memory overcommit with device assignment. > That was left-field so you're saying some guest might pull a page >

Re: [PATCH] virtio-balloon spec: provide a version of the "silent deflate" feature that works

2012-09-09 Thread Michael S. Tsirkin
On Mon, Sep 10, 2012 at 07:50:13AM +0200, Paolo Bonzini wrote: > Il 09/09/2012 00:22, Michael S. Tsirkin ha scritto: > >> Almost. One is "the guest, if really needed, can tell the host of > >> pages". If not negotiated, and the host does not support it, the host > >> must break the guest (e.g. fa

Re: [PATCHv4] virtio-spec: virtio network device multiqueue support

2012-09-09 Thread Michael S. Tsirkin
On Mon, Sep 10, 2012 at 11:42:25AM +0930, Rusty Russell wrote: > OK, I read the spec (pasted below for easy of reading), but I'm still > confused over how this will work. > > I thought normal net drivers have the hardware provide an rxhash for > each packet, and we map that to CPU to queue the pac

Re: [PATCH] virtio-spec: balloon: MUST_TELL_HOST is optional

2012-09-09 Thread Paolo Bonzini
Il 09/09/2012 13:36, Michael S. Tsirkin ha scritto: > \begin_layout Enumerate > -If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is set, the guest may not > - use these requested pages until that descriptor in the deflateq has been > - used by the device. > +If the VIRTIO_BALLOON_F_MUST_TELL_HOST f

Re: [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-09 Thread Paolo Bonzini
Il 09/09/2012 00:40, Michael S. Tsirkin ha scritto: > On Fri, Sep 07, 2012 at 06:00:50PM +0200, Paolo Bonzini wrote: >> Il 07/09/2012 08:48, Nicholas A. Bellinger ha scritto: >>> Cc: Stefan Hajnoczi >>> Cc: Zhi Yong Wu >>> Cc: Michael S. Tsirkin >>> Cc: Paolo Bonzini >>> Signed-off-by: Nicholas

Re: [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-09 Thread Michael S. Tsirkin
On Mon, Sep 10, 2012 at 08:16:54AM +0200, Paolo Bonzini wrote: > Il 09/09/2012 00:40, Michael S. Tsirkin ha scritto: > > On Fri, Sep 07, 2012 at 06:00:50PM +0200, Paolo Bonzini wrote: > >> Il 07/09/2012 08:48, Nicholas A. Bellinger ha scritto: > >>> Cc: Stefan Hajnoczi > >>> Cc: Zhi Yong Wu > >>>

Re: [PATCHv4] virtio-spec: virtio network device multiqueue support

2012-09-09 Thread Michael S. Tsirkin
On Mon, Sep 10, 2012 at 09:16:29AM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 10, 2012 at 11:42:25AM +0930, Rusty Russell wrote: > > OK, I read the spec (pasted below for easy of reading), but I'm still > > confused over how this will work. > > > > I thought normal net drivers have the hardwar

Re: [PATCHv4] virtio-spec: virtio network device multiqueue support

2012-09-09 Thread Michael S. Tsirkin
On Mon, Sep 10, 2012 at 09:27:38AM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 10, 2012 at 09:16:29AM +0300, Michael S. Tsirkin wrote: > > On Mon, Sep 10, 2012 at 11:42:25AM +0930, Rusty Russell wrote: > > > OK, I read the spec (pasted below for easy of reading), but I'm still > > > confused ove

Re: [PATCH] virtio-balloon spec: provide a version of the "silent deflate" feature that works

2012-09-09 Thread Paolo Bonzini
Il 10/09/2012 08:03, Michael S. Tsirkin ha scritto: > On Mon, Sep 10, 2012 at 07:50:13AM +0200, Paolo Bonzini wrote: >> Il 09/09/2012 00:22, Michael S. Tsirkin ha scritto: Almost. One is "the guest, if really needed, can tell the host of pages". If not negotiated, and the host does not

Re: [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-09 Thread Paolo Bonzini
Il 10/09/2012 08:24, Michael S. Tsirkin ha scritto: >> > I chose the backend name because, ideally, there would be no other >> > difference. QEMU _could_ implement all the goodies in vhost-scsi (such >> > as reservations or ALUA), it just doesn't do that yet. >> > >> > Paolo > Then why do you say

Re: [PATCH] virtio-balloon spec: provide a version of the "silent deflate" feature that works

2012-09-09 Thread Michael S. Tsirkin
On Mon, Sep 10, 2012 at 08:38:09AM +0200, Paolo Bonzini wrote: > Il 10/09/2012 08:03, Michael S. Tsirkin ha scritto: > > On Mon, Sep 10, 2012 at 07:50:13AM +0200, Paolo Bonzini wrote: > >> Il 09/09/2012 00:22, Michael S. Tsirkin ha scritto: > Almost. One is "the guest, if really needed, can t

Re: [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-09 Thread Michael S. Tsirkin
On Mon, Sep 10, 2012 at 08:42:15AM +0200, Paolo Bonzini wrote: > Il 10/09/2012 08:24, Michael S. Tsirkin ha scritto: > >> > I chose the backend name because, ideally, there would be no other > >> > difference. QEMU _could_ implement all the goodies in vhost-scsi (such > >> > as reservations or ALU

Re: [PATCH] virtio-balloon spec: provide a version of the "silent deflate" feature that works

2012-09-09 Thread Paolo Bonzini
Il 10/09/2012 08:47, Michael S. Tsirkin ha scritto: > On Mon, Sep 10, 2012 at 08:38:09AM +0200, Paolo Bonzini wrote: >> Il 10/09/2012 08:03, Michael S. Tsirkin ha scritto: >>> On Mon, Sep 10, 2012 at 07:50:13AM +0200, Paolo Bonzini wrote: Il 09/09/2012 00:22, Michael S. Tsirkin ha scritto: >>>