Re: [PATCHv4] virtio-spec: virtio network device multiqueue support

2012-09-10 Thread Michael S. Tsirkin
On Mon, Sep 10, 2012 at 11:42:25AM +0930, Rusty Russell wrote: OK, I read the spec (pasted below for easy of reading), but I'm still confused over how this will work. I thought normal net drivers have the hardware provide an rxhash for each packet, and we map that to CPU to queue the packet

Re: [PATCH] virtio-spec: balloon: MUST_TELL_HOST is optional

2012-09-10 Thread Paolo Bonzini
Il 09/09/2012 13:36, Michael S. Tsirkin ha scritto: \begin_layout Enumerate -If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is set, the guest may not - use these requested pages until that descriptor in the deflateq has been - used by the device. +If the VIRTIO_BALLOON_F_MUST_TELL_HOST

Re: [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-10 Thread Paolo Bonzini
Il 09/09/2012 00:40, Michael S. Tsirkin ha scritto: On Fri, Sep 07, 2012 at 06:00:50PM +0200, Paolo Bonzini wrote: Il 07/09/2012 08:48, Nicholas A. Bellinger ha scritto: Cc: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Cc: Zhi Yong Wu wu...@linux.vnet.ibm.com Cc: Michael S. Tsirkin

Re: [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-10 Thread Michael S. Tsirkin
On Mon, Sep 10, 2012 at 08:16:54AM +0200, Paolo Bonzini wrote: Il 09/09/2012 00:40, Michael S. Tsirkin ha scritto: On Fri, Sep 07, 2012 at 06:00:50PM +0200, Paolo Bonzini wrote: Il 07/09/2012 08:48, Nicholas A. Bellinger ha scritto: Cc: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Cc: Zhi

Re: [PATCHv4] virtio-spec: virtio network device multiqueue support

2012-09-10 Thread Michael S. Tsirkin
On Mon, Sep 10, 2012 at 09:16:29AM +0300, Michael S. Tsirkin wrote: On Mon, Sep 10, 2012 at 11:42:25AM +0930, Rusty Russell wrote: OK, I read the spec (pasted below for easy of reading), but I'm still confused over how this will work. I thought normal net drivers have the hardware

Re: [PATCHv4] virtio-spec: virtio network device multiqueue support

2012-09-10 Thread Michael S. Tsirkin
On Mon, Sep 10, 2012 at 09:27:38AM +0300, Michael S. Tsirkin wrote: On Mon, Sep 10, 2012 at 09:16:29AM +0300, Michael S. Tsirkin wrote: On Mon, Sep 10, 2012 at 11:42:25AM +0930, Rusty Russell wrote: OK, I read the spec (pasted below for easy of reading), but I'm still confused over how

Re: [PATCH] virtio-balloon spec: provide a version of the silent deflate feature that works

2012-09-10 Thread Paolo Bonzini
Il 10/09/2012 08:03, Michael S. Tsirkin ha scritto: On Mon, Sep 10, 2012 at 07:50:13AM +0200, Paolo Bonzini wrote: Il 09/09/2012 00:22, Michael S. Tsirkin ha scritto: Almost. One is the guest, if really needed, can tell the host of pages. If not negotiated, and the host does not support it,

Re: [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-10 Thread Paolo Bonzini
Il 10/09/2012 08:24, Michael S. Tsirkin ha scritto: I chose the backend name because, ideally, there would be no other difference. QEMU _could_ implement all the goodies in vhost-scsi (such as reservations or ALUA), it just doesn't do that yet. Paolo Then why do you say It is used

Re: [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-10 Thread Michael S. Tsirkin
On Mon, Sep 10, 2012 at 08:42:15AM +0200, Paolo Bonzini wrote: Il 10/09/2012 08:24, Michael S. Tsirkin ha scritto: I chose the backend name because, ideally, there would be no other difference. QEMU _could_ implement all the goodies in vhost-scsi (such as reservations or ALUA), it just

Re: [PATCH] virtio-balloon spec: provide a version of the silent deflate feature that works

2012-09-10 Thread Paolo Bonzini
Il 10/09/2012 08:47, Michael S. Tsirkin ha scritto: On Mon, Sep 10, 2012 at 08:38:09AM +0200, Paolo Bonzini wrote: Il 10/09/2012 08:03, Michael S. Tsirkin ha scritto: On Mon, Sep 10, 2012 at 07:50:13AM +0200, Paolo Bonzini wrote: Il 09/09/2012 00:22, Michael S. Tsirkin ha scritto: Almost.

Re: [RFCv2 1/2] virtio_console: Add support for DMA memory allocation

2012-09-10 Thread Rusty Russell
sjur.brandel...@stericsson.com writes: From: Sjur Brændeland sjur.brandel...@stericsson.com Add feature VIRTIO_CONSOLE_F_DMA_MEM. If the architecture has DMA support and this feature bit is set, the virtio data buffers will be allocated from DMA memory. If the device requests the feature

Re: [PATCH] Add a page cache-backed balloon device driver.

2012-09-10 Thread Michael S. Tsirkin
On Tue, Jun 26, 2012 at 01:32:58PM -0700, Frank Swiderski wrote: This implementation of a virtio balloon driver uses the page cache to store pages that have been released to the host. The communication (outside of target counts) is one way--the guest notifies the host when it adds a page to

Re: [Xen-devel] [patch 3/3] xen/privcmd: remove const modifier from declaration

2012-09-10 Thread Jan Beulich
On 08.09.12 at 11:58, Dan Carpenter dan.carpen...@oracle.com wrote: When we use this pointer, we cast away the const modifier and modify the data. I think it was an accident to declare it as const. NAK - the const is very valid here, as the v2 interface (as opposed to the v1 one) does _not_

[patch 3/3 v2] xen/privcmd: add a __user annotation to a cast

2012-09-10 Thread Dan Carpenter
Sparse complains that we lose the __user annotation in the cast here. drivers/xen/privcmd.c:388:35: warning: cast removes address space of expression drivers/xen/privcmd.c:388:32: warning: incorrect type in assignment (different address spaces) drivers/xen/privcmd.c:388:32:expected unsigned

Re: [PATCHv4] virtio-spec: virtio network device multiqueue support

2012-09-10 Thread Jason Wang
On 09/10/2012 02:33 PM, Michael S. Tsirkin wrote: On Mon, Sep 10, 2012 at 09:27:38AM +0300, Michael S. Tsirkin wrote: On Mon, Sep 10, 2012 at 09:16:29AM +0300, Michael S. Tsirkin wrote: On Mon, Sep 10, 2012 at 11:42:25AM +0930, Rusty Russell wrote: OK, I read the spec (pasted below for easy

Re: [Xen-devel] [patch 1/3] xen/privcmd: check for integer overflow in ioctl

2012-09-10 Thread Dan Carpenter
On Mon, Sep 10, 2012 at 11:35:11AM +0100, David Vrabel wrote: On 08/09/12 10:52, Dan Carpenter wrote: If m.num is too large then the m.num * sizeof(*m.arr) multiplication could overflow and the access_ok() check wouldn't test the right size. m.num is range checked later on so it doesn't

[RFCv3] virtio_console: Add support for virtio remoteproc serial

2012-09-10 Thread sjur . brandeland
From: Sjur Brændeland sjur.brandel...@stericsson.com Add a virtio remoteproc serial driver: VIRTIO_ID_RPROC_SERIAL (0xB) for communicating with a remote processor in an asymmetric multi-processing configuration. The virtio remoteproc serial driver reuses the existing virtio_console

Re: [PATCH v2 2/2] virtio-ring: Allocate indirect buffers from cache when possible

2012-09-10 Thread Thomas Lendacky
On Friday, September 07, 2012 09:19:04 AM Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: On Thu, Sep 06, 2012 at 05:27:23PM +0930, Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: Yes without checksum net core always linearizes packets, so yes it is

Re: [PATCH v2 2/2] virtio-ring: Allocate indirect buffers from cache when possible

2012-09-10 Thread Paolo Bonzini
Il 06/09/2012 07:02, Michael S. Tsirkin ha scritto: It might be worth just unconditionally having a cache for the 2 descriptor case. This is what I get with qemu tap, though for some reason the device features don't have guest or host CSUM, so my setup is probably screwed: Yes without

Re: [PATCH v2 2/2] virtio-ring: Allocate indirect buffers from cache when possible

2012-09-10 Thread Michael S. Tsirkin
On Mon, Sep 10, 2012 at 10:47:15AM -0500, Thomas Lendacky wrote: On Friday, September 07, 2012 09:19:04 AM Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: On Thu, Sep 06, 2012 at 05:27:23PM +0930, Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes:

Re: [PATCH v2 2/2] virtio-ring: Allocate indirect buffers from cache when possible

2012-09-10 Thread Thomas Lendacky
On Friday, September 07, 2012 09:19:04 AM Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: On Thu, Sep 06, 2012 at 05:27:23PM +0930, Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: Yes without checksum net core always linearizes packets, so yes it is

Re: [PATCH] Add a page cache-backed balloon device driver.

2012-09-10 Thread Mike Waychison
On Mon, Sep 10, 2012 at 5:05 AM, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Jun 26, 2012 at 01:32:58PM -0700, Frank Swiderski wrote: This implementation of a virtio balloon driver uses the page cache to store pages that have been released to the host. The communication (outside of

Re: [PATCH] Add a page cache-backed balloon device driver.

2012-09-10 Thread Rik van Riel
On 09/10/2012 01:37 PM, Mike Waychison wrote: On Mon, Sep 10, 2012 at 5:05 AM, Michael S. Tsirkin m...@redhat.com wrote: Also can you pls answer Avi's question? How is overcommit managed? Overcommit in our deployments is managed using memory cgroups on the host. This allows us to have very

Re: [PATCH] Add a page cache-backed balloon device driver.

2012-09-10 Thread Mike Waychison
On Mon, Sep 10, 2012 at 2:04 PM, Rik van Riel r...@redhat.com wrote: On 09/10/2012 01:37 PM, Mike Waychison wrote: On Mon, Sep 10, 2012 at 5:05 AM, Michael S. Tsirkin m...@redhat.com wrote: Also can you pls answer Avi's question? How is overcommit managed? Overcommit in our deployments

Re: [PATCHv4] virtio-spec: virtio network device multiqueue support

2012-09-10 Thread Rick Jones
On 09/09/2012 07:12 PM, Rusty Russell wrote: OK, I read the spec (pasted below for easy of reading), but I'm still confused over how this will work. I thought normal net drivers have the hardware provide an rxhash for each packet, and we map that to CPU to queue the packet on[1]. We hope that

Re: [PATCH] Add a page cache-backed balloon device driver.

2012-09-10 Thread Mike Waychison
On Mon, Sep 10, 2012 at 3:59 PM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Sep 10, 2012 at 01:37:06PM -0400, Mike Waychison wrote: On Mon, Sep 10, 2012 at 5:05 AM, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Jun 26, 2012 at 01:32:58PM -0700, Frank Swiderski wrote: This

Re: [PATCH] Add a page cache-backed balloon device driver.

2012-09-10 Thread Michael S. Tsirkin
On Mon, Sep 10, 2012 at 04:49:40PM -0400, Mike Waychison wrote: On Mon, Sep 10, 2012 at 3:59 PM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Sep 10, 2012 at 01:37:06PM -0400, Mike Waychison wrote: On Mon, Sep 10, 2012 at 5:05 AM, Michael S. Tsirkin m...@redhat.com wrote: On Tue,

Re: [RFC 1/2] virtio_console: Add support for DMA memory allocation

2012-09-10 Thread Michael S. Tsirkin
On Thu, Sep 06, 2012 at 08:27:35AM +0300, Michael S. Tsirkin wrote: On Thu, Sep 06, 2012 at 11:34:25AM +0930, Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: On Tue, Sep 04, 2012 at 06:58:47PM +0200, Sjur Brændeland wrote: Hi Michael, Exactly. Though if we just

Re: [patch 1/3] xen/privcmd: check for integer overflow in ioctl

2012-09-10 Thread Andres Lagar-Cavilla
On Sep 8, 2012, at 5:52 AM, Dan Carpenter wrote: If m.num is too large then the m.num * sizeof(*m.arr) multiplication could overflow and the access_ok() check wouldn't test the right size. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Acked-by: Andres Lagar-Cavilla

Re: [patch 2/3] xen/privcmd: return -EFAULT on error

2012-09-10 Thread Andres Lagar-Cavilla
On Sep 8, 2012, at 5:57 AM, Dan Carpenter wrote: __copy_to_user() returns the number of bytes remaining to be copied but we want to return a negative error code here. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Acked-by: Andres Lagar-Cavilla and...@lagarcavilla.org diff --git

Re: [patch 3/3] xen/privcmd: remove const modifier from declaration

2012-09-10 Thread Andres Lagar-Cavilla
On Sep 8, 2012, at 5:58 AM, Dan Carpenter wrote: When we use this pointer, we cast away the const modifier and modify the data. I think it was an accident to declare it as const. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Acked-by: Andres Lagar-Cavilla and...@lagarcavilla.org

Re: [Xen-devel] [patch 1/3] xen/privcmd: check for integer overflow in ioctl

2012-09-10 Thread David Vrabel
On 08/09/12 10:52, Dan Carpenter wrote: If m.num is too large then the m.num * sizeof(*m.arr) multiplication could overflow and the access_ok() check wouldn't test the right size. m.num is range checked later on so it doesn't matter that the access_ok() checks might be wrong. A bit subtle,

Re: [Xen-devel] [patch 3/3] xen/privcmd: remove const modifier from declaration

2012-09-10 Thread David Vrabel
On 10/09/12 10:03, Jan Beulich wrote: On 08.09.12 at 11:58, Dan Carpenter dan.carpen...@oracle.com wrote: When we use this pointer, we cast away the const modifier and modify the data. I think it was an accident to declare it as const. NAK - the const is very valid here, as the v2 interface

Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2012-09-10 Thread Asias He
Hello Nicholas, On 09/07/2012 02:48 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hello Anthony Co, This is the fourth installment to add host virtualized target support for the mainline tcm_vhost fabric driver using Linux v3.6-rc into QEMU 1.3.0-rc.