Re: [PATCH 3/3] virtio_ring: unify direct/indirect code paths.

2014-09-04 Thread Rusty Russell
Andy Lutomirski writes: > On Tue, Sep 2, 2014 at 9:29 PM, Rusty Russell wrote: >> virtqueue_add() populates the virtqueue descriptor table from the sgs >> given. If it uses an indirect descriptor table, then it puts a single >> descriptor in the descriptor table pointing to the kmalloc'ed indire

Re: [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2014-09-04 Thread Benjamin Herrenschmidt
On Thu, 2014-09-04 at 19:57 -0700, Andy Lutomirski wrote: > There's a third option: try to make virtio-mmio work everywhere > (except s390), at least in the long run. This other benefits: it > makes minimal hypervisors simpler, I think it'll get rid of the limits > on the number of virtio devices

Re: [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2014-09-04 Thread Benjamin Herrenschmidt
On Fri, 2014-09-05 at 12:01 +0930, Rusty Russell wrote: > If the answers are both "yes", then x86 is going to be able to use > virtio+IOMMU, so PPC looks like the odd one out. Well, yes and no ... ppc will be able to do that too, it's just pointless and will suck performances. Additionally, it w

[PATCH] virtio: pci: Use SIMPLE_DEV_PM_OPS macro

2014-09-04 Thread Jingoo Han
Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler. Signed-off-by: Jingoo Han --- drivers/virtio/virtio_pci.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index 3d1463c6b120..c5fbdb4023d1 100644

Re: [PATCH 1/1] add selftest for virtio-net v1.0

2014-09-04 Thread Jason Wang
On 09/05/2014 09:51 AM, Hengjinxiao wrote: > Selftest is an important part of network driver, this patch adds > selftest for > virtio-net, including loopback test, negotiate test and reset test. Loopback > test checks whether virtio-net can send and receive packets normally. > Negotiate te

Re: [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2014-09-04 Thread Andy Lutomirski
On Thu, Sep 4, 2014 at 7:32 PM, Rusty Russell wrote: > "Michael S. Tsirkin" writes: >> On Wed, Sep 03, 2014 at 04:12:01PM +0930, Rusty Russell wrote: >>> Andy Lutomirski writes: >>> > There really are virtio devices that are pieces of silicon and not >>> > figments of a hypervisor's imagination

Re: [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2014-09-04 Thread Andy Lutomirski
On Thu, Sep 4, 2014 at 7:31 PM, Rusty Russell wrote: > Andy Lutomirski writes: >> On Sep 2, 2014 11:53 PM, "Rusty Russell" wrote: >>> >>> Andy Lutomirski writes: >>> > There really are virtio devices that are pieces of silicon and not >>> > figments of a hypervisor's imagination [1]. >>> >>> Hi

Re: [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2014-09-04 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Wed, Sep 03, 2014 at 04:12:01PM +0930, Rusty Russell wrote: >> Andy Lutomirski writes: >> > There really are virtio devices that are pieces of silicon and not >> > figments of a hypervisor's imagination [1]. >> >> Hi Andy, >> >> As you're discovering, t

Re: [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2014-09-04 Thread Rusty Russell
Andy Lutomirski writes: > On Sep 2, 2014 11:53 PM, "Rusty Russell" wrote: >> >> Andy Lutomirski writes: >> > There really are virtio devices that are pieces of silicon and not >> > figments of a hypervisor's imagination [1]. >> >> Hi Andy, >> >> As you're discovering, there's a reason no

[PATCH 1/1] add selftest for virtio-net v1.0

2014-09-04 Thread Hengjinxiao
Selftest is an important part of network driver, this patch adds selftest for virtio-net, including loopback test, negotiate test and reset test. Loopback test checks whether virtio-net can send and receive packets normally. Negotiate test executes feature negotiation between virtio-net