Re: [RFC PATCH 04/12] s390/cio: introduce cio DMA pool

2019-04-19 Thread Sebastian Ott
On Fri, 12 Apr 2019, Halil Pasic wrote: > On Fri, 12 Apr 2019 14:12:31 +0200 (CEST) > Sebastian Ott wrote: > > On Fri, 12 Apr 2019, Halil Pasic wrote: > > > On Thu, 11 Apr 2019 20:25:01 +0200 (CEST) > > > Sebastian Ott wrote: > > > > I don't think we should use this global DMA pool. I guess it's

Re: [PATCH v3 09/26] compat_ioctl: move drivers to compat_ptr_ioctl

2019-04-19 Thread Jiri Kosina
On Tue, 16 Apr 2019, Arnd Bergmann wrote: > Each of these drivers has a copy of the same trivial helper function to > convert the pointer argument and then call the native ioctl handler. > > We now have a generic implementation of that, so use it. > > Acked-by: Greg Kroah-Hartman > Reviewed-by:

Re: [PATCH 3/3] virtio-gpu api: VIRTIO_GPU_F_RESSOURCE_V2

2019-04-19 Thread Chia-I Wu
On Wed, Apr 17, 2019 at 2:57 AM Gerd Hoffmann wrote: > > On Fri, Apr 12, 2019 at 04:34:20PM -0700, Chia-I Wu wrote: > > Hi, > > > > I am still new to virgl, and missed the last round of discussion about > > resource_create_v2. > > > > From the discussion below, semantically resource_create_v2 crea

Re: [RFC 0/3] VirtIO RDMA

2019-04-19 Thread Yuval Shaia
On Thu, Apr 11, 2019 at 07:02:15PM +0200, Cornelia Huck wrote: > On Thu, 11 Apr 2019 14:01:54 +0300 > Yuval Shaia wrote: > > > Data center backends use more and more RDMA or RoCE devices and more and > > more software runs in virtualized environment. > > There is a need for a standard to enable R

Re: [Qemu-devel] [RFC 0/3] VirtIO RDMA

2019-04-19 Thread Yuval Shaia
On Fri, Apr 12, 2019 at 03:21:56PM +0530, Devesh Sharma wrote: > On Thu, Apr 11, 2019 at 11:11 PM Yuval Shaia wrote: > > > > On Thu, Apr 11, 2019 at 08:34:20PM +0300, Yuval Shaia wrote: > > > On Thu, Apr 11, 2019 at 05:24:08PM +, Jason Gunthorpe wrote: > > > > On Thu, Apr 11, 2019 at 07:02:15P

Re: [Qemu-devel] [RFC 3/3] RDMA/virtio-rdma: VirtIO rdma driver

2019-04-19 Thread Yuval Shaia
On Mon, Apr 15, 2019 at 06:07:52PM -0700, Bart Van Assche wrote: > On 4/11/19 4:01 AM, Yuval Shaia wrote: > > +++ b/drivers/infiniband/hw/virtio/Kconfig > > @@ -0,0 +1,6 @@ > > +config INFINIBAND_VIRTIO_RDMA > > + tristate "VirtIO Paravirtualized RDMA Driver" > > + depends on NETDEVICES && ETHE

Re: [RFC 0/3] VirtIO RDMA

2019-04-19 Thread Yuval Shaia
On Thu, Apr 11, 2019 at 05:40:26PM +, Jason Gunthorpe wrote: > On Thu, Apr 11, 2019 at 08:34:20PM +0300, Yuval Shaia wrote: > > On Thu, Apr 11, 2019 at 05:24:08PM +, Jason Gunthorpe wrote: > > > On Thu, Apr 11, 2019 at 07:02:15PM +0200, Cornelia Huck wrote: > > > > On Thu, 11 Apr 2019 14:01

Re: [RFC 3/3] RDMA/virtio-rdma: VirtIO rdma driver

2019-04-19 Thread Yuval Shaia
> > + > > + wake_up(&dev->acked); > > + > > + printk("%s\n", __func__); > > Cool:-) > > this line should be for debug? Yes > > Zhu Yanjun > ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.o

Re: [PATCH 3/3] virtio-gpu api: VIRTIO_GPU_F_RESSOURCE_V2

2019-04-19 Thread Chia-I Wu
Hi, I am still new to virgl, and missed the last round of discussion about resource_create_v2. >From the discussion below, semantically resource_create_v2 creates a host resource object _without_ any storage; memory_create creates a host memory object which provides the storage. Is that correct?

Re: [RFC 3/3] RDMA/virtio-rdma: VirtIO rdma driver

2019-04-19 Thread Yanjun Zhu
On 2019/4/11 19:01, Yuval Shaia wrote: Signed-off-by: Yuval Shaia --- drivers/infiniband/Kconfig| 1 + drivers/infiniband/hw/Makefile| 1 + drivers/infiniband/hw/virtio/Kconfig | 6 + drivers/infiniband/hw/virtio/Makefile | 4 +

Re: [RFC 0/3] VirtIO RDMA

2019-04-19 Thread Jason Gunthorpe
On Thu, Apr 11, 2019 at 08:34:20PM +0300, Yuval Shaia wrote: > On Thu, Apr 11, 2019 at 05:24:08PM +, Jason Gunthorpe wrote: > > On Thu, Apr 11, 2019 at 07:02:15PM +0200, Cornelia Huck wrote: > > > On Thu, 11 Apr 2019 14:01:54 +0300 > > > Yuval Shaia wrote: > > > > > > > Data center backends u

Re: [Qemu-devel] [RFC 0/3] VirtIO RDMA

2019-04-19 Thread Yuval Shaia
On Thu, Apr 11, 2019 at 08:34:20PM +0300, Yuval Shaia wrote: > On Thu, Apr 11, 2019 at 05:24:08PM +, Jason Gunthorpe wrote: > > On Thu, Apr 11, 2019 at 07:02:15PM +0200, Cornelia Huck wrote: > > > On Thu, 11 Apr 2019 14:01:54 +0300 > > > Yuval Shaia wrote: > > > > > > > Data center backends u

Re: [RFC PATCH 04/12] s390/cio: introduce cio DMA pool

2019-04-19 Thread Sebastian Ott
On Fri, 12 Apr 2019, Halil Pasic wrote: > On Thu, 11 Apr 2019 20:25:01 +0200 (CEST) > Sebastian Ott wrote: > > I don't think we should use this global DMA pool. I guess it's OK for > > stuff like airq (where we don't have a struct device at hand) but for > > CCW we should use the device we have. Y

Re: [RFC PATCH 04/12] s390/cio: introduce cio DMA pool

2019-04-19 Thread Sebastian Ott
On Fri, 5 Apr 2019, Halil Pasic wrote: > To support protected virtualization cio will need to make sure the > memory used for communication with the hypervisor is DMA memory. > > Let us introduce a DMA pool to cio that will help us in allocating > deallocating those chunks of memory. > > We use a

Re: [RFC 0/3] VirtIO RDMA

2019-04-19 Thread Jason Gunthorpe
On Thu, Apr 11, 2019 at 07:02:15PM +0200, Cornelia Huck wrote: > On Thu, 11 Apr 2019 14:01:54 +0300 > Yuval Shaia wrote: > > > Data center backends use more and more RDMA or RoCE devices and more and > > more software runs in virtualized environment. > > There is a need for a standard to enable R

Re: [RFC 0/3] VirtIO RDMA

2019-04-19 Thread Yuval Shaia
On Thu, Apr 11, 2019 at 05:24:08PM +, Jason Gunthorpe wrote: > On Thu, Apr 11, 2019 at 07:02:15PM +0200, Cornelia Huck wrote: > > On Thu, 11 Apr 2019 14:01:54 +0300 > > Yuval Shaia wrote: > > > > > Data center backends use more and more RDMA or RoCE devices and more and > > > more software ru

[RFC 3/3] RDMA/virtio-rdma: VirtIO rdma driver

2019-04-19 Thread Yuval Shaia
Signed-off-by: Yuval Shaia --- drivers/infiniband/Kconfig| 1 + drivers/infiniband/hw/Makefile| 1 + drivers/infiniband/hw/virtio/Kconfig | 6 + drivers/infiniband/hw/virtio/Makefile | 4 + drivers/infiniband/hw/virtio/virtio_rdma.h

Re: [RFC PATCH 05/12] s390/cio: add protected virtualization support to cio

2019-04-19 Thread Sebastian Ott
On Fri, 5 Apr 2019, Halil Pasic wrote: > @@ -1593,20 +1609,29 @@ struct ccw_device * __init > ccw_device_create_console(struct ccw_driver *drv) > return ERR_CAST(sch); > > io_priv = kzalloc(sizeof(*io_priv), GFP_KERNEL | GFP_DMA); > - if (!io_priv) { > - put_d

[RFC 2/3] hw/virtio-rdma: VirtIO rdma device

2019-04-19 Thread Yuval Shaia
Signed-off-by: Yuval Shaia --- hw/Kconfig | 1 + hw/rdma/Kconfig | 4 + hw/rdma/Makefile.objs | 2 + hw/rdma/virtio/virtio-rdma-ib.c | 287 hw/rdma/virtio/virtio-rdma-ib.h

Re: [PATCH v5 2/5] virtio-pmem: Add virtio pmem driver

2019-04-19 Thread Yuval Shaia
> + > +static int virtio_pmem_probe(struct virtio_device *vdev) > +{ > + int err = 0; > + struct resource res; > + struct virtio_pmem *vpmem; > + struct nvdimm_bus *nvdimm_bus; > + struct nd_region_desc ndr_desc = {}; > + int nid = dev_to_node(&vdev->dev); > + struct nd_

[RFC 0/3] VirtIO RDMA

2019-04-19 Thread Yuval Shaia
Data center backends use more and more RDMA or RoCE devices and more and more software runs in virtualized environment. There is a need for a standard to enable RDMA/RoCE on Virtual Machines. Virtio is the optimal solution since is the de-facto para-virtualizaton technology and also because the Vi

[RFC 1/3] virtio-net: Move some virtio-net-pci decl to include/hw/virtio

2019-04-19 Thread Yuval Shaia
Signed-off-by: Yuval Shaia --- hw/virtio/virtio-net-pci.c | 18 ++- include/hw/virtio/virtio-net-pci.h | 35 ++ 2 files changed, 37 insertions(+), 16 deletions(-) create mode 100644 include/hw/virtio/virtio-net-pci.h diff --git a/hw/virtio/virtio-

Re: [PATCH v5 2/5] virtio-pmem: Add virtio pmem driver

2019-04-19 Thread Yuval Shaia
On Wed, Apr 10, 2019 at 02:24:26PM +0200, Cornelia Huck wrote: > On Wed, 10 Apr 2019 09:38:22 +0530 > Pankaj Gupta wrote: > > > This patch adds virtio-pmem driver for KVM guest. > > > > Guest reads the persistent memory range information from > > Qemu over VIRTIO and registers it on nvdimm_bus.

Re: [PATCH v5 0/6] virtio pmem driver

2019-04-19 Thread Arkadiusz Miśkiewicz
On 10/04/2019 06:08, Pankaj Gupta wrote: > This patch series has implementation for "virtio pmem". > "virtio pmem" is fake persistent memory(nvdimm) in guest > which allows to bypass the guest page cache. This also Will kernel pstore be able to use this persistent memory for storing crash dum

Re: [PATCH RFC 0/4] vsock/virtio: optimizations to increase the throughput

2019-04-19 Thread Stefano Garzarella
On Mon, Apr 08, 2019 at 02:43:28PM +0800, Jason Wang wrote: > > On 2019/4/4 下午6:58, Stefano Garzarella wrote: > > This series tries to increase the throughput of virtio-vsock with slight > > changes: > > - patch 1/4: reduces the number of credit update messages sent to the > >tra

Re: [PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed

2019-04-19 Thread Stefano Garzarella
On Mon, Apr 08, 2019 at 10:57:44AM -0400, Michael S. Tsirkin wrote: > On Mon, Apr 08, 2019 at 04:55:31PM +0200, Stefano Garzarella wrote: > > > Anyway, any change to this behavior requires compatibility so new guest > > > drivers work with old vhost_vsock.ko. Therefore we should probably just > >

Re: [PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed

2019-04-19 Thread Stefano Garzarella
On Fri, Apr 05, 2019 at 09:24:47AM +0100, Stefan Hajnoczi wrote: > On Thu, Apr 04, 2019 at 12:58:37PM +0200, Stefano Garzarella wrote: > > Since now we are able to split packets, we can avoid limiting > > their sizes to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE. > > Instead, we can use VIRTIO_VSOCK_MAX_PKT_

Re: [PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed

2019-04-19 Thread Stefano Garzarella
On Mon, Apr 08, 2019 at 10:37:23AM +0100, Stefan Hajnoczi wrote: > On Fri, Apr 05, 2019 at 12:07:47PM +0200, Stefano Garzarella wrote: > > On Fri, Apr 05, 2019 at 09:24:47AM +0100, Stefan Hajnoczi wrote: > > > On Thu, Apr 04, 2019 at 12:58:37PM +0200, Stefano Garzarella wrote: > > > > Since now we

Re: [PATCH] drm/qxl: drop prime import/export callbacks

2019-04-19 Thread David Airlie
On Tue, Apr 9, 2019 at 4:03 PM Gerd Hoffmann wrote: > > On Tue, Apr 09, 2019 at 02:01:33PM +1000, Dave Airlie wrote: > > On Sat, 12 Jan 2019 at 07:13, Dave Airlie wrote: > > > > > > On Thu, 10 Jan 2019 at 18:17, Gerd Hoffmann wrote: > > > > > > > > Also set prime_handle_to_fd and prime_fd_to_han

Re: [PATCH RFC 2/4] vhost/vsock: split packets to send using multiple buffers

2019-04-19 Thread Stefano Garzarella
On Fri, Apr 05, 2019 at 09:13:56AM +0100, Stefan Hajnoczi wrote: > On Thu, Apr 04, 2019 at 12:58:36PM +0200, Stefano Garzarella wrote: > > @@ -139,8 +139,18 @@ vhost_transport_do_send_pkt(struct vhost_vsock *vsock, > > break; > > } > > > > - len = iov_len

Re: [PATCH RFC 0/4] vsock/virtio: optimizations to increase the throughput

2019-04-19 Thread Stefano Garzarella
On Thu, Apr 04, 2019 at 02:04:10PM -0400, Michael S. Tsirkin wrote: > On Thu, Apr 04, 2019 at 06:47:15PM +0200, Stefano Garzarella wrote: > > On Thu, Apr 04, 2019 at 11:52:46AM -0400, Michael S. Tsirkin wrote: > > > I simply love it that you have analysed the individual impact of > > > each patch!

Re: [PATCH] drm/virtio: move drm_connector_update_edid_property() call

2019-04-19 Thread Max Filippov
On Thu, Apr 4, 2019 at 9:46 PM Gerd Hoffmann wrote: > > drm_connector_update_edid_property can sleep, we must not > call it while holding a spinlock. Move the callsize. > > Reported-by: Max Filippov > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/virtio/virtgpu_vq.c | 2 +- > 1 file cha

Re: [PATCH RFC 1/4] vsock/virtio: reduce credit update messages

2019-04-19 Thread Stefano Garzarella
On Thu, Apr 04, 2019 at 08:15:39PM +0100, Stefan Hajnoczi wrote: > On Thu, Apr 04, 2019 at 12:58:35PM +0200, Stefano Garzarella wrote: > > @@ -256,6 +257,7 @@ virtio_transport_stream_do_dequeue(struct vsock_sock > > *vsk, > > struct virtio_vsock_sock *vvs = vsk->trans; > > struct virtio_vs

Re: [PATCH RFC 0/4] vsock/virtio: optimizations to increase the throughput

2019-04-19 Thread Stefano Garzarella
On Thu, Apr 04, 2019 at 03:14:10PM +0100, Stefan Hajnoczi wrote: > On Thu, Apr 04, 2019 at 12:58:34PM +0200, Stefano Garzarella wrote: > > This series tries to increase the throughput of virtio-vsock with slight > > changes: > > - patch 1/4: reduces the number of credit update messages sent to the

Re: [PATCH RFC 0/4] vsock/virtio: optimizations to increase the throughput

2019-04-19 Thread Stefano Garzarella
On Thu, Apr 04, 2019 at 11:52:46AM -0400, Michael S. Tsirkin wrote: > I simply love it that you have analysed the individual impact of > each patch! Great job! Thanks! I followed Stefan's suggestions! > > For comparison's sake, it could be IMHO benefitial to add a column > with virtio-net+vhost-

[PATCH RFC 4/4] vsock/virtio: increase RX buffer size to 64 KiB

2019-04-19 Thread Stefano Garzarella
In order to increase host -> guest throughput with large packets, we can use 64 KiB RX buffers. Signed-off-by: Stefano Garzarella --- include/linux/virtio_vsock.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h index

[PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed

2019-04-19 Thread Stefano Garzarella
Since now we are able to split packets, we can avoid limiting their sizes to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE. Instead, we can use VIRTIO_VSOCK_MAX_PKT_BUF_SIZE as the max packet size. Signed-off-by: Stefano Garzarella --- net/vmw_vsock/virtio_transport_common.c | 4 ++-- 1 file changed, 2 inser

[PATCH RFC 2/4] vhost/vsock: split packets to send using multiple buffers

2019-04-19 Thread Stefano Garzarella
If the packets to sent to the guest are bigger than the buffer available, we can split them, using multiple buffers and fixing the length in the packet header. This is safe since virtio-vsock supports only stream sockets. Signed-off-by: Stefano Garzarella --- drivers/vhost/vsock.c | 35 +

Re: [Qemu-devel] [PATCH v4 5/5] xfs: disable map_sync for async flush

2019-04-19 Thread Darrick J. Wong
On Thu, Apr 04, 2019 at 06:08:44AM -0400, Pankaj Gupta wrote: > > > On Thu 04-04-19 05:09:10, Pankaj Gupta wrote: > > > > > > > > On Thu, Apr 04, 2019 at 09:09:12AM +1100, Dave Chinner wrote: > > > > > > On Wed, Apr 03, 2019 at 04:10:18PM +0530, Pankaj Gupta wrote: > > > > > > > Virtio pmem provi

[PATCH RFC 1/4] vsock/virtio: reduce credit update messages

2019-04-19 Thread Stefano Garzarella
In order to reduce the number of credit update messages, we send them only when the space available seen by the transmitter is less than VIRTIO_VSOCK_MAX_PKT_BUF_SIZE. Signed-off-by: Stefano Garzarella --- include/linux/virtio_vsock.h| 1 + net/vmw_vsock/virtio_transport_common.c |

[PATCH RFC 0/4] vsock/virtio: optimizations to increase the throughput

2019-04-19 Thread Stefano Garzarella
This series tries to increase the throughput of virtio-vsock with slight changes: - patch 1/4: reduces the number of credit update messages sent to the transmitter - patch 2/4: allows the host to split packets on multiple buffers, in this way, we can remove the packet

Re: [PATCH] drm/cirrus: rewrite and modernize driver.

2019-04-19 Thread Stéphane Marchesin
On Wed, Apr 3, 2019 at 7:58 PM David Airlie wrote: > On Wed, Apr 3, 2019 at 5:23 PM Gerd Hoffmann wrote: > > > > Time to kill some bad sample code people are copying from ;) > > > > This is a complete rewrite of the cirrus driver. The cirrus_mode_set() > > function is pretty much the only funct

Re: [PATCH v4 5/5] xfs: disable map_sync for async flush

2019-04-19 Thread Adam Borowski
On Thu, Apr 04, 2019 at 02:12:30AM -0400, Pankaj Gupta wrote: > > All this ad hoc IS_DAX conditional logic is getting pretty nasty. > > > > xfs_file_mmap( > > > > { > > struct inode*inode = file_inode(filp); > > > > if (vma->vm_flags & VM_SYNC) { > > if (!IS_DAX(inode

Re: [Qemu-devel] [PATCH v4 2/5] virtio-pmem: Add virtio pmem driver

2019-04-19 Thread Yuval Shaia
On Wed, Apr 03, 2019 at 08:40:13AM -0400, Pankaj Gupta wrote: > > > Subject: Re: [Qemu-devel] [PATCH v4 2/5] virtio-pmem: Add virtio pmem driver > > > > On Wed, Apr 03, 2019 at 04:10:15PM +0530, Pankaj Gupta wrote: > > > This patch adds virtio-pmem driver for KVM guest. > > > > > > Guest reads t

Re: [Qemu-devel] [PATCH v4 2/5] virtio-pmem: Add virtio pmem driver

2019-04-19 Thread Yuval Shaia
On Wed, Apr 03, 2019 at 04:10:15PM +0530, Pankaj Gupta wrote: > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information from > Qemu over VIRTIO and registers it on nvdimm_bus. It also > creates a nd_region object with the persistent memory > range

Re: [PATCH] drm/cirrus: rewrite and modernize driver.

2019-04-19 Thread David Airlie
On Wed, Apr 3, 2019 at 5:23 PM Gerd Hoffmann wrote: > > Time to kill some bad sample code people are copying from ;) > > This is a complete rewrite of the cirrus driver. The cirrus_mode_set() > function is pretty much the only function which is carried over largely > unmodified. Everything else

Re: [PATCH v4 5/5] xfs: disable map_sync for async flush

2019-04-19 Thread Darrick J. Wong
On Thu, Apr 04, 2019 at 09:09:12AM +1100, Dave Chinner wrote: > On Wed, Apr 03, 2019 at 04:10:18PM +0530, Pankaj Gupta wrote: > > Virtio pmem provides asynchronous host page cache flush > > mechanism. we don't support 'MAP_SYNC' with virtio pmem > > and xfs. > > > > Signed-off-by: Pankaj Gupta >

[PATCH] virtio: Fix indentation of VIRTIO_MMIO

2019-04-19 Thread Fabrizio Castro
VIRTIO_MMIO config option block starts with a space, fix that. Signed-off-by: Fabrizio Castro --- drivers/virtio/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index 3589764..1b5c9f0 100644 --- a/drivers/virtio/

[PATCH] virtio-net: Remove inclusion of pci.h

2019-04-19 Thread Yuval Shaia
This header is not in use - remove it. Signed-off-by: Yuval Shaia --- drivers/net/virtio_net.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 7eb38ea9ba56..07c1e81087b2 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_ne

[PATCH] virtio-net: Fix some minor formatting errors

2019-04-19 Thread Yuval Shaia
Signed-off-by: Yuval Shaia --- drivers/net/virtio_net.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 07c1e81087b2..be1188815c72 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -1587

Re: [PATCH v2 -next] drm/virtio: remove set but not used variable 'vgdev'

2019-04-19 Thread Mukesh Ojha
On 3/25/2019 2:56 PM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_init_mem_type': drivers/gpu/drm/virtio/virtgpu_ttm.c:117:28: warning: variable 'vgdev' set but not used [-Wunused-but-set-variable] drivers/gp

Re: [PATCH v2 -next] drm/virtio: remove set but not used variable 'vgdev'

2019-04-19 Thread Mukesh Ojha
On 3/25/2019 2:56 PM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_init_mem_type': drivers/gpu/drm/virtio/virtgpu_ttm.c:117:28: warning: variable 'vgdev' set but not used [-Wunused-but-set-variable] drivers/gpu

Re: [PATCH 1/3] drm/virtio: add missing drm_atomic_helper_shutdown() call.

2019-04-19 Thread Mukesh Ojha
Please atleast mention here why it is required? -Mukesh On 4/1/2019 7:33 PM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 19:12, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 06:31:35PM +0200, Liran Alon wrote: >> >> >>> On 21 Mar 2019, at 17:50, Michael S. Tsirkin wrote: >>> >>> On Thu, Mar 21, 2019 at 08:45:17AM -0700, Stephen Hemminger wrote: On Thu, 21 Mar 2019 15:04:37 +0

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 15:51, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 03:24:39PM +0200, Liran Alon wrote: >> >> >>> On 21 Mar 2019, at 15:12, Michael S. Tsirkin wrote: >>> >>> On Thu, Mar 21, 2019 at 03:04:37PM +0200, Liran Alon wrote: > On 21 Mar 2019, at 14:57,

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 17:50, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 08:45:17AM -0700, Stephen Hemminger wrote: >> On Thu, 21 Mar 2019 15:04:37 +0200 >> Liran Alon wrote: >> OK. Now what happens if master is moved to another namespace? Do we need to move the slave

Re: [PATCH net v2] failover: allow name change on IFF_UP slave interfaces

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 16:04, Michael S. Tsirkin wrote: > > On Wed, Mar 06, 2019 at 10:08:32PM -0500, Si-Wei Liu wrote: >> When a netdev appears through hot plug then gets enslaved by a failover >> master that is already up and running, the slave will be opened >> right away after getting enslave

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 15:12, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 03:04:37PM +0200, Liran Alon wrote: >> >> >>> On 21 Mar 2019, at 14:57, Michael S. Tsirkin wrote: >>> >>> On Thu, Mar 21, 2019 at 02:47:50PM +0200, Liran Alon wrote: > On 21 Mar 2019, at 14:37,

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 14:57, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 02:47:50PM +0200, Liran Alon wrote: >> >> >>> On 21 Mar 2019, at 14:37, Michael S. Tsirkin wrote: >>> >>> On Thu, Mar 21, 2019 at 12:07:57PM +0200, Liran Alon wrote: 2) It brings non-intuitive custome

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 14:37, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 12:07:57PM +0200, Liran Alon wrote: >> 2) It brings non-intuitive customer experience. For example, a customer >> may attempt to analyse connectivity issue by checking the connectivity >> on a net-fai

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 0:10, Michael S. Tsirkin wrote: > > On Wed, Mar 20, 2019 at 11:43:41PM +0200, Liran Alon wrote: >> >> >>> On 20 Mar 2019, at 16:09, Michael S. Tsirkin wrote: >>> >>> On Wed, Mar 20, 2019 at 02:23:36PM +0200, Liran Alon wrote: > On 20 Mar 2019, at 12:25,

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 21 Mar 2019, at 10:58, Michael S. Tsirkin wrote: > > On Thu, Mar 21, 2019 at 12:19:22AM +0200, Liran Alon wrote: >> >> >>> On 21 Mar 2019, at 0:10, Michael S. Tsirkin wrote: >>> >>> On Wed, Mar 20, 2019 at 11:43:41PM +0200, Liran Alon wrote: > On 20 Mar 2019, at 16:09,

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 20 Mar 2019, at 12:25, Michael S. Tsirkin wrote: > > On Wed, Mar 20, 2019 at 01:25:58AM +0200, Liran Alon wrote: >> >> >>> On 19 Mar 2019, at 23:19, Michael S. Tsirkin wrote: >>> >>> On Tue, Mar 19, 2019 at 08:46:47AM -0700, Stephen Hemminger wrote: On Tue, 19 Mar 2019 14:38:06 +0

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 19 Mar 2019, at 23:19, Michael S. Tsirkin wrote: > > On Tue, Mar 19, 2019 at 08:46:47AM -0700, Stephen Hemminger wrote: >> On Tue, 19 Mar 2019 14:38:06 +0200 >> Liran Alon wrote: >> >>> b.3) cloud-init: If configured to perform network-configuration, it >>> attempts to configure all ava

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 20 Mar 2019, at 16:09, Michael S. Tsirkin wrote: > > On Wed, Mar 20, 2019 at 02:23:36PM +0200, Liran Alon wrote: >> >> >>> On 20 Mar 2019, at 12:25, Michael S. Tsirkin wrote: >>> >>> On Wed, Mar 20, 2019 at 01:25:58AM +0200, Liran Alon wrote: > On 19 Mar 2019, at 23:19,

Re: [RFC PATCH V2 5/5] vhost: access vq metadata through kernel virtual address

2019-04-19 Thread Jerome Glisse
On Fri, Mar 08, 2019 at 04:50:36PM +0800, Jason Wang wrote: > > On 2019/3/8 上午3:16, Andrea Arcangeli wrote: > > On Thu, Mar 07, 2019 at 12:56:45PM -0500, Michael S. Tsirkin wrote: > > > On Thu, Mar 07, 2019 at 10:47:22AM -0500, Michael S. Tsirkin wrote: > > > > On Wed, Mar 06, 2019 at 02:18:12AM -

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
Hi Michael, Great blog-post which summarise everything very well! Some comments I have: 1) I think that when we are using the term “1-netdev model” on community discussion, we tend to refer to what you have defined in blog-post as "3-device model with hidden slaves”. Therefore, I would suggest

Re: [summary] virtio network device failover writeup

2019-04-19 Thread Liran Alon
> On 19 Mar 2019, at 23:06, Michael S. Tsirkin wrote: > > On Tue, Mar 19, 2019 at 02:38:06PM +0200, Liran Alon wrote: >> Hi Michael, >> >> Great blog-post which summarise everything very well! >> >> Some comments I have: > > Thanks! > I'll try to update everything in the post when I'm not so

Re: [RFC PATCH V2 5/5] vhost: access vq metadata through kernel virtual address

2019-04-19 Thread Jerome Glisse
On Fri, Mar 08, 2019 at 07:56:04AM -0500, Michael S. Tsirkin wrote: > On Fri, Mar 08, 2019 at 04:58:44PM +0800, Jason Wang wrote: > > > > On 2019/3/8 上午3:17, Jerome Glisse wrote: > > > On Thu, Mar 07, 2019 at 12:56:45PM -0500, Michael S. Tsirkin wrote: > > > > On Thu, Mar 07, 2019 at 10:47:22AM -0

Re: [RFC PATCH V2 5/5] vhost: access vq metadata through kernel virtual address

2019-04-19 Thread Jerome Glisse
On Fri, Mar 08, 2019 at 02:48:45PM -0500, Andrea Arcangeli wrote: > Hello Jeson, > > On Fri, Mar 08, 2019 at 04:50:36PM +0800, Jason Wang wrote: > > Just to make sure I understand here. For boosting through huge TLB, do > > you mean we can do that in the future (e.g by mapping more userspace > >

Re: [RFC PATCH V2 5/5] vhost: access vq metadata through kernel virtual address

2019-04-19 Thread Jerome Glisse
On Thu, Mar 07, 2019 at 10:43:12PM -0500, Michael S. Tsirkin wrote: > On Thu, Mar 07, 2019 at 10:40:53PM -0500, Jerome Glisse wrote: > > On Thu, Mar 07, 2019 at 10:16:00PM -0500, Michael S. Tsirkin wrote: > > > On Thu, Mar 07, 2019 at 09:55:39PM -0500, Jerome Glisse wrote: > > > > On Thu, Mar 07, 2

Re: [RFC PATCH V2 5/5] vhost: access vq metadata through kernel virtual address

2019-04-19 Thread Jerome Glisse
On Thu, Mar 07, 2019 at 09:21:03PM -0500, Michael S. Tsirkin wrote: > On Thu, Mar 07, 2019 at 02:17:20PM -0500, Jerome Glisse wrote: > > > It's because of all these issues that I preferred just accessing > > > userspace memory and handling faults. Unfortunately there does not > > > appear to exist

Re: [RFC PATCH V2 5/5] vhost: access vq metadata through kernel virtual address

2019-04-19 Thread Jerome Glisse
On Thu, Mar 07, 2019 at 10:16:00PM -0500, Michael S. Tsirkin wrote: > On Thu, Mar 07, 2019 at 09:55:39PM -0500, Jerome Glisse wrote: > > On Thu, Mar 07, 2019 at 09:21:03PM -0500, Michael S. Tsirkin wrote: > > > On Thu, Mar 07, 2019 at 02:17:20PM -0500, Jerome Glisse wrote: > > > > > It's because of

Re: [RFC PATCH V2 5/5] vhost: access vq metadata through kernel virtual address

2019-04-19 Thread Jerome Glisse
On Thu, Mar 07, 2019 at 12:56:45PM -0500, Michael S. Tsirkin wrote: > On Thu, Mar 07, 2019 at 10:47:22AM -0500, Michael S. Tsirkin wrote: > > On Wed, Mar 06, 2019 at 02:18:12AM -0500, Jason Wang wrote: > > > +static const struct mmu_notifier_ops vhost_mmu_notifier_ops = { > > > + .invalidate_range

Re: [RFC PATCH V2 5/5] vhost: access vq metadata through kernel virtual address

2019-04-19 Thread Jerome Glisse
On Thu, Mar 07, 2019 at 02:38:38PM -0500, Andrea Arcangeli wrote: > On Thu, Mar 07, 2019 at 02:09:10PM -0500, Jerome Glisse wrote: > > I thought this patch was only for anonymous memory ie not file back ? > > Yes, the other common usages are on hugetlbfs/tmpfs that also don't > need to implement w

Re: [RFC PATCH V2 5/5] vhost: access vq metadata through kernel virtual address

2019-04-19 Thread Jerome Glisse
On Thu, Mar 07, 2019 at 10:34:39AM -0500, Michael S. Tsirkin wrote: > On Thu, Mar 07, 2019 at 10:45:57AM +0800, Jason Wang wrote: > > > > On 2019/3/7 上午12:31, Michael S. Tsirkin wrote: > > > > +static void vhost_set_vmap_dirty(struct vhost_vmap *used) > > > > +{ > > > > + int i; > > > > + >

Re: [PATCH v2] vsock/virtio: fix kernel panic from virtio_transport_reset_no_sock

2019-04-19 Thread Stefano Garzarella
On Wed, Mar 6, 2019 at 11:13 AM Adalbert Lazăr wrote: > > Previous to commit 22b5c0b63f32 ("vsock/virtio: fix kernel panic > after device hot-unplug"), vsock_core_init() was called from > virtio_vsock_probe(). Now, virtio_transport_reset_no_sock() can be called > before vsock_core_init() has the c

Re: [RFC PATCH net-next] failover: allow name change on IFF_UP slave interfaces

2019-04-19 Thread Liran Alon
> On 6 Mar 2019, at 23:42, si-wei liu wrote: > > > > On 3/6/2019 1:36 PM, Samudrala, Sridhar wrote: >> >> On 3/6/2019 1:26 PM, si-wei liu wrote: >>> >>> >>> On 3/6/2019 4:04 AM, Jiri Pirko wrote: > --- a/net/core/failover.c > +++ b/net/core/failover.c > @@ -16,6 +16,11 @@

Re: [PATCH] vsock/virtio: fix kernel panic from virtio_transport_reset_no_sock

2019-04-19 Thread Adalbert Lazăr
On Wed, 6 Mar 2019 17:02:16 +, Stefan Hajnoczi wrote: > On Wed, Mar 06, 2019 at 11:10:41AM +0200, Adalbert Lazăr wrote: > > On Wed, 6 Mar 2019 08:41:04 +, Stefan Hajnoczi > > wrote: > > > On Tue, Mar 05, 2019 at 08:01:45PM +0200, Adalbert Lazăr wrote: > > > The pkt argument is the receiv

Re: [RFC PATCH V2 4/5] vhost: introduce helpers to get the size of metadata area

2019-04-19 Thread Christophe de Dinechin
> On 6 Mar 2019, at 08:18, Jason Wang wrote: > > Signed-off-by: Jason Wang > --- > drivers/vhost/vhost.c | 46 -- > 1 file changed, 28 insertions(+), 18 deletions(-) > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index 2025543..101

[PATCH v2] vsock/virtio: fix kernel panic from virtio_transport_reset_no_sock

2019-04-19 Thread Adalbert Lazăr
Previous to commit 22b5c0b63f32 ("vsock/virtio: fix kernel panic after device hot-unplug"), vsock_core_init() was called from virtio_vsock_probe(). Now, virtio_transport_reset_no_sock() can be called before vsock_core_init() has the chance to run. [Wed Feb 27 14:17:09 2019] BUG: unable to handle k

Re: [PATCH] vsock/virtio: fix kernel panic from virtio_transport_reset_no_sock

2019-04-19 Thread Adalbert Lazăr
On Wed, 6 Mar 2019 08:41:04 +, Stefan Hajnoczi wrote: > On Tue, Mar 05, 2019 at 08:01:45PM +0200, Adalbert Lazăr wrote: > > Thanks for the patch, Adalbert! Please add a Signed-off-by tag so your > patch can be merged (see Documentation/process/submitting-patches.rst > Chapter 11 for details

Re: [RFC PATCH V2 2/5] vhost: fine grain userspace memory accessors

2019-04-19 Thread Christophe de Dinechin
> On 6 Mar 2019, at 08:18, Jason Wang wrote: > > This is used to hide the metadata address from virtqueue helpers. This > will allow to implement a vmap based fast accessing to metadata. > > Signed-off-by: Jason Wang > --- > drivers/vhost/vhost.c | 94 +

Re: [PATCH] vsock/virtio: fix kernel panic from virtio_transport_reset_no_sock

2019-04-19 Thread Stefano Garzarella
Hi Adalbert, thanks for catching this issue, I have a comment below. On Tue, Mar 05, 2019 at 08:01:45PM +0200, Adalbert Lazăr wrote: > Previous to commit 22b5c0b63f32 ("vsock/virtio: fix kernel panic after device > hot-unplug"), > vsock_core_init() was called from virtio_vsock_probe(). Now, > vir

Re: [PATCH] vsock/virtio: fix kernel panic from virtio_transport_reset_no_sock

2019-04-19 Thread Adalbert Lazăr
On Wed, 6 Mar 2019 09:12:36 +0100, Stefano Garzarella wrote: > > --- a/net/vmw_vsock/virtio_transport_common.c > > +++ b/net/vmw_vsock/virtio_transport_common.c > > @@ -662,6 +662,7 @@ static int virtio_transport_reset(struct vsock_sock > > *vsk, > > */ > > static int virtio_transport_reset_n

[PATCH] vsock/virtio: fix kernel panic from virtio_transport_reset_no_sock

2019-04-19 Thread Adalbert Lazăr
Previous to commit 22b5c0b63f32 ("vsock/virtio: fix kernel panic after device hot-unplug"), vsock_core_init() was called from virtio_vsock_probe(). Now, virtio_transport_reset_no_sock() can be called before vsock_core_init() has the chance to run. [Wed Feb 27 14:17:09 2019] BUG: unable to handle

Re: [PATCH v7 0/7] Add virtio-iommu driver

2019-04-19 Thread Thiago Jung Bauermann
Hello Jean-Philippe, Jean-Philippe Brucker writes: > Makes sense, though I think other virtio devices have been developed a > little more organically: device and driver code got upstreamed first, > and then the specification describing their interface got merged into > the standard. For example

Re: [PATCH] drm/bochs: Fix the ID mismatch error

2019-04-19 Thread Alistair Francis
On Thu, Feb 21, 2019 at 9:37 PM kra...@redhat.com wrote: > > On Thu, Feb 21, 2019 at 10:44:06AM -0800, Alistair Francis wrote: > > On Thu, Feb 21, 2019 at 3:52 AM kra...@redhat.com wrote: > > > > > > On Thu, Feb 21, 2019 at 12:33:03AM +, Alistair Francis wrote: > > > > When running RISC-V QEM

Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

2019-04-19 Thread Liran Alon
> On 28 Feb 2019, at 1:50, Michael S. Tsirkin wrote: > > On Wed, Feb 27, 2019 at 03:34:56PM -0800, si-wei liu wrote: >> >> >> On 2/27/2019 2:38 PM, Michael S. Tsirkin wrote: >>> On Tue, Feb 26, 2019 at 04:17:21PM -0800, si-wei liu wrote: On 2/25/2019 6:08 PM, Michael S. Tsirkin wro

Re: [PATCH v7 0/7] Add virtio-iommu driver

2019-04-19 Thread Thiago Jung Bauermann
Michael S. Tsirkin writes: > On Mon, Jan 21, 2019 at 11:29:05AM +, Jean-Philippe Brucker wrote: >> Hi, >> >> On 18/01/2019 15:51, Michael S. Tsirkin wrote: >> > >> > On Tue, Jan 15, 2019 at 12:19:52PM +, Jean-Philippe Brucker wrote: >> >> Implement the virtio-iommu driver, following spe

Re: [PATCH] drm/bochs: Fix the ID mismatch error

2019-04-19 Thread Alistair Francis
On Thu, Feb 21, 2019 at 3:52 AM kra...@redhat.com wrote: > > On Thu, Feb 21, 2019 at 12:33:03AM +, Alistair Francis wrote: > > When running RISC-V QEMU with the Bochs device attached via PCIe the > > probe of the Bochs device fails with: > > [drm:bochs_hw_init] *ERROR* ID mismatch > > > >

Re: [RFC PATCH] virtio_ring: Use DMA API if guest memory is encrypted

2019-04-19 Thread Thiago Jung Bauermann
Hello Michael, Michael S. Tsirkin writes: > On Tue, Jan 29, 2019 at 03:42:44PM -0200, Thiago Jung Bauermann wrote: >> >> Fixing address of powerpc mailing list. >> >> Thiago Jung Bauermann writes: >> >> > Hello, >> > >> > With Christoph's rework of the DMA API that recently landed, the patch

[PATCH] drm/bochs: Fix the ID mismatch error

2019-04-19 Thread Alistair Francis
When running RISC-V QEMU with the Bochs device attached via PCIe the probe of the Bochs device fails with: [drm:bochs_hw_init] *ERROR* ID mismatch This was introduced by this commit: 7780eb9ce8 bochs: convert to drm_dev_register To fix the error we ensure that pci_enable_device() is calle

Re: [RFC PATCH] virtio_ring: Use DMA API if guest memory is encrypted

2019-04-19 Thread Thiago Jung Bauermann
Christoph Hellwig writes: > On Tue, Jan 29, 2019 at 09:36:08PM -0500, Michael S. Tsirkin wrote: >> This has been discussed ad nauseum. virtio is all about compatibility. >> Losing a couple of lines of code isn't worth breaking working setups. >> People that want "just use DMA API no tricks" now

[PATCH v3 2/2] vsock/virtio: reset connected sockets on device removal

2019-04-19 Thread Stefano Garzarella
When the virtio transport device disappear, we should reset all connected sockets in order to inform the users. Signed-off-by: Stefano Garzarella Reviewed-by: Stefan Hajnoczi --- net/vmw_vsock/virtio_transport.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/vmw_vsock/virtio_transpo

[PATCH v3 1/2] vsock/virtio: fix kernel panic after device hot-unplug

2019-04-19 Thread Stefano Garzarella
virtio_vsock_remove() invokes the vsock_core_exit() also if there are opened sockets for the AF_VSOCK protocol family. In this way the vsock "transport" pointer is set to NULL, triggering the kernel panic at the first socket activity. This patch move the vsock_core_init()/vsock_core_exit() in the

[PATCH v3 0/2] vsock/virtio: fix issues on device hot-unplug

2019-04-19 Thread Stefano Garzarella
These patches try to handle the hot-unplug of vsock virtio transport device in a proper way. Maybe move the vsock_core_init()/vsock_core_exit() functions in the module_init and module_exit of vsock_virtio_transport module can't be the best way, but the architecture of vsock_core forces us to this

[RFC PATCH] virtio_ring: Use DMA API if guest memory is encrypted

2019-04-19 Thread Thiago Jung Bauermann
Hello, With Christoph's rework of the DMA API that recently landed, the patch below is the only change needed in virtio to make it work in a POWER secure guest under the ultravisor. The other change we need (making sure the device's dma_map_ops is NULL so that the dma-direct/swiotlb code is use

Re: [RFC PATCH] virtio_ring: Use DMA API if guest memory is encrypted

2019-04-19 Thread Thiago Jung Bauermann
Fixing address of powerpc mailing list. Thiago Jung Bauermann writes: > Hello, > > With Christoph's rework of the DMA API that recently landed, the patch > below is the only change needed in virtio to make it work in a POWER > secure guest under the ultravisor. > > The other change we need (ma

Re: [PATCH v3 5/5] xfs: disable map_sync for virtio pmem

2019-04-19 Thread Darrick J. Wong
On Wed, Jan 09, 2019 at 08:17:36PM +0530, Pankaj Gupta wrote: > Virtio pmem provides asynchronous host page cache flush > mechanism. we don't support 'MAP_SYNC' with virtio pmem > and xfs. > > Signed-off-by: Pankaj Gupta > --- > fs/xfs/xfs_file.c | 8 > 1 file changed, 8 insertions(+)

  1   2   >