Dan Carpenter dan.carpen...@oracle.com writes:
The PTR_ERR(NULL) here is not useful.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
v2: completely different
Applied.
Thanks,
Rusty.
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index
Amit Shah amit.s...@redhat.com writes:
If a port gets unplugged while a user is blocked on read(), -ENODEV is
returned. However, subsequent read()s returned 0, indicating there's no
host-side connection (but not indicating the device went away).
This also happened when a port was unplugged
Amit Shah amit.s...@redhat.com writes:
We used to keep the port's char device structs and the /sys entries
around till the last reference to the port was dropped. This is
actually unnecessary, and resulted in buggy behaviour:
1. Open port in guest
2. Hot-unplug port
3. Hot-plug a port with
Amit Shah amit.s...@redhat.com writes:
SIGIO should be sent when a port gets unplugged. It should only be sent
to prcesses that have the port opened, and have asked for SIGIO to be
delivered. We were clearing out guest_connected before calling
send_sigio_to_port(), resulting in a sigio not
Amit Shah amit.s...@redhat.com writes:
There's a window between find_port_by_devt() returning a port and us
taking a kref on the port, where the port could get unplugged. Fix it
by taking the reference in find_port_by_devt() itself.
Problem reported and analyzed by Mateusz Guzik.
This fix
Amit Shah amit.s...@redhat.com writes:
send_sigio_to_port() checks the value of guest_connected, which we
always modify under the inbuf_lock; make sure invocations of
send_sigio_to_port() have take the inbuf_lock around the call.
Signed-off-by: Amit Shah amit.s...@redhat.com
Applied,
Rusty.
Amit Shah amit.s...@redhat.com writes:
The removal functions act on the vqs, and the vq operations need to be
locked.
Signed-off-by: Amit Shah amit.s...@redhat.com
Applied,
Rusty.
---
drivers/char/virtio_console.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
Amit Shah amit.s...@redhat.com writes:
Port unplug can race with close() in port_fops_release().
port_fops_release() already takes the necessary locks, ensure
unplug_port() does that too.
Signed-off-by: Amit Shah amit.s...@redhat.com
Applied,
Rusty.
---
drivers/char/virtio_console.c | 2
Amit Shah amit.s...@redhat.com writes:
Remove the debugfs path before freeing port-name, to prevent a possible
use-after-free.
Reported-by: Jason Wang jasow...@redhat.com
Signed-off-by: Amit Shah amit.s...@redhat.com
Applied,
Rusty.
---
drivers/char/virtio_console.c | 3 +--
1 file
Amit Shah amit.s...@redhat.com writes:
Between open() being called and processed, the port can be unplugged.
Check if this happened, and bail out.
A simple test script to reproduce this is:
while true; do for i in $(seq 1 100); do echo $i /dev/vport0p3; done; done;
This opens and closes
Sudeep Dutt sudeep.d...@intel.com writes:
From: Ashutosh Dixit ashutosh.di...@intel.com
This patch introduces the card Virtio over PCIe interface for
Intel MIC. It allows virtio drivers on the card to communicate with their
user space backends on the host via a device page. Ring 3 apps on the
Jason Wang jasow...@redhat.com writes:
On 07/22/2013 01:45 PM, Rusty Russell wrote:
Amit Shah amit.s...@redhat.com writes:
On (Fri) 19 Jul 2013 [18:17:32], Jason Wang wrote:
On 07/19/2013 03:48 PM, Amit Shah wrote:
On (Fri) 19 Jul 2013 [15:03:50], Jason Wang wrote:
On 07/19/2013 04:16 AM
Amit Shah amit.s...@redhat.com writes:
On (Fri) 19 Jul 2013 [18:17:32], Jason Wang wrote:
On 07/19/2013 03:48 PM, Amit Shah wrote:
On (Fri) 19 Jul 2013 [15:03:50], Jason Wang wrote:
On 07/19/2013 04:16 AM, Amit Shah wrote:
Between poll() being called and processed, the port can be
Amit Shah amit.s...@redhat.com writes:
On (Mon) 22 Jul 2013 [13:00:43], Yoshihiro YUNOMAE wrote:
Hi,
This patch set fixes two bugs of splice_write in the virtio-console driver.
[BUG1] Although pipe-nrbufs is empty, the driver tries to do splice_write.
= This induces oops in
David Miller da...@davemloft.net writes:
From: Michael S. Tsirkin m...@redhat.com
Date: Wed, 17 Jul 2013 08:00:32 +0300
On Tue, Jul 16, 2013 at 12:33:26PM -0700, David Miller wrote:
From: Rusty Russell ru...@rustcorp.com.au
Date: Mon, 15 Jul 2013 11:13:25 +0930
From: Michael S. Tsirkin m
David Miller da...@davemloft.net writes:
From: Rusty Russell ru...@rustcorp.com.au
Date: Mon, 15 Jul 2013 11:13:25 +0930
From: Michael S. Tsirkin m...@redhat.com
For small packets we can simplify xmit processing
by linearizing buffers with the header:
most packets seem to have enough head
for this.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
---
drivers/net/virtio_net.c| 42 +
include/uapi/linux/virtio_net.h | 4 +++-
2 files changed, 37 insertions(+), 9 deletions(-)
diff
Michael S. Tsirkin m...@redhat.com writes:
On Tue, Jul 09, 2013 at 05:38:51PM +0930, Rusty Russell wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Tue, Jul 09, 2013 at 11:46:23AM +0930, Rusty Russell wrote:
Michael S. Tsirkin m...@redhat.com writes:
For small packets we can simplify
Michael S. Tsirkin m...@redhat.com writes:
On Tue, Jul 09, 2013 at 11:46:23AM +0930, Rusty Russell wrote:
Michael S. Tsirkin m...@redhat.com writes:
For small packets we can simplify xmit processing
by linearizing buffers with the header:
most packets seem to have enough head room
we can
of a
barrier here. Deferring this optimization until we do some
benchmarking.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Acked-by: Rusty Russell ru...@rustcorp.com.au
Thanks,
Rusty.
___
Virtualization mailing list
Virtualization@lists.linux
Paolo Bonzini pbonz...@redhat.com writes:
Il 04/07/2013 09:39, Michael S. Tsirkin ha scritto:
Transport feature bits are still negotiated per device though.
virtio-scsi devices in QEMU would not negotiate that feature.
Paolo
So I think it needs to be a per-device feature bit.
We
Michael S. Tsirkin m...@redhat.com writes:
On Mon, Jul 08, 2013 at 10:51:39AM +0930, Rusty Russell wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Thu, Jul 04, 2013 at 10:49:42AM +0300, Michael S. Tsirkin wrote:
case).
Regrettably, initial driver implementations used simple
Michael S. Tsirkin m...@redhat.com writes:
For small packets we can simplify xmit processing
by linearizing buffers with the header:
most packets seem to have enough head room
we can use for this purpose.
Since existing hypervisors require that header
is the first s/g element, we need a
Michael S. Tsirkin m...@redhat.com writes:
virtio_ring.h uses mb() and friends, make
it pull in asm/barrier.h itself, not rely
on other headers to do it.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Applied.
Thanks,
Rusty.
PS. I'll squeeze these into this merge window, since they're
. Here's the kernel patch:
virtio: VIRTIO_F_ANY_LAYOUT feature
Also known as the no really, I read the spec bit.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
diff --git a/include/uapi/linux/virtio_config.h
b/include/uapi/linux/virtio_config.h
index b7cda39..4b5da48 100644
--- a/include
Michael S. Tsirkin m...@redhat.com writes:
This fixes build for the vringh test:
[linux]$ make -C tools/virtio/
make: Entering directory `/home/mst/scm/linux/tools/virtio'
cc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign
-fno-strict-overflow -fno-strict-aliasing -fno-common -MMD
: Sasha Levin sasha.le...@oracle.com
Cc: Rusty Russell ru...@rustcorp.com.au
Cc: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Jason Wang jasow...@redhat.com
Thanks.
Applied,
Rusty.
___
Virtualization mailing list
Virtualization@lists.linux
):
virtio_pci: better macro exported in uapi
Pranavkumar Sawargaonkar (1):
virtio: console: Add emergency writeonly register to config space
Rusty Russell (1):
virtio: remove virtqueue_add_buf().
arch/x86/lguest/Makefile | 2 +-
arch/x86/lguest/{i386_head.S = head_32.S
Paolo Bonzini pbonz...@redhat.com writes:
Il 20/06/2013 04:40, Rusty Russell ha scritto:
Paolo Bonzini pbonz...@redhat.com writes:
Il 19/06/2013 10:24, Michael S. Tsirkin ha scritto:
2) We introduce VIRTIO_NET_F_ANY_LAYOUT and VIRTIO_BLK_F_ANY_LAYOUT
specifically for net and block (note
: Rusty Russell ru...@rustcorp.com.au
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Jason Wang jasow...@redhat.com
Signed-off-by: Andrew Vagin ava...@openvz.org
Signed-off-by: Andrey Vagin ava...@openvz.org
---
drivers/virtio/virtio_pci.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions
Michael S. Tsirkin m...@redhat.com writes:
On Wed, Jun 19, 2013 at 02:16:06PM +0930, Rusty Russell wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Thu, Jun 13, 2013 at 11:10:47AM +0300, Michael S. Tsirkin wrote:
On Thu, Jun 13, 2013 at 11:02:59AM +0300, Michael S. Tsirkin wrote
descriptors.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index 8d5bddb..99c0187 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -5,6 +5,22 @@ config VIRTIO
bus, such as CONFIG_VIRTIO_PCI
Ben Hutchings bhutchi...@solarflare.com writes:
On Mon, 2013-06-17 at 11:05 +0930, Rusty Russell wrote:
I thought LRO was deprecated and GRO was the new hotness, but I haven't
been following. Do we still care about LRO?
The old software LRO implementation, inet_lro, is deprecated in favour
Michael S. Tsirkin m...@redhat.com writes:
On Sun, Sep 09, 2012 at 02:36:50PM +0300, Michael S. Tsirkin wrote:
Drivers treat MUST_TELL_HOST as optional: windows drivers do not ack it
and expect this means they can tell host *after* deflate. This was not
the intent but the documentation was
Michael S. Tsirkin m...@redhat.com writes:
On Thu, Jun 13, 2013 at 11:10:47AM +0300, Michael S. Tsirkin wrote:
On Thu, Jun 13, 2013 at 11:02:59AM +0300, Michael S. Tsirkin wrote:
On Thu, Jun 13, 2013 at 02:12:22PM +0930, Rusty Russell wrote:
Michael S. Tsirkin m...@redhat.com writes
Michael S. Tsirkin m...@redhat.com writes:
On Wed, Jun 12, 2013 at 03:56:36PM +0100, Ben Hutchings wrote:
On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote:
On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote:
From: Ben Hutchings bhutchi...@solarflare.com
Date: Thu, 7
Stefan Hajnoczi stefa...@gmail.com writes:
On Sat, Jun 8, 2013 at 7:39 PM, Laszlo Ersek ler...@redhat.com wrote:
Patches before the last are small cleanups.
In the last patch I'm trying to extract / generalize an idea from Stefan
Hajnoczi's review of my virtio-net driver for OVMF.
How about
Michael S. Tsirkin m...@redhat.com writes:
On Thu, Mar 14, 2013 at 04:15:28PM +0100, Paolo Bonzini wrote:
Il 14/03/2013 12:10, Michael S. Tsirkin ha scritto:
Add field for guest to specify command size for virtio-blk.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
OK, but Rusty
Michael S. Tsirkin m...@redhat.com writes:
On Mon, Jun 03, 2013 at 09:56:15AM +0930, Rusty Russell wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Thu, May 30, 2013 at 08:53:45AM -0500, Anthony Liguori wrote:
Rusty Russell ru...@rustcorp.com.au writes:
Anthony Liguori aligu
Michael S. Tsirkin m...@redhat.com writes:
On Thu, May 30, 2013 at 01:28:26PM +0930, Rusty Russell wrote:
Yet the structure definitions are descriptive, capturing layout, size
and endianness in natural a format readable by any C programmer.
From an API design point of view, here
Michael S. Tsirkin m...@redhat.com writes:
On Thu, May 30, 2013 at 08:53:45AM -0500, Anthony Liguori wrote:
Rusty Russell ru...@rustcorp.com.au writes:
Anthony Liguori aligu...@us.ibm.com writes:
Forcing a guest driver change is a really big
deal and I see no reason to do that unless
Anthony Liguori anth...@codemonkey.ws writes:
Michael S. Tsirkin m...@redhat.com writes:
On Thu, May 30, 2013 at 08:40:47AM -0500, Anthony Liguori wrote:
Stefan Hajnoczi stefa...@gmail.com writes:
On Thu, May 30, 2013 at 7:23 AM, Rusty Russell ru...@rustcorp.com.au
wrote:
Anthony
Stefan Hajnoczi stefa...@gmail.com writes:
On Thu, May 30, 2013 at 7:23 AM, Rusty Russell ru...@rustcorp.com.au wrote:
On the receive side, what can we do better than readv? If we need to
return to userspace to tell the guest that we've got a new packet, we
don't win on latency. We might
Michael S. Tsirkin m...@redhat.com writes:
On Wed, May 29, 2013 at 10:47:52AM +0930, Rusty Russell wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Mon, Dec 12, 2011 at 01:49:13PM +0200, Michael S. Tsirkin wrote:
On Mon, Dec 12, 2011 at 09:15:03AM +1030, Rusty Russell wrote:
On Sun
Anthony Liguori anth...@codemonkey.ws writes:
Rusty Russell ru...@rustcorp.com.au writes:
On Fri, May 24, 2013 at 08:47:58AM -0500, Anthony Liguori wrote:
FWIW, I think what's more interesting is using vhost-net as a networking
backend with virtio-net in QEMU being what's guest facing
the device originally asked for.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
diff --git a/drivers/virtio/virtio_pci-common.h
b/drivers/virtio/virtio_pci-common.h
index ba1bf81..0e3143b 100644
--- a/drivers/virtio/virtio_pci-common.h
+++ b/drivers/virtio/virtio_pci-common.h
@@ -82,6 +82,9
Anthony Liguori aligu...@us.ibm.com writes:
Rusty Russell ru...@rustcorp.com.au writes:
Anthony Liguori aligu...@us.ibm.com writes:
Michael S. Tsirkin m...@redhat.com writes:
+case offsetof(struct virtio_pci_common_cfg, device_feature_select):
+return proxy-device_feature_select
Anthony Liguori anth...@codemonkey.ws writes:
Rusty Russell ru...@rustcorp.com.au writes:
Anthony Liguori anth...@codemonkey.ws writes:
Paolo Bonzini pbonz...@redhat.com writes:
Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto:
My fault. I should have looked at linux/types.h (actually
Paolo Bonzini pbonz...@redhat.com writes:
Il 28/05/2013 19:32, Michael S. Tsirkin ha scritto:
+
+switch (addr) {
+case offsetof(struct virtio_pci_common_cfg,
device_feature_select):
+return proxy-device_feature_select;
Oh dear no... Please use defines like
Anthony Liguori aligu...@us.ibm.com writes:
Michael S. Tsirkin m...@redhat.com writes:
+case offsetof(struct virtio_pci_common_cfg, device_feature_select):
+return proxy-device_feature_select;
Oh dear no... Please use defines like the rest of QEMU.
It is pretty ugly.
Yet the
Michael S. Tsirkin m...@redhat.com writes:
On Fri, May 24, 2013 at 08:47:58AM -0500, Anthony Liguori wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Fri, May 24, 2013 at 05:41:11PM +0800, Jason Wang wrote:
On 05/23/2013 04:50 PM, Michael S. Tsirkin wrote:
Hey guys,
I've updated
Michael S. Tsirkin m...@redhat.com writes:
On Mon, Dec 12, 2011 at 01:49:13PM +0200, Michael S. Tsirkin wrote:
On Mon, Dec 12, 2011 at 09:15:03AM +1030, Rusty Russell wrote:
On Sun, 11 Dec 2011 11:42:56 +0200, Michael S. Tsirkin m...@redhat.com
wrote:
On Thu, Dec 08, 2011 at 09:09:33PM
Anthony Liguori anth...@codemonkey.ws writes:
The headers say they are BSD licensed... but they include a GPLv2+
header. Doesn't make a lot of sense, does it?
It makes perfect sense: you're overthinking it. It just means that
copying the BSD headers outside Linux is encouraged.
And it's
Anthony Liguori anth...@codemonkey.ws writes:
Paolo Bonzini pbonz...@redhat.com writes:
Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto:
My fault. I should have looked at linux/types.h (actually asm-generic/).
Not really, __uX appear in the headers that were posted.
Which is a
Michael S. Tsirkin m...@redhat.com writes:
Fix issues observed with the new layout code, seen
when implementing device in qemu:
- use of uXX in uapi header
- incorrect readonly tag on one field
- unconditional warning breaks builds with -Werr
Signed-off-by: Michael S.
Dave Airlie airl...@gmail.com writes:
Hi Rusty,
current virtio-ring.c has a BUG_ON in virtqueue_add that checks
total_sg vg-vring.num, however I'm not sure it really is 100%
correct.
If I have an indirect ring and I'm adding sgs to it and the host is
delayed (say I've got a thread
Dave Airlie airl...@gmail.com writes:
correct.
If I have an indirect ring and I'm adding sgs to it and the host is
delayed (say I've got a thread consuming things from the vring and its
off doing something interesting),
I'd really like to get ENOSPC back from virtqueue_add. However if the
changing the number of queues.
This patch fixes this by enabling napi for all possible queues during open.
Cc: Sasha Levin sasha.le...@oracle.com
Signed-off-by: Jason Wang jasow...@redhat.com
Acked-by: Rusty Russell ru...@rustcorp.com.au
Dave, please send to Linus (fixes master).
Cheers
Michael S. Tsirkin m...@redhat.com writes:
control vq is only used if feature bit is
negotiated - it's not enough that device supports
it. Clarify this in the spec.
Thanks, applied.
Cheers,
Rusty.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
virtio-spec.lyx | 9 +++--
1
Michael S. Tsirkin m...@redhat.com writes:
On Mon, May 20, 2013 at 03:43:51PM +0200, Paolo Bonzini wrote:
Is there a story behind skipping virtio-net feature bits 2..4?
Paolo
Bits 3-4 now :)
I'm curious too.
Not a good one :)
The year is 2007. virtio_net was the posterchild of free
David Howells dhowe...@redhat.com writes:
Rusty Russell ru...@rustcorp.com.au wrote:
Macro still isn't usable, because userspace can't know whether it's the
new or old.
We need to either remove it from UAPI, or rename it to
VIRTIO_PCI_CONFIG_OFF.
Surely, if userspace is using
Michael S. Tsirkin m...@redhat.com writes:
Macro VIRTIO_PCI_CONFIG assumes that userspace actually has a structure
with a field named msix_enabled. Add VIRTIO_PCI_CONFIG_OFF that gets
the msix_enabled by value instead, to make it useful for userspace. We
still keep VIRTIO_PCI_CONFIG around
Michael S. Tsirkin m...@redhat.com writes:
macro VIRTIO_PCI_CONFIG except in the unlikely event userspace
actually has a structure with a field named msix_enabled.
Get the msix_enabled by value instead, to make it useful
for userspace.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Macro
Joe Perches j...@perches.com writes:
On Thu, 2013-05-16 at 13:04 +0930, Rusty Russell wrote:
Asias He as...@redhat.com writes:
On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote:
[]
Other users are using memcpy_fromiovec and friends outside net. It seems
a good idea to put
Michael S. Tsirkin m...@redhat.com writes:
uapi should use __u32 not u32.
Fix a macro in virtio_console.h which uses u32.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Ouch. Added CC:stable, and put into fixes. Mainly because it's
embarrassing :)
Cheers,
Rusty.
Nicholas A. Bellinger n...@linux-iscsi.org writes:
On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote:
Asias He as...@redhat.com writes:
scsi.c includes vhost.c which uses memcpy_fromiovec.
This patch fixes this build failure.
From Randy Dunlap:
'''
on x86_64
Asias He as...@redhat.com writes:
On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote:
Asias He as...@redhat.com writes:
scsi.c includes vhost.c which uses memcpy_fromiovec.
This patch fixes this build failure.
From Randy Dunlap:
'''
on x86_64:
ERROR
Asias He as...@redhat.com writes:
scsi.c includes vhost.c which uses memcpy_fromiovec.
This patch fixes this build failure.
From Randy Dunlap:
'''
on x86_64:
ERROR: memcpy_fromiovec [drivers/vhost/vhost_scsi.ko] undefined!
It needs to depend on NET since net/core/
Michael S. Tsirkin m...@redhat.com writes:
On Tue, May 07, 2013 at 02:13:44PM +0930, Rusty Russell wrote:
AFAICT we should always do zero copy.
It seems not to be a win for small packets.
I speculate the issue is that ring space isn't released as promptly.
Further, we can't do it safely
Michael S. Tsirkin m...@redhat.com writes:
On Mon, May 06, 2013 at 03:41:36PM +0930, Rusty Russell wrote:
Asias He as...@redhat.com writes:
Asias He (3):
vhost: Remove vhost_enable_zcopy in vhost.h
vhost: Move VHOST_NET_FEATURES to net.c
vhost: Make vhost a separate module
I
Asias He as...@redhat.com writes:
Asias He (3):
vhost: Remove vhost_enable_zcopy in vhost.h
vhost: Move VHOST_NET_FEATURES to net.c
vhost: Make vhost a separate module
I like these cleanups, MST pleasee apply.
I have some other cleanups which are on hold for the moment pending
MST's
Dmitry Tarnyagin dmitry.tarnya...@lockless.no writes:
Hi Rusty,
I hope it will be sent in plain text, I'm not fully controlling IT
environment at the moment :).
Acked-by: Dmity Tarnyagin dmitry.tarnya...@lockless.no
With best regards,
Applied.
Thanks,
Rusty.
Laszlo Ersek ler...@redhat.com writes:
On 04/23/13 06:05, Rusty Russell wrote:
Laszlo Ersek ler...@redhat.com writes:
Hi,
(I'm not subscribed to either list,)
using the word descriptor is misleading in the following sections:
Yes, I like the use of 'descriptor chains
Sjur Brændeland sjur.brandel...@stericsson.com writes:
Remove our (soon to be) bouncing email addresses,
and update Dmitri's address.
Dmitry will take over as maintainer for CAIF from now on.
Cc: Vikram Arv vikram@stericsson.com
Cc: Dmitry Tarnyagin dmitry.tarnya...@stericsson.com
Cc:
Ohad Ben-Cohen o...@wizery.com writes:
On Tue, Apr 23, 2013 at 6:46 AM, Rusty Russell ru...@rustcorp.com.au wrote:
Oh, we can break everything :)
I was concentrating purely on the mechanics of the virtqueue, mainly
because vhost has special needs wrt tracking changes. vhost doesn't use
Laszlo Ersek ler...@redhat.com writes:
Hi,
(I'm not subscribed to either list,)
using the word descriptor is misleading in the following sections:
Yes, I like the use of 'descriptor chains'. This is a definite
improvement.
Here's the diff I ended up with (massaged to minimize it).
Thanks!
Asias He as...@redhat.com writes:
On Mon, Apr 22, 2013 at 04:17:04PM +0300, Michael S. Tsirkin wrote:
+ evt = kzalloc(sizeof(*evt), GFP_KERNEL);
I think kzalloc not needed here, you init all fields.
Not really! evt-event.lun[4-7] is not initialized. It
Ohad Ben-Cohen o...@wizery.com writes:
Hi Sjur and Rusty,
Stuff which will be nice to change along these lines:
- maintain the vrh_callback_t pointer in struct vringh, similarly to
what struct virtqueue does today for callbacks of regular rings
- when kicked, just call vring_interrupt, and
Sasha Levin sasha.le...@oracle.com writes:
Add basic documentation for virtio-9p. I can expand more on device operation,
but I don't think there's anything significant enough for the spec to be
mentioned there. Please let me know if I'm wrong.
Signed-off-by: Sasha Levin sasha.le...@oracle.com
Amit Shah amit.s...@redhat.com writes:
Returning EMFILE (process has too many open files) is incorrect to
indicate a port is already open by another process. Use EBUSY for that.
This does change what we report to userspace, but I believe userspace
can look at it this way: it gets EBUSY, a
Asias He as...@redhat.com writes:
On Sat, Apr 06, 2013 at 09:40:13AM +0100, James Bottomley wrote:
Well, I haven't had time to look at anything other than the patch I
commented on. I'm happy with your fix, so you can add my acked by to
that one. Since it's going through the virtio tree,
Amit Shah amit.s...@redhat.com writes:
On (Sat) 06 Apr 2013 [11:52:07], Wei Yongjun wrote:
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Those symbols only used within this file, and should be static.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
Acked-by: Amit Shah
Ohad Ben-Cohen o...@wizery.com writes:
On Fri, Apr 5, 2013 at 6:37 AM, Rusty Russell ru...@rustcorp.com.au wrote:
@@ -220,6 +223,7 @@ static void rproc_virtio_finalize_features(struct
virtio_device *vdev)
* extension of the virtio resource entries.
*/
rvdev
Aiming these for coming merge window.
Nothing should change, but get ready for a non-guest-endian config transports,
and 32 features bits.
Final one is just an overdue consolidation.
Cheers,
Rusty.
Rusty Russell (7):
virtio_config: introduce size-based accessors.
virtio: use size-based
Michael S. Tsirkin m...@redhat.com writes:
By the way, Gleb pointed out that on older hosts MMIO will
always be slower since we need to do a shadow page walk to
translate virtual to physical address.
Hopefully not a big concern, and after all we are still
keeping PIO around for use by BIOS
Simply redirect everything via the byte-at-a-time accessor. Slow, but simple
and this is config reading, which mostly only happens at probe time.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
---
drivers/virtio/virtio.c | 69 +
include/linux
This lets the transport do endian conversion if necessary, and insulates
the drivers from that change.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
---
include/linux/virtio_config.h | 161 ++---
1 file changed, 134 insertions(+), 27 deletions(-)
diff
This lets the transport do endian conversion if necessary, and insulates
the drivers from the difference.
Most drivers can use the simple helpers virtio_cread() and virtio_cwrite().
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
---
drivers/block/virtio_blk.c | 77
already demonstrated
that it's useful to be able to see the ring size, and the new virtio
pci layout wants to know the location of each part of the ring.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
---
drivers/virtio/virtio_ring.c | 114 +-
include
Change the u32 to a u64, and make sure to use 1ULL everywhere!
Cc: Ohad Ben-Cohen o...@wizery.com
Cc: Brian Swetland swetl...@google.com
Cc: Cornelia Huck cornelia.h...@de.ibm.com
Cc: Christian Borntraeger borntrae...@de.ibm.com
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
Acked-by: Pawel
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
Acked-by: Pawel Moll pawel.m...@arm.com
---
drivers/char/virtio_console.c |2 +-
drivers/lguest/lguest_device.c |8
drivers/remoteproc/remoteproc_virtio.c |2 +-
drivers/s390/kvm/kvm_virtio.c |2
pawel.m...@arm.com
Cc: Christian Borntraeger borntrae...@de.ibm.com
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
---
drivers/lguest/lguest_device.c | 20 ++--
drivers/net/caif/caif_virtio.c |2 +-
drivers/s390/kvm/kvm_virtio.c | 24 +++---
drivers/s390/kvm/virtio_ccw.c
Dmitry Fleytman dmi...@daynix.com writes:
From: Dmitry Fleytman dfley...@redhat.com
Virtio-net driver currently negotiates network offloads
on startup via features mechanism and have no ability to
change offloads state later.
This patch introduced a new control command that allows
to
H. Peter Anvin h...@zytor.com writes:
On 03/29/2013 08:19 PM, Rusty Russell wrote:
Shift count?
You can only have 2^16 vqs per device. Is it verboten to write 16-bit
values to odd offsets? If so, we've just dropped it to 2^15 before you
have to do some decoding to do. Hard to care
Amos Kong kongjian...@gmail.com writes:
Some head files were split or moved to uapi/ without
updating MAINTAINERS.
Signed-off-by: Amos Kong kongjian...@gmail.com
Thanks, applied.
Cheers,
Rusty.
___
Virtualization mailing list
Amit Shah amit.s...@redhat.com writes:
When multiple ovq operations are being performed (lots of open/close
operations on virtio_console fds), the __send_control_msg() function can
get confused without locking.
A simple recipe to cause badness is:
* create a QEMU VM with two virtio-serial
H. Peter Anvin h...@zytor.com writes:
On 03/27/2013 04:25 AM, Michael S. Tsirkin wrote:
Aha. Yes, good idea. As for how large the offsets are,
I am guessing we should either just say offset is vqn * X and data is
vqn, or give hypervisors full flexibility with 32 bit offset and
arbitrary
Michael S. Tsirkin m...@redhat.com writes:
Rusty's currently doing some reorgs of -net let's delay
cleanups there to avoid stepping on each other's toys.
Let's focus on scsi here.
E.g. any chance framing assumptions can be fixed in 3.10?
I am waiting for your removal of the dma-compelete
Paul Bolle pebo...@tiscali.nl writes:
virtio_balloon.h exports u16 and u64 to userspace. Use __u16 and
__u64 instead.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
0) Tested with a kernel build.
1) Both types are used in this header for quite some time now. So is my
patch flawed or
Andru Gheorghiu gheorghiuan...@gmail.com writes:
PTR_RET does return. It's perfectly equivalent to using IS_ERR and the
returning PTR_ERR. The implementation is here [1].
Um, I read the implementation, thanks.
The reason for using it is this: if you have a function that does
something why
201 - 300 of 1486 matches
Mail list logo
