Re: [RFC PATCH 0/2] make mac programming for virtio net more robust

2013-01-11 Thread John Fastabend
On 1/10/2013 11:46 PM, Michael S. Tsirkin wrote: On Fri, Jan 11, 2013 at 12:53:07PM +1030, Rusty Russell wrote: "Michael S. Tsirkin" writes: On Thu, Jan 10, 2013 at 10:45:39PM +0800, ak...@redhat.com wrote: From: Amos Kong Currenly mac is programmed byte by byte. This means that we have an

Re: [RFC PATCH 0/2] make mac programming for virtio net more robust

2013-01-10 Thread Michael S. Tsirkin
On Fri, Jan 11, 2013 at 12:53:07PM +1030, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Jan 10, 2013 at 10:45:39PM +0800, ak...@redhat.com wrote: > >> From: Amos Kong > >> > >> Currenly mac is programmed byte by byte. This means that we > >> have an intermediate step where m

Re: [RFC PATCH 0/2] make mac programming for virtio net more robust

2013-01-10 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Thu, Jan 10, 2013 at 10:45:39PM +0800, ak...@redhat.com wrote: >> From: Amos Kong >> >> Currenly mac is programmed byte by byte. This means that we >> have an intermediate step where mac is wrong. >> >> Second patch introduced a new vq control command to set

Re: [RFC PATCH 0/2] make mac programming for virtio net more robust

2013-01-10 Thread Michael S. Tsirkin
On Thu, Jan 10, 2013 at 10:45:39PM +0800, ak...@redhat.com wrote: > From: Amos Kong > > Currenly mac is programmed byte by byte. This means that we > have an intermediate step where mac is wrong. > > Second patch introduced a new vq control command to set mac > address in one time. As you ment

Re: [RFC PATCH 0/2] make mac programming for virtio net more robust

2013-01-10 Thread Amos Kong
On Thu, Jan 10, 2013 at 10:45:39PM +0800, ak...@redhat.com wrote: > From: Amos Kong > > Currenly mac is programmed byte by byte. This means that we > have an intermediate step where mac is wrong. > > Second patch introduced a new vq control command to set mac > address in one time. I just post

[RFC PATCH 0/2] make mac programming for virtio net more robust

2013-01-10 Thread akong
From: Amos Kong Currenly mac is programmed byte by byte. This means that we have an intermediate step where mac is wrong. Second patch introduced a new vq control command to set mac address in one time. Amos Kong (2): move virtnet_send_command() above virtnet_set_mac_address() virtio-net: