On Fri, Jan 11, 2013 at 12:53:07PM +1030, Rusty Russell wrote: > "Michael S. Tsirkin" <m...@redhat.com> writes: > > > On Thu, Jan 10, 2013 at 10:45:39PM +0800, ak...@redhat.com wrote: > >> From: Amos Kong <ak...@redhat.com> > >> > >> Currenly mac is programmed byte by byte. This means that we > >> have an intermediate step where mac is wrong. > >> > >> Second patch introduced a new vq control command to set mac > >> address in one time. > > > > As you mention we could alternatively do it without > > new commands, simply add a feature bit that says that MACs are > > in the mac table. > > This would be a much bigger patch, and I'm fine with either way. > > Rusty what do you think? > > Hmm, mac filtering and "my mac address" are not quite the same thing. I > don't know if it matters for anyone: does it? > The mac address is abused > for things like identifying machines, etc.
I don't know either. I think net core differentiates between mac and uc_list because linux has to know which mac to use when building up packets, so at some level, I agree it might be useful to identify the machine. BTW netdev/davem should have been copied on this, Amos I think it's a good idea to remember to do it next time you post. > > If we keep it as a separate concept, Amos' patch seems to make sense. Yes. It also keeps the patch small, I just thought I'd mention the option. > > Cheers, > Rusty. -- MST _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization