Re: [vpp-dev] RFC: IPSec Tunnel remodel

2019-05-27 Thread Neale Ranns via Lists.Fd.Io
Hi Matt, I’m glad the change is not a problem for you. The trouble with passing partial rather than full information in the update, is that I cannot always tell what’s being updated. Consider the 3 phase re-key, the user is adding another receive SA, how can I tell if that’s the addition of a

Re: [vpp-dev] Plugin Versions

2019-05-27 Thread Damjan Marion via Lists.Fd.Io
> On 27 May 2019, at 13:54, Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at > Cisco) via Lists.Fd.Io wrote: > > SemVer says: > > Patch version Z (x.y.Z | x > 0) MUST be incremented if only backwards > > compatible bug fixes are introduced. > > A bug fix is defined as an internal change th

Re: [vpp-dev] Plugin Versions

2019-05-27 Thread Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) via Lists.Fd.Io
SemVer says: > Patch version Z (x.y.Z | x > 0) MUST be incremented if only backwards > compatible bug fixes are introduced. > A bug fix is defined as an internal change that fixes incorrect behavior. That means API version should be bumped even if the change only affects the implementation (and n

Re: [vpp-dev] VPP crash in show PCI command

2019-05-27 Thread siddarth rai
No luck. Tried with your suggested change, still getting the same. Regards, Siddarth On Fri, May 24, 2019 at 2:07 PM Damjan Marion wrote: > Can you try to replace: > > format_vlib_pci_vpd, d->vpd_r, 0); > > with > > format_vlib_pci_vpd, d->vpd_r, NULL); > > in show_pci_fn() - src/vlib/pci/pci.c