Re: [vpp-dev] About the order of  VLIB_INIT_FUNCTION called between different plugins

2019-06-04 Thread Satya Murthy
Hi Damjan, In the example you mentioned where bar_init() is trying to find if foo_plugin is really loaded or not. If foo_plugin is found to be not loaded, a warning is printed and returning a 0. But this does not gaurantee that bar_init() is called once again after a while, isnt it ? So, in thi

Re: [vpp-dev] About the order of  VLIB_INIT_FUNCTION called between different plugins

2019-06-04 Thread Damjan Marion via Lists.Fd.Io
> On 4 Jun 2019, at 09:08, Satya Murthy wrote: > > Hi Damjan, > > In the example you mentioned where bar_init() is trying to find if foo_plugin > is really loaded or not. > If foo_plugin is found to be not loaded, a warning is printed and returning a > 0. > > But this does not gaurantee tha

Re: [vpp-dev] duplicate user id allocation in ACL plugin

2019-06-04 Thread Benoit Ganne (bganne) via Lists.Fd.Io
> I dont see any constructs called runs_before or runs_after within > VLIB_INIT_FUNCTION macro. > I am getting compilation error when I try these changes. I could not find > any VLIB_INITS in 1810 (or) 1904 versions of the code. My mistake, I forgot to mention it was introduced in master after 19.

Re: [vpp-dev] duplicate user id allocation in ACL plugin

2019-06-04 Thread Satya Murthy
Thanks Ben. Do you see any other way to achieve this order in previous versions of the code. -- Thanks & Regards, Murthy -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13213): https://lists.fd.io/g/vpp-dev/message/13213 Mute This Topic: https://li

Re: [vpp-dev] About the order of  VLIB_INIT_FUNCTION called between different plugins

2019-06-04 Thread Satya Murthy
Sorry. I should have asked how to get the init functions in a specific order. Coz, ACL plugin init is getting called after my customplugin init and hence the registration from my plugin is getting wiped off. -- Thanks & Regards, Murthy -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent t

Re: [vpp-dev] duplicate user id allocation in ACL plugin

2019-06-04 Thread Andrew Yourtchenko
How about this in your plugin ? (Typed on iPhone so not directly copypasteable) static int registered_id = -1; void My_feature_enable () { If (-1 == registered_id) { registered_id = acl_plugin_register(“me myself and I”); } ... } --a > On 4 Jun 2019, at 13:00, Satya Murthy wrote: >

[vpp-dev] Passive close case, if FIN coming in with data, it seems don't count the FIN sequence, which lead to active close side retransmit FIN. #vnet

2019-06-04 Thread guangwei
I'am searching the TCP stack of VPP 18.07, from the code the TCP stack don't count the sequence of FIN when it come with some data in payload under passive, which will lead the active close side retransmit FIN, the code as following: tcp46_established_inline { ... /* 8: check the FIN bit */ if (PR

Re: [vpp-dev] Passive close case, if FIN coming in with data, it seems don't count the FIN sequence, which lead to active close side retransmit FIN. #vnet

2019-06-04 Thread Dave Barach via Lists.Fd.Io
Please, please, please upgrade to 19.04. The TCP host stack in 19.04 has had a tremendous amount of hardening work, to the point where it passes all 1.2 million Codenomicon TCP test [read: attack] vectors. The 19.04 version is deployed in a least one critical production network role. If you ch

Re: [vpp-dev] About the order of  VLIB_INIT_FUNCTION called between different plugins

2019-06-04 Thread Neale Ranns via Lists.Fd.Io
Pre 1908 : static clib_error_t * my_module_init (vlib_main_t * vm) { if ((error = vlib_call_init_function (vm, some_other_module_init))) return (error); } ; post 1908 : VLIB_INIT_FUNCTION (my_module_init) = { .runs_after = VLIB_INITS("some_other_module_init"), }; /neale

[vpp-dev] How to get every log info print out to stdout #vpp

2019-06-04 Thread guangwei
VPP run under CentOS and add clib_warning and printf in the code,  it seems suppressed and don't print every log out to stdout which triggered indeed,  is there  a method to resolve this ? or tune the parameters or print output to somewhere else ? -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all me

Re: [vpp-dev] How to get every log info print out to stdout #vpp

2019-06-04 Thread Dave Barach via Lists.Fd.Io
# /usr/bin/vpp unix interactive Not recommended for production use. Clib_warnings show up in syslog. D. From: vpp-dev@lists.fd.io On Behalf Of guangwei Sent: Tuesday, June 4, 2019 1:09 PM To: vpp-dev@lists.fd.io Subject: [vpp-dev] How to get every log info print out to stdout #vpp VPP run un