Re: [vpp-dev] vpp crashing on latest master branch with mlx5 enabled

Hi Mohammed, I am still not able to compile latest master with mlx5 support. Can you please give me some pointers on the compilation ? I have send the compilation error logs in the earlier mail. Thanks and Regards, Ashish -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this gro

[vpp-dev] csit verify failures

Hi all, I noticed 100% failures with the verify job vpp-csit-verify-device-master-1n-skx recently, eg. https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-csit-verify-device-master-1n-skx/10902/console.log.gz It seems to always fail with 'Failed to start TG docker container!' and 'Topology

[vpp-dev] VPP 21.01 draft release notes available - https://gerrit.fd.io/r/c/vpp/+/30450

Hi All, I have prepared the draft release notes for the 21.01 release - https://gerrit.fd.io/r/c/vpp/+/30450 As always - feel free to make the edits and push the changes directly. As a reminder - as per the release plan at [0], the release date for VPP 21.01 is 27th January, starting at noon CET

Re: [vpp-dev] GRE Tunnel IP6 over IP6

Hi Vikram, Thanks for the trace. I was able to create a UT case for this. It is an issue in VPP when parsing the destination option header. I will work on it. /neale From: Vikram Sachdeva Date: Monday, 18 January 2021 at 10:26 To: Neale Ranns Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev]

Re: [vpp-dev] GRE Tunnel IP6 over IP6

> Thanks for the trace. I was able to create a UT case for this. It is an issue > in VPP when parsing the destination option header. I will work on it. The tunnel encapsulation limit option has never been specified for GRE. It's arguable if this is a protocol compliant packet. It is also largely

Re: [vpp-dev] vpp crashing on latest master branch with mlx5 enabled

Hi Ashish, Building DPDK with mlx support in the VPP build system is experimental and not well tested (especially with CentOS), as I explained in my previous email. Don’t hesitate to contribute patches if you want to improve that support, I’ll happily take a look and help. About your issue, ple

[vpp-dev] git push to gerrit fails?

I cloned the gerrit VPP repo, created a new classify-val branch using git, made code changes, and used commit. Then, trying "git push", I fail. Does any VPP gerrit repo admin need to give me create permissions? Log is included below. $git push -u origin classify-val Username for 'https://

Re: [vpp-dev] git push to gerrit fails?

Hemant, https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code Best regards, Ole > On 19 Jan 2021, at 19:02, hemant via lists.fd.io > wrote: > > I cloned the gerrit VPP repo, created a new classify-val branch using git, > made code changes, and used commit. The

Re: [vpp-dev] git push to gerrit fails?

https://wiki.fd.io/view/DEV/Setting_up_Gerrit Regards, Florin > On Jan 19, 2021, at 10:02 AM, hemant via lists.fd.io > wrote: > > I cloned the gerrit VPP repo, created a new classify-val branch using git, > made code changes, and used commit.

Re: [vpp-dev] git push to gerrit fails?

Hi Hemant, You should use "git review" to send the patch. Please see [1]. [1] https://fd.io/docs/vpp/master/gettingstarted/developers/gitreview.html On Tue, 19 Jan 2021 at 21:02, hemant via lists.fd.io wrote: > I cloned the gerrit VPP repo, created a new classify-val branch using git, > made c

Re: [vpp-dev] git push to gerrit fails?

Thanks Ole and Florin, I did use the link Ole sent and also setup a SSH key on gerrit. Let me look into my issue. Best wishes, Hemant From: Florin Coras Sent: Tuesday, January 19, 2021 1:09 PM To: hem...@mnkcg.com Cc: vpp-dev Subject: Re: [vpp-dev] git push to gerrit fails?

Re: [vpp-dev] classifier howto?

Yay, I issued my first code review for VPP using gerrit for the issue of this email! https://gerrit.fd.io/r/c/vpp/+/30844 The JIRA issue I filed today is at: https://jira.fd.io/browse/VPP-1967 Thanks all for replying. Hemant From: vpp-dev@lists.fd.io On Behalf Of hemant via lis

Re: [vpp-dev] classifier howto?

Meta-comment: old_boring_call(foo) { /* meat */ } => Fancy_new_call(foo, bar) { /* new meat */ } Old_boring_call(foo) { Fancy_new_call(foo, 0); } This way you don’t have to patch umpteen unrelated places. --a > On 19 Jan 2021, at 19:26, hemant via lists.fd.io > wrote: > >  > Yay, I issue

Re: [vpp-dev] classifier howto?

Andrew, Great suggestion – thanks. I updated the code after taking care of your comments. https://gerrit.fd.io/r/c/vpp/+/30848/1 I didn’t update classify.api and classify_api.c for the “Fancy_new_call” yet. In another Pull Request (PR), I’d like to develop a new plugin that uses the

Re: [vpp-dev] classifier howto?

> On 19 Jan 2021, at 22:17, hem...@mnkcg.com wrote: >  > Andrew, > > Great suggestion – thanks. I updated the code after taking care of your > comments. > > https://gerrit.fd.io/r/c/vpp/+/30848/1 Seems like you pushed two different changes - the better approach is to reuse the “Change-ID

Re: [vpp-dev] classifier howto?

Andrew, Sorry, I am used to github which auto-merges two commits and missed using gerrit ‘s –amend in my 2nd commit. I did what you unicasted to me and now the latest diffs are available in review. https://gerrit.fd.io/r/c/vpp/+/30848 thanks, Hemant From: vpp-dev@lists.fd.io

Re: [vpp-dev] classifier howto?

the further discussion to be held in 30844 with the corresponding SMEs, but in my cursory virw it’s tweaking the buffer metadata area which is quite erformance critical - and if I read well https://gerrit.fd.io/r/c/vpp/+/30844/2/src/vlib/buffer.h#194 increases the per-buffer metadata size from

Re: [vpp-dev] classifier howto?

Andrew, The good thing with the code changes are that the changes are common to any plugin or base code tests. Any CSIT testing could take the diffs and test for sanity. I also wonder when the opaque2 member (line of code below) was added to vlib_buffer_t the cache line got impacted by

[vpp-dev] VPP Host Stack #hoststack #vpp-hoststack #vppfortelecomm #vpp-dev #vppcom #vppwithoutdpdk

Hi All, I have few queries related to VPP Host TCP stack: 1. Can we use only VPP TCP stack(L4 layer) only and disable L2/L3. If not what is its advantage of TLDK or similar stacks. 2. VPP TCP Stack does Batch process. Can VPP TCP Stack also do event based processing? Regards Anurag -=-=-=-=-=-