Re: [vpp-dev] hw_address of vnet_hw_interface_t

2021-04-02 Thread Mohsin Kazmi via lists.fd.io
Hi, It is the responsibility of the interface drivers to allocate the hw_address i.e.: error = ethernet_register_interface (vnm, virtio_device_class.index, vif->dev_instance, vif->mac_addr, >hw_if_index,

Re: [vpp-dev] child sa rekey

2021-04-02 Thread Benoit Ganne (bganne) via lists.fd.io
Hi Venu, > Strongswan keeps track for whatever is required but kernel feeds > the relevant information via events. Right, VPP model is different: it does not keep track of lifetime and the control plane must poll the per-SA bytes counters instead (which is what eg. the VPP ike2 plugin

Re: [vpp-dev] child sa rekey

2021-04-02 Thread Venumadhav Josyula
small correction , strongswan call *expire* not migrate On Fri, 2 Apr 2021 at 15:07, Venumadhav Josyula via lists.fd.io wrote: > Hi Benoit, > > Strongswan keeps track for whatever is required but kernel feeds the > relevant information via events. > > For *child sa*, in the kernel world, it is

Re: [vpp-dev] child sa rekey

2021-04-02 Thread Venumadhav Josyula
Hi Benoit, Strongswan keeps track for whatever is required but kernel feeds the relevant information via events. For *child sa*, in the kernel world, it is kernel which XFRM_EXPIRE message via netlink. The strongswan is listening of netlink events for the same. When it receives events from the

Re: [vpp-dev] child sa rekey

2021-04-02 Thread Benoit Ganne (bganne) via lists.fd.io
Hi Venu, I am not familiar with the kernel-vpp plugin you mention, however if I understand correctly your question is how strongSwan can know it must trigger a rekey because of time expiration or max bytes transferred? VPP IPsec does not manage SA lifetimes by itself, it is the responsibility

Re: [vpp-dev] New Committer Proposal

2021-04-02 Thread Neale Ranns
+1 /neale From: vpp-dev@lists.fd.io on behalf of Damjan Marion via lists.fd.io Date: Wednesday, 31 March 2021 at 19:58 To: vpp-dev Cc: Zhang, Roy Fan Subject: [vpp-dev] New Committer Proposal Dear VPP Committers, I would like to propose Roy Fan Zhang from Intel as a new VPP committer. Fan