Re: [vpp-dev] A question about TCP statck in version 19.04, when passive FIN coming in first, then APP close with TX fifo not empty, it seem can't have chance to send FIN out. #vnet

2019-06-28 Thread guangwei
Thanks. At 2019-06-29 00:52:21, "Florin Coras" wrote: Here’s the patch [1]. Thanks, Florin [1] https://gerrit.fd.io/r/c/20404/ On Jun 28, 2019, at 7:54 AM, guangwei wrote: Yes, please fixed it, I'am just searching the code, no environment to verify it. At 2019-06-28

Re: [vpp-dev] A question about TCP statck in version 19.04, when passive FIN coming in first, then APP close with TX fifo not empty, it seem can't have chance to send FIN out. #vnet

2019-06-28 Thread Florin Coras
Here’s the patch [1]. Thanks, Florin [1] https://gerrit.fd.io/r/c/20404/ > On Jun 28, 2019, at 7:54 AM, guangwei wrote: > > Yes, please fixed it, I'am just searching the code, no environment to verify > it. > > > > At 2019-06-28 22:45:23, "Florin Coras"

Re: [vpp-dev] A question about TCP statck in version 19.04, when passive FIN coming in first, then APP close with TX fifo not empty, it seem can't have chance to send FIN out. #vnet

2019-06-28 Thread guangwei
Yes, please fixed it, I'am just searching the code, no environment to verify it. At 2019-06-28 22:45:23, "Florin Coras" wrote: >Hi, > >That is correct. You want to provide the patch or should I do it? > >Thanks, >Florin > >> On Jun 28, 2019, at 6:10 AM, guangwei wrote: >> >> Now, I'am

Re: [vpp-dev] A question about TCP statck in version 19.04, when passive FIN coming in first, then APP close with TX fifo not empty, it seem can't have chance to send FIN out. #vnet

2019-06-28 Thread Florin Coras
Hi, That is correct. You want to provide the patch or should I do it? Thanks, Florin > On Jun 28, 2019, at 6:10 AM, guangwei wrote: > > Now, I'am searching the TCP stack of VPP 19.04, and have a doubt, please look > following comment in line. > > tcp46_rcv_process_inline > { > ... >

[vpp-dev] A question about TCP statck in version 19.04, when passive FIN coming in first, then APP close with TX fifo not empty, it seem can't have chance to send FIN out. #vnet

2019-06-28 Thread guangwei
Now, I'am searching the TCP stack of VPP 19.04, and have a doubt, please look following comment in line. tcp46_rcv_process_inline { ... /* 5: check the ACK field  */ ... case TCP_STATE_CLOSE_WAIT: /* Do the same processing as for the ESTABLISHED state. */ if (tcp_rcv_ack (wrk, tc0, b0, tcp0, ))