Re: [vpp-dev] ACL plugin optimization

2020-05-29 Thread Govindarajan Mohandoss
; Jieqiang > Wang ; Honnappa Nagarahalli > ; nd > Subject: Re: [vpp-dev] ACL plugin optimization > > Hi Govind, > > 1) According to Jenkins, this patch permits some of the packets that should > be denied, hence JJB voted "-1". > > 2) If you suspect merely th

Re: [vpp-dev] ACL plugin optimization

2020-05-29 Thread Govindarajan Mohandoss
> ; nd > Subject: Re: [vpp-dev] ACL plugin optimization > > > Hi Govind, > > As well as removing the prefetches, you've also removed the per packet call > to acl_fa_find_session_with_hash(). So IIUC you've removed the per-packet > session lookup and inste

Re: [vpp-dev] ACL plugin optimization

2020-05-27 Thread Neale Ranns via lists.fd.io
Hi Govind, As well as removing the prefetches, you've also removed the per packet call to acl_fa_find_session_with_hash(). So IIUC you've removed the per-packet session lookup and instead re-use the lookup of packet 0 each time. that'll make things quicker but it's not functionally correct. /

Re: [vpp-dev] ACL plugin optimization

2020-05-27 Thread Andrew Yourtchenko
Hi Govind, 1) According to Jenkins, this patch permits some of the packets that should be denied, hence JJB voted "-1". 2) If you suspect merely the prefetches are the issue, just commenting out the body of prefetch_session_entry() in the original code should turn it into a no-op that doesn't bre

[vpp-dev] ACL plugin optimization

2020-05-27 Thread Govindarajan Mohandoss
Hi Andrew, While profiling the ACL plugin node using perf tool in ARM Neoverse platform, Bihash related prefetches were shown as bottleneck. Performance improvement is seen in ARM N1, TX2 and Intel Skylake servers after removing those prefetches. Testing is done with Ingress ACL/IPv4 forwardi