Yesterday I forgot to notify
that the job [8] is fixed [9] now.
It will be kept non-voting for a week or so
to make sure no CRC surprises are about to get merged
just before the voting is enabled again.
Vratko.
[8] https://jenkins.fd.io/job/vpp-csit-verify-api-crc-master/
[9]
> job is created
… but it quickly turned to non-voting,
because a recent merge [4] changed CRCs.
It has been reverted [5] since then,
but verifying everything is fixed [6] on CSIT side
is delayed [7].
Vratko.
[4] https://gerrit.fd.io/r/c/vpp/+/20946
[5] https://gerrit.fd.io/r/c/vpp/+/20997
[6]
Vratko,
Why was the CSIT patch merged without being reviewed by a non-author?
The job has been reverted to non-voting, because the CRC's contained in
the script are behind the current version of src/vnet/ip/ip_types.api,
thus on rebasing a patch to HEAD the job votes -1.
Thanks,
-daw-
On
[1] is now merged, job is created, and I see [3] it passing.
Vratko.
[3] https://jenkins.fd.io/job/vpp-csit-verify-api-crc-master/2/console
From: Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco)
Sent: Wednesday, July 31, 2019 10:41 AM
To: 'vpp-api-...@lists.fd.io' ;
[0] is merged, but [1] is stuck due to [2].
Vratko.
[2] https://lists.fd.io/g/vpp-dev/message/13627
From: Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco)
Sent: Monday, July 22, 2019 7:14 PM
To: vpp-api-...@lists.fd.io; vpp-dev@lists.fd.io; csit-dev
Cc: Dave Wallace
The main API flag document: [0].
I have most of implementation ready,
see [1] and comments there.
The missing parts is e-mail alerting
and postponing main vpp verify jobs
until API check passes (older stable/ VPP branches
are tricky to support in that way).
Please review, I would like to merge
