Re: [vpp-dev] help with review

2023-02-09 Thread Benoit Ganne (bganne) via lists.fd.io
pp-dev@lists.fd.io On Behalf Of Pei, Yulong > Sent: Thursday, February 9, 2023 3:41 > To: Benoit Ganne (bganne) > Cc: vpp-dev@lists.fd.io; Dave Wallace (dwallace) > Subject: Re: [vpp-dev] help with review > > Hi Benoit and vpp-dev,What is your opinion about this patch > https://g

Re: [vpp-dev] help with review

2023-02-08 Thread Pei, Yulong
To: Benoit Ganne (bganne) Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] help with review Hi Benoit, A new one also need your help to review https://gerrit.fd.io/r/c/vpp/+/38135 , thanks a lot. -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Benoit Ganne (bganne) via lists.fd.io Sent

Re: [vpp-dev] help with review

2023-02-07 Thread Pei, Yulong
-dev] help with review Hi, thanks for the head's up. > Please help to review below patches again, all your comments were > addressed. Thanks a lot. > https://gerrit.fd.io/r/c/vpp/+/38008 Merged! > https://gerrit.fd.io/r/c/vpp/+/38009 A few minor comments left on that one, but th

Re: [vpp-dev] help with review

2023-02-02 Thread Benoit Ganne (bganne) via lists.fd.io
Hi, thanks for the head's up. > Please help to review below patches again, all your comments > were addressed. Thanks a lot. > https://gerrit.fd.io/r/c/vpp/+/38008 Merged! > https://gerrit.fd.io/r/c/vpp/+/38009 A few minor comments left on that one, but then we should be good to merge.

[vpp-dev] help with review

2023-02-01 Thread Pei, Yulong
Ganne (bganne) Subject: [vpp-dev] help review for patch about update af_xdp plugin to depend on libxdp Hi Benoit and vpp-dev, Could you help review for patch about update af_xdp plugin to depend on libxdp https://gerrit.fd.io/r/c/vpp/+/37869 . -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all

Re: [vpp-dev] help with review

2023-01-24 Thread Ole Troan via lists.fd.io
Looks good to me. Merged. Best regards, Ole > On 24 Jan 2023, at 08:55, Stanislav Zaikin wrote: > > Hello folks, > > Any help with review is much appreciated. Both patches are waiting for quite > a long time. > > - https://gerrit.fd.io/r/c/vpp/+/36721 > Short description: "autoendian" was

[vpp-dev] help with review

2023-01-23 Thread Stanislav Zaikin
Hello folks, Any help with review is much appreciated. Both patches are waiting for quite a long time. - https://gerrit.fd.io/r/c/vpp/+/36721 Short description: "autoendian" was broken for streaming message types like: service { rpc lcp_itf_pair_get returns lcp_itf_pair_get_reply *stream