[vpp-dev] ip-rewrite bug?

2019-03-05 Thread Kingwel Xie
Hi vpp-dev, I’m looking at the ip-rewrite node, and I think it might be a bug at: vnet_rewrite_one_header (adj0[0], ip0, sizeof (ethernet_header_t)); The adj-> rewrite_header.data_bytes might be 0 when it comes to tunnel interface, f.g., gtpu, ipsec. Thus, at least 8 bytes garbage are written t

Re: [vpp-dev] ip-rewrite bug?

2019-03-05 Thread Dave Barach via Lists.Fd.Io
it would be a Good Thing... D. From: vpp-dev@lists.fd.io On Behalf Of Kingwel Xie Sent: Tuesday, March 5, 2019 4:40 AM To: vpp-dev@lists.fd.io Subject: [vpp-dev] ip-rewrite bug? Hi vpp-dev, I’m looking at the ip-rewrite node, and I think it might be a bug at: vnet_rewrite_one_header (adj0[0

Re: [vpp-dev] ip-rewrite bug?

2019-03-05 Thread Kingwel Xie
On Behalf Of Kingwel Xie Sent: Tuesday, March 5, 2019 4:40 AM To: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> Subject: [vpp-dev] ip-rewrite bug? Hi vpp-dev, I’m looking at the ip-rewrite node, and I think it might be a bug at: vnet_rewrite_one_header (adj0[0], ip0, sizeof (ethernet_he

Re: [vpp-dev] ip-rewrite bug?

2019-03-11 Thread Benoit Ganne (bganne) via Lists.Fd.Io
Barach > via Lists.Fd.Io > Sent: mardi 5 mars 2019 13:25 > To: Kingwel Xie ; vpp-dev@lists.fd.io > Cc: vpp-dev@lists.fd.io > Subject: Re: [vpp-dev] ip-rewrite bug? > > Let’s try to fix the underlying code in vnet_rewrite_one_header, and > friends. The code already checks f