[vpp-dev] subunit requirement

2018-03-05 Thread Thomas F Herbert
Garbriel and all, I am working on the release packaging for 18.01.1 for Centos. I want to discuss the subunit requirement in deps and in the spec file originally introduced in this patch. https://gerrit.fd.io/r/gitweb?p=vpp.git;a=commitdiff;h=d3e671e0dbb879d90f00bdee608ee0bb5f6357ae Although

Re: [vpp-dev] subunit requirement

2018-03-06 Thread Gabriel Ganne
Hi Tom, I assume you are talking about the rpm packaging, and not the RPM_DEPENDS from the root Makefile, right ? If so then feel free to remove it, as I believe it is only needed to run the tests. Otherwise I still believe it should be part of the "make install-dep" target. Best regards, On 5 M

Re: [vpp-dev] subunit requirement

2018-03-08 Thread Klement Sekera
Hi Tom, this is caused by simple fact that verify job runs only for a subset of supported distros. At (development) time of the patch, I wasn't aware of this, and the result is that after the commit containing VAPI tests, some centos people started to complain that it doesn't build for them or