Re: [waffle] [PATCH 7/7] tests/gl_basic_test: Support platform surfaceless_egl

On Wed 19 Oct 2016, Emil Velikov wrote: > On 18 October 2016 at 18:33, Chad Versace wrote: > > Run with `bin/gl_basic_test --platform=surfaceless_egl`. > > > > All the tests fail! The rgba pixels returned by glReadPixels are > > black (0x0, 0x0, 0x0, 0xff), but the test

Re: [waffle] [PATCH 5/7] surfaceless_egl: Implement new platform

On Wed 19 Oct 2016, Emil Velikov wrote: > On 18 October 2016 at 18:33, Chad Versace wrote: > > Now waffle_init() supports WAFFLE_PLATFORM_SURFACELESS_EGL. > > > > Cc: Gurchetan Singh > > Cc: Haixia Shi > > --- > > include/waffle/waffle.h

Re: [waffle] [PATCH 4/7] cmake: Add option waffle_has_surfaceless_egl

On Wed 19 Oct 2016, Emil Velikov wrote: > On 18 October 2016 at 18:33, Chad Versace wrote: > > This patch contains just the CMake changes for the new surfaceless_egl > > platform. Code will come in the following patches. > > > > Cc: Gurchetan Singh > > Cc: Haixi

Re: [waffle] [PATCH 3/7] egl: Allow pbuffers to back wegl_surface

On Wed 19 Oct 2016, Emil Velikov wrote: > On 18 October 2016 at 18:33, Chad Versace wrote: > > Add function wegl_pbuffer_init(), which initializes a struct > > wegl_surface with eglCreatePbufferSurface(). > > > > Not yet used, but will be used later by the new surfa

[waffle] [PATCH 8/8] egl: Use eglGetPlatformDisplayEXT as a fallback

If the EGL platform does not support eglGetPlatformDisplay, but does support eglGetPlatformDisplayEXT, then use it as a fallback. Of course, if neither is supported, we fall back all the way to eglGetDisplay. This is useful for exercising the codepaths on Mesa, which does support the extensions fo

Re: [waffle] [PATCH 0/7] Use eglGetPlatformDisplay when possible (v2)

On Tue 25 Oct 2016, Emil Velikov wrote: > On 24 October 2016 at 22:57, Chad Versace wrote: > > Before EGL_EXT_platform_base and EGL 1.5, when using Mesa the best way > > to select the EGL platform was to set the EGL_PLATFORM environment > > variable. Now that

[waffle] [PATCH 5/8] egl: Optionally query for eglGetPlatformDisplay (v2)

Not yet used. v2: Use eglGetProcAddress, not dlsym, due the EGL 1.5 spec. (for emil) Cc: Emil Velikov --- src/waffle/egl/wegl_imports.h | 4 src/waffle/egl/wegl_platform.c | 23 +++ src/waffle/egl/wegl_platform.h | 4 3 files changed, 31 insertions(+) diff --gi

[waffle] [PATCH 4/8] egl: Query client extensions string

Query and store the EGL client extensions string as wegl_platform::client_extensions. Prepares for eventual use of eglGetPlatformDisplay. Reviewed-by: Emil Velikov --- src/waffle/egl/wegl_platform.c | 3 +++ src/waffle/egl/wegl_platform.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/

[waffle] [PATCH 7/8] egl: Use eglGetPlatformDisplay when possible (v2)

Tested against Mesa master@8c78fdb with `ninja check-func` on Linux for x11_egl, wayland, and gbm. However, the new codepaths were not tested because Mesa does not yet support the needed eglGetPlatformDisplay extensions. v2: - For x11_egl, pass a `Display*` to eglGetPlatformDisplay, not a `D

[waffle] [PATCH 2/8] egl: Update wegl_platform_init signature

No intended change in behavior. Prepares for eventual use of eglGetPlatformDisplay. Add an `EGLenum egl_platform` parameter to wegl_platform_init() and store it at wegl_platform::egl_platform. Reviewed-by: Emil Velikov --- src/waffle/egl/wegl_platform.c| 5 - src/waffle/egl/wegl_pl

[waffle] [PATCH 6/8] egl: Update wegl_display_init signature

Change the type of parameter 'native_display' from intptr_t to void*. No intended change in behavior. Prepares for eventual use of eglGetPlatformDisplay, whose 'native_display' parameter has type void*. Reviewed-by: Emil Velikov --- src/waffle/android/droid_display.c | 3 +-- src/waffle/egl/

[waffle] [PATCH 3/8] egl: Move each platform's setenv("EGL_PLATFORM") into core EGL code (v2)

Each EGL platform 'foo' calls setenv("EGL_PLATFORM", "foo") during foo_platform_create(), and calls unsetenv("EGL_PLATFORM") during foo_platform_destroy(). Move the setenv/unsetenv into the core EGL code, into wegl_platform_init() and wegl_platform_finish(). This prepares for eventually using eglG

[waffle] [PATCH 1/8] egl: Define EGL_PLATFORM_* enums

Prepares for use of eglGetPlatformDisplay. Define the enums to prevent the Waffle build from breaking against old headers... like Ubuntu LTS. Reviewed-by: Emil Velikov --- src/waffle/egl/wegl_imports.h | 26 ++ src/waffle/egl/wegl_platform.h | 2 ++ 2 files changed, 28

[waffle] [PATCH 0/7] Use eglGetPlatformDisplay when possible (v2)

t for EGL_MESA_platform_surfaceless. This branch lives at https://github.com/chadversary/waffle/commits/review/eglGetPlatformDisplay-v02 v2: - Fix bugs found by Emil. - Don't set EGL_PLATFORM=android. - Last patch, add fallback to use eglGetPlatformDisplayEXT. Chad Versace (8): e

Re: [waffle] [PATCH 0/7] Use eglGetPlatformDisplay when possible

On Wed 19 Oct 2016, Emil Velikov wrote: > On 18 October 2016 at 17:58, Chad Versace wrote: > > Before EGL_EXT_platform_base and EGL 1.5, when using Mesa the best way > > to select the EGL platform was to set the EGL_PLATFORM environment > > variable. Now that

Re: [waffle] [PATCH 7/7] egl: Use eglGetPlatformDisplay when possible

On Wed 19 Oct 2016, Emil Velikov wrote: > On 18 October 2016 at 17:58, Chad Versace wrote: > > Tested against Mesa master@8c78fdb with `ninja check-func` on Linux. > > --- > > src/waffle/egl/wegl_display.c | 22 ++ > > src/waff

Re: [waffle] [PATCH 5/7] egl: Optionally dlsym eglGetPlatformDisplay

On Tue 18 Oct 2016, Emil Velikov wrote: > On 18 October 2016 at 17:58, Chad Versace wrote: > > +#define RETRIEVE_EGL_SYMBOL_OPTIONAL(function) \ > > +self->function = dlsym(self->eglHandle, #function); > > + > Not 100% sure if dlsym shoul

Re: [waffle] [PATCH 3/7] egl: Move each platform's setenv("EGL_PLATFORM") into core EGL code

On Tue 18 Oct 2016, Emil Velikov wrote: > On 18 October 2016 at 17:58, Chad Versace wrote: > > > +case EGL_PLATFORM_ANDROID_KHR: > > +setenv("EGL_PLATFORM", "android", true); > > +break; > Thus hunk is a new addition.

[waffle] [PATCH 5/7] surfaceless_egl: Implement new platform

Now waffle_init() supports WAFFLE_PLATFORM_SURFACELESS_EGL. Cc: Gurchetan Singh Cc: Haixia Shi --- include/waffle/waffle.h | 1 + man/waffle_init.3.xml| 9 ++ src/waffle/CMakeLists.txt| 9 ++ src/waffle/api/waffle_init.c |

[waffle] [PATCH 3/7] egl: Allow pbuffers to back wegl_surface

Add function wegl_pbuffer_init(), which initializes a struct wegl_surface with eglCreatePbufferSurface(). Not yet used, but will be used later by the new surfaceless platform. Cc: Gurchetan Singh Cc: Haixia Shi --- src/waffle/egl/wegl_platform.c | 1 + src/waffle/egl/wegl_platform.h | 2 ++

[waffle] [PATCH 6/7] wflinfo: Support --platform=surfaceless_egl

Cc: Gurchetan Singh Cc: Haixia Shi --- man/wflinfo.1.xml | 1 + src/utils/wflinfo.c | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/man/wflinfo.1.xml b/man/wflinfo.1.xml index a1c2589..2f54aaa 100644 --- a/man/wflinfo.1.xml +++ b/man/wflinfo.1.xml @@ -75,6 +75,7 @@

[waffle] [PATCH 4/7] cmake: Add option waffle_has_surfaceless_egl

This patch contains just the CMake changes for the new surfaceless_egl platform. Code will come in the following patches. Cc: Gurchetan Singh Cc: Haixia Shi --- Options.cmake | 3 +++ cmake/Modules/WaffleDefineCompilerFlags.cmake | 4 cmake/Mod

[waffle] [PATCH 7/7] tests/gl_basic_test: Support platform surfaceless_egl

Run with `bin/gl_basic_test --platform=surfaceless_egl`. All the tests fail! The rgba pixels returned by glReadPixels are black (0x0, 0x0, 0x0, 0xff), but the test expects magenta (0xff, 0x0, 0xff, 0xff). I don't know why. Cc: Gurchetan Singh Cc: Haixia Shi --- tests/functional/gl_basic_test.c

[waffle] [PATCH 2/7] egl: Rename struct wegl_window -> wegl_surface

Today, the EGLSurface belonging to struct wegl_window (and, post-patch, struct wegl_surface) is always created with eglCreateWindowSurface. But future patches will extend it to allow the EGLSurface to be a pbuffer. Hence the rename, to reduce confusion. --- src/waffle/android/droid_platform.c | 2

[waffle] [PATCH 1/7] egl: Rename files wegl_window.* -> wegl_surface.*

Today, the EGLSurface belonging to struct wegl_window (and, post-patch, struct wegl_surface) is always created with eglCreateWindowSurface. But future patches will extend it to allow the EGLSurface to be a pbuffer. Hence the rename, to reduce confusion. This patch renames the files. The next patch

[waffle] [PATCH 0/7] surfaceless_egl: Implement new platform

atch submitted to mesa-dev https://patchwork.freedesktop.org/patch/116476/ Chad Versace (7): egl: Rename files wegl_window.* -> wegl_surface.* egl: Rename struct wegl_window -> wegl_surface egl: Allow pbuffers to back wegl_surface cmake: Add option waffle_has_surfaceless

[waffle] [PATCH 1/7] egl: Define EGL_PLATFORM_* enums

Prepares for use of eglGetPlatformDisplay. Define the enums to prevent the Waffle build from breaking against old headers... like Ubuntu LTS. --- src/waffle/egl/wegl_imports.h | 26 ++ src/waffle/egl/wegl_platform.h | 2 ++ 2 files changed, 28 insertions(+) diff --git a

[waffle] [PATCH 5/7] egl: Optionally dlsym eglGetPlatformDisplay

Not yet used. --- src/waffle/egl/wegl_imports.h | 4 src/waffle/egl/wegl_platform.c | 6 ++ src/waffle/egl/wegl_platform.h | 4 3 files changed, 14 insertions(+) diff --git a/src/waffle/egl/wegl_imports.h b/src/waffle/egl/wegl_imports.h index 99e79c8..3f39b9e 100644 --- a/src/waffl

[waffle] [PATCH 7/7] egl: Use eglGetPlatformDisplay when possible

Tested against Mesa master@8c78fdb with `ninja check-func` on Linux. --- src/waffle/egl/wegl_display.c | 22 ++ src/waffle/egl/wegl_platform.c | 35 +-- src/waffle/egl/wegl_platform.h | 8 3 files changed, 59 insertions(+), 6 deletions

[waffle] [PATCH 2/7] egl: Update wegl_platform_init signature

No intended change in behavior. Prepares for eventual use of eglGetPlatformDisplay. Add an `EGLenum egl_platform` parameter to wegl_platform_init() and store it at wegl_platform::egl_platform. --- src/waffle/egl/wegl_platform.c| 5 - src/waffle/egl/wegl_platform.h| 5 - s

[waffle] [PATCH 0/7] Use eglGetPlatformDisplay when possible

t for EGL_MESA_platform_surfaceless. This branch lives at https://github.com/chadversary/waffle/commits/review/eglGetPlatformDisplay-v01 Chad Versace (7): egl: Define EGL_PLATFORM_* enums egl: Update wegl_platform_init signature egl: Move each platform's setenv("EGL_PLATFORM") into

[waffle] [PATCH 4/7] egl: Query client extensions string

Query and store the EGL client extensions string as wegl_platform::client_extensions. Prepares for eventual use of eglGetPlatformDisplay. --- src/waffle/egl/wegl_platform.c | 3 +++ src/waffle/egl/wegl_platform.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/waffle/egl/wegl_platform

[waffle] [PATCH 6/7] egl: Update wegl_display_init signature

Change the type of parameter 'native_display' from intptr_t to void*. No intended change in behavior. Prepares for eventual use of eglGetPlatformDisplay, whose 'native_display' parameter has type void*. --- src/waffle/android/droid_display.c | 3 +-- src/waffle/egl/wegl_display.c| 2 +-

[waffle] [PATCH 3/7] egl: Move each platform's setenv("EGL_PLATFORM") into core EGL code

Each EGL platform 'foo' calls setenv("EGL_PLATFORM", "foo") during foo_platform_create(), and calls unsetenv("EGL_PLATFORM") during foo_platform_destroy(). Move the setenv/unsetenv into the core EGL code, into wegl_platform_init() and wegl_platform_finish(). This prepares for eventually using eglG

Re: [waffle] [PATCH 1/2] Revert "wegl: add EGL image create/destroy"

On Wed 12 Oct 2016, Emil Velikov wrote: > On 11 October 2016 at 18:23, Chad Versace wrote: > > On Thu 21 Jul 2016, Emil Velikov wrote: > >> Hi all, this is weird a reminder about getting null/surfaceless updated. > > > > I started working on this recently. There&

Re: [waffle] [PATCH 1/2] Revert "wegl: add EGL image create/destroy"

dlsym is non-compatible (according to the spec) since > the symbols are part of an extension. eglGetProcAddress should be used. > > Feel free to bring it back, when needed. > > Cc: Frank Henigman > Cc: Chad Versace > --- > Hi all, this is weird a reminder about getting null/

Re: [waffle] [PATCH] egl: resolve build issue with pre EGL 1.5 headers

d failures like the one in github > > > issue #41. > > > > > > Since the ABI is baked in stone, add a local define to resolve that. > > > > > > Cc: Chad Versace > > > Fixes: f8a485e7cc7 ("egl: Improve support for robust GLES contexts on &g

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

On Wed 22 Jun 2016, Jason Ekstrand wrote: > On Tue, Jun 21, 2016 at 9:06 PM, Chad Versace > wrote: > > > On Mon 20 Jun 2016, Chad Versace wrote: > > Everyone, thanks for the lengthy discussion. The winner is... Michel's > > patch v2, which is basically Emil

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

On Thu 14 Apr 2016, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes build failure due to wl_proxy_marshal_constructor_versioned being > unresolved when building against current wayland. > > This API was introduced in wayland 1.9.91 by commit 557032e3 ("Track > protocol object versions insid

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

On Mon 20 Jun 2016, Chad Versace wrote: > On Sun 17 Apr 2016, Emil Velikov wrote: > > On 17 April 2016 at 01:41, Jason Ekstrand wrote: > > > On Sat, Apr 16, 2016 at 4:12 PM, Emil Velikov > > > wrote: > > >> > > >> On 16 April 2016 at 22:06, Ja

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

On Sun 17 Apr 2016, Emil Velikov wrote: > On 17 April 2016 at 01:41, Jason Ekstrand wrote: > > On Sat, Apr 16, 2016 at 4:12 PM, Emil Velikov > > wrote: > >> > >> On 16 April 2016 at 22:06, Jason Ekstrand wrote: > >> > >> >> Then again importing bits from other projects tend to be quite a nasty >

Re: [waffle] [PATCH 00/13] Do less validation of the context version

On Tue 14 Jun 2016, Chad Versace wrote: > On Tue 26 Apr 2016, Emil Velikov wrote: > > On 5 April 2016 at 22:58, Emil Velikov wrote: > > > Hi all, > > > > > > This is a re-spin of an ancient RFC [1] covering two (core) topics > > > - Should waffle do

Re: [waffle] [PATCH 06/12] wflinfo: add option for JSON output

On Thu 21 Apr 2016, Frank Henigman wrote: > On Fri, Apr 8, 2016 at 8:14 PM, Chad Versace wrote: > > On 01/06/2016 11:56 AM, Frank Henigman wrote: > I really hope we can keep this simple. > > I mentioned in the cover letter to this series that the next step is > to gut wflin

Re: [waffle] json, approach 2, version 2

On Thu 21 Apr 2016, Frank Henigman wrote: > Thanks Emil and Chad for reviewing my json series. All suggestions > implemented in v2, except where I replied inline. I'll hold off > sending in case there's more back-and-forth over the first set of > comments. Would also be nice if Chad merged his g

Re: [waffle] [PATCH 1/2] tests/gl_basic: Make GL symbol queries more robust

Again, with Emil's real email. On Tue 14 Jun 2016, Chad Versace wrote: > Emil, this patch fixes the regressions caused by your patch (still > uncommitted): > > [PATCH 07/13] wegl: untangle dl_can_open() and support_api() > > On Tue 14 Jun 2016, Chad Versace wrote: >

Re: [waffle] [PATCH 1/2] tests/gl_basic: Make GL symbol queries more robust

Emil, this patch fixes the regressions caused by your patch (still uncommitted): [PATCH 07/13] wegl: untangle dl_can_open() and support_api() On Tue 14 Jun 2016, Chad Versace wrote: > The rules that dictate how to properly query a GL symbol are complex. > The rules depend on the OS,

Re: [waffle] [PATCH 00/29] Rework the functionality test(s)

On Tue 14 Jun 2016, Emil Velikov wrote: > On 14 June 2016 at 18:10, Chad Versace wrote: > > On Tue 26 Apr 2016, Emil Velikov wrote: > >> Humble ping ? > > > > And an embarassedly late merge. > > > > Thanks for all the cleanups. All the patches in the

[waffle] [PATCH 1/2] tests/gl_basic: Make GL symbol queries more robust

didn't try very hard when querying a GL symbol. It tried only dlsym. If dlsym failed, then the test failed. Make gl_basic_test more robust by falling back to waffle_get_proc_address() whenever dlsym fails. Suggested-by: Emil Velikov Signed-off-by: Chad Versace --- tests/funct

[waffle] [PATCH 2/2] examples/gl_basic: Make GL symbol queries more robust

Analagous to the previous patch to tests/functional/gl_basic_test.c. Suggested-by: Emil Velikov Signed-off-by: Chad Versace --- examples/gl_basic.c | 36 ++-- 1 file changed, 30 insertions(+), 6 deletions(-) diff --git a/examples/gl_basic.c b/examples

Re: [waffle] [PATCH 00/13] Do less validation of the context version

On Tue 26 Apr 2016, Emil Velikov wrote: > Humble ping ? And an embarrasedly late reply... This year, I've taken nearly 4 months off (paternity leave + vacation + sabbatical) and was in a Vulkan crunch for the 3 months before that. My schedule has finally returned to normal. > On 5 April 2016 at

Re: [waffle] [PATCH 00/29] Rework the functionality test(s)

On Tue 26 Apr 2016, Emil Velikov wrote: > Humble ping ? And an embarassedly late merge. Thanks for all the cleanups. All the patches in the series, except patch 1, are merged. I skipped patch 1 because it introduced a single symbol, but that symbol was never used.

Re: [waffle] json, approach 2, version 2

On Thu 21 Apr 2016, Frank Henigman wrote: > Thanks Emil and Chad for reviewing my json series. All suggestions > implemented in v2, except where I replied inline. I'll hold off > sending in case there's more back-and-forth over the first set of > comments. Would also be nice if Chad merged his g

Re: [waffle] json, approach 2, version 2

On Thu 21 Apr 2016, Frank Henigman wrote: > Would also be nice if Chad merged his get-current branch > into master, as I use it in v2. My get-current branch is now merged. And Intel's Jenkins claims that it didn't regress any Piglit tests. ___ waffle ma

[waffle] [PATCH] egl: Improve support for robust GLES contexts on EGL 1.5

Allow the creation of robust GLES contexts when EGL 1.5 is available, even when EGL_EXT_create_context_robustness is not. Cc: Bas Nieuwenhuizen Cc: Emil Velikov Signed-off-by: Chad Versace --- src/waffle/egl/wegl_context.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff

Re: [waffle] json, approach 2, version 2

On Thu 21 Apr 2016, Frank Henigman wrote: [snip] > When comparing my json output to the landed json output I noticed that > the landed version omits the context flags found in the old format. > Was that deliberate? If so I'll remove it from my json. The JSON should list the context flags. It's

Re: [waffle] [PATCH 07/12] waffle: support platform-specific information

On Sun 24 Apr 2016, Frank Henigman wrote: > On Sun, Apr 24, 2016 at 6:36 AM, Emil Velikov > wrote: > > On 21 April 2016 at 21:26, Frank Henigman wrote: > >> On Fri, Jan 8, 2016 at 7:44 AM, Emil Velikov > >> wrote: > >>> On 6 January 2016 at 21:56, Frank Henigman wrote: > Add a platform h

Re: [waffle] [PATCH] egl: Support robust access contexts with EGL 1.5.

On Sat 16 Apr 2016, Emil Velikov wrote: > On 15 April 2016 at 22:04, Bas Nieuwenhuizen wrote: > > EGL 1.5 also supports the EGL_CONTEXT_OPENGL_ROBUST_ACCESS > > attribute without any extensions for both ES and non-ES. > > > > Signed-off-by: Bas Nieuwenhuizen > > --- > > src/waffle/egl/wegl_conf

Re: [waffle] [PATCH v2] wgl: don't use ARB_create_context with pre 3.2 contexts

On 04/17/2016 01:55 AM, Jose Fonseca wrote: > On 15/04/16 23:48, Emil Velikov wrote: >> Direct port of previous commit. >> >> v2: The version should be 3.2 and not 3.0 as originally. >> >> Cc: Jose Fonseca >> Cc: Ilia Mirkin >> Signed-off-by: Emil Velikov >> --- >> src/waffle/wgl/wgl_config.c

Re: [waffle] [PATCH v2] glx: don't use ARB_create_context with pre 3.2 contexts

On 04/15/2016 03:45 PM, Emil Velikov wrote: > This way if the user requests GL pre 3.2 context which lacks the > flags/extra bits which require ARB_create_context one can safely fall > back to the normal/legacy entry point. > > This resolves piglits on non 3.2 capable drivers such as classic swras

Re: [waffle] [PATCH 1/3] glx: don't use ARB_create_context with pre 3.0 contexts

On 04/15/2016 03:35 PM, Emil Velikov wrote: > On 15 April 2016 at 20:04, Chad Versace wrote: > Looking at another hunk from the spec makes me wonder: > > created. Forward-compatible contexts are defined only for OpenGL > versions 3.0 and later. > > So one ca

Re: [waffle] [PATCH 1/3] glx: don't use ARB_create_context with pre 3.0 contexts

On 04/15/2016 12:30 PM, Jose Fonseca wrote: > On 15/04/16 20:04, Chad Versace wrote: >> On 04/06/2016 02:12 AM, Jose Fonseca wrote: >>> On 05/04/16 22:45, Emil Velikov wrote: >>>> This way if the user requests GL pre 3.0 context which lacks the >&

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

On 04/15/2016 09:36 AM, Jason Ekstrand wrote: > On Fri, Apr 15, 2016 at 3:03 AM, Emil Velikov > wrote: > > On 15 April 2016 at 03:32, Michel Dänzer > wrote: > > On 15.04.2016 11:14, Michel Dänzer wrote: > >> On 14.04.2016 22

Re: [waffle] [PATCH 1/3] glx: don't use ARB_create_context with pre 3.0 contexts

On 04/06/2016 02:12 AM, Jose Fonseca wrote: > On 05/04/16 22:45, Emil Velikov wrote: >> This way if the user requests GL pre 3.0 context which lacks the >> flags/extra bits which require ARB_create_context one can safely fall >> back to the normal/legacy entry point. >> >> This resolves piglits on

Re: [waffle] [PATCH 3/3] tests/gl_basic_test: query context flags only for desktop GL 3.0 or later

On 04/05/2016 02:45 PM, Emil Velikov wrote: > Spotted while attemting to use classic swrast with waffle. > > Signed-off-by: Emil Velikov > --- > tests/functional/gl_basic_test.c | 36 +++- > 1 file changed, 27 insertions(+), 9 deletions(-) Emil, I pushed this pat

Re: [waffle] [PATCH 4/6] egl: Add support for robust access contexts.

On 04/06/2016 08:59 AM, Bas Nieuwenhuizen wrote: > Signed-off-by: Bas Nieuwenhuizen > --- > src/waffle/egl/wegl_config.c | 16 > src/waffle/egl/wegl_context.c | 9 + > src/waffle/egl/wegl_display.c | 1 + > src/waffle/egl/wegl_display.h | 1 + > 4 files changed, 27 in

Re: [waffle] [PATCH 1/6] wcore: Add support for robust access contexts.

Thanks Bas. I pushed the patches to master. ___ waffle mailing list waffle@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 1/6] wcore: Add support for robust access contexts.

On 04/11/2016 01:11 PM, Emil Velikov wrote: > On 6 April 2016 at 16:59, Bas Nieuwenhuizen wrote: >> Signed-off-by: Bas Nieuwenhuizen >> --- >> include/waffle/waffle.h | 4 >> man/waffle_config.3.xml | 24 >> src/waffle/core/wcore_config_at

Re: [waffle] [PATCH 1/6] wcore: Add support for robust access contexts.

o it myself as a follow-up commit. By the way, the series is Reviewed-by: Chad Versace There are some problems with the EGL patch, but those problems can be fixed in follow-up work. I'll send my comments to that patch soon. ___ waffle mailing li

Re: [waffle] [PATCH 6/6] nacl: Add an error when trying to use a robust access context.

On 04/06/2016 09:59 PM, Tapani Pälli wrote: > This looks correct to me; > > Reviewed-by: Tapani Pälli > > Note that following patch is required to build waffle nacl support on any > recent nacl sdk versions: > > https://lists.freedesktop.org/archives/waffle/2015-October/001266.html Tapani, is

Re: [waffle] [PATCH 06/12] wflinfo: add option for JSON output

On 01/06/2016 11:56 AM, Frank Henigman wrote: > With "-f json" wflinfo will now print the result of > waffle_display_info_json(). > > Signed-off-by: Frank Henigman > --- > src/utils/wflinfo.c | 40 > 1 file changed, 36 insertions(+), 4 deletions(-) > > d

Re: [waffle] [PATCH 04/12] core: add JSON library

On 01/08/2016 04:17 AM, Emil Velikov wrote: > On 6 January 2016 at 21:56, Frank Henigman wrote: >> A small library for building JSON strings. >> >> Signed-off-by: Frank Henigman >> --- >> src/waffle/CMakeLists.txt | 1 + >> src/waffle/core/json.c| 235 >> ++

Re: [waffle] [PATCH 03/12] core: store current context in wcore_display

n 01/08/2016 04:15 AM, Emil Velikov wrote: > On 6 January 2016 at 21:56, Frank Henigman wrote: >> For core functions that need to know the current context, like the >> forthcoming wflinfo-like function. >> >> Signed-off-by: Frank Henigman >> --- >> src/waffle/api/waffle_gl_misc.c | 11 +++---

Re: [waffle] [PATCH v3] wflinfo: Add a --format flag that prints json or the classic output

On 01/14/2016 04:42 PM, baker.dyla...@gmail.com wrote: > From: Dylan Baker > > Adds a JSON formatted output. > > This format doesn't honor the --verbose flag, it always provides all > relevant information. > > The option parsing code is a slightly adapted version of code Frank > Henigman wrote.

Re: [waffle] [PATCH] cmake: use the EGL CFLAGS in the waffle CFLAGS

On 02/11/2016 03:21 PM, Mircea Gherzan wrote: > Without them, the build will fail with a recent Mesa from the master > branch on a system without the X headers: > > include/EGL/eglplatform.h:119:22: fatal error: X11/Xlib.h: No such file > or directory > > Signed-off-by: Mircea Gherzan Yes, beca

[waffle] I'm back from paternity leave

Hi everyone, I abruptly left for paternity leave in early February, and now I'm a father! My little boy is named Lucas, and he's incredible. While on leave, I had little time to spare for non-baby activities, so it's been over two months since I read any code-related mail. I returned from patern

[waffle] Review Latency

Hi everyone, I'm aware there are a few dozen patches on the mailing list awaiting review. I apologize for the latency. In my other role as a driver developer, I'm occupied trying to hit a major milestone before end of month. I expect that I'll continue to have too little time to dedicate to waffle

Re: [waffle] [PATCH v2 0/4] Add JSON interface to wflinfo

On 01/05/2016 11:46 AM, baker.dyla...@gmail.com wrote: > From: Dylan Baker > > This is a second go at this series. > > Notable changes from the first version: > - Style cleanups as suggested by Chad and Frank > - Restructuring the JSON output to have nested dictionaries for waffle > and OpenGL

Re: [waffle] [PATCH v2 4/4] wflinfo.c: Add a --json flag that prints json

On 01/05/2016 11:46 AM, baker.dyla...@gmail.com wrote: > From: Dylan Baker Please use 'wflinfo', not 'wflinfo.c', as the commit's subject prefix. > > This adds some code to print a JSON formatted version of data provided > by wflinfo. > > Signed-off-by: Dylan Baker > > v2: - Add -j short opt

[waffle] Approaches to JSON

There are two sets of very different json patchsets on the list. Each has advantages and disadvantages. Dylan's patchset duplicates a small amount of code. And it doesn't teach wflinfo to print any additional info, such as GLX or EGL specific info. However, the patchset is short, sweet, has no maj

Re: [waffle] [PATCH 02/12] core: store context API in wcore_context

On 01/06/2016 11:56 AM, Frank Henigman wrote: > Facilitates api-specific code in core functions, like the forthcoming > wflinfo-like function. > > Signed-off-by: Frank Henigman > --- > src/waffle/core/wcore_context.h | 2 ++ > 1 file changed, 2 insertions(+) > struct wcore_context { > s

Re: [waffle] [PATCH v2 3/4] wflinfo.c: split version, renderer, and vendor checks

quot; to "const char *name" (Frank) > --- > src/utils/wflinfo.c | 50 -- > 1 file changed, 36 insertions(+), 14 deletions(-) Patches 1-3 are Reviewed-by: Chad Versace For patch 4, I'm waiting for you to address the `i != flag_cou

Re: [waffle] [PATCH 01/12] core: store platform type in wcore_platform

On 01/08/2016 04:00 AM, Emil Velikov wrote: > Hi Frank, > > On 6 January 2016 at 21:56, Frank Henigman wrote: >> Facilitates platform-specific code in core functions, like the forthcoming >> wflinfo-like function. >> >> Signed-off-by: Frank Henigman >> --- >> src/waffle/api/waffle_init.c |

Re: [waffle] [PATCH v2 3/4] wflinfo.c: split version, renderer, and vendor checks

On 01/06/2016 02:55 PM, Dylan Baker wrote: > > > On Wed, Jan 6, 2016 at 1:30 PM, Emil Velikov > wrote: > > On 5 January 2016 at 19:46, > wrote: > > From: Dylan Baker > > > +static co

Re: [waffle] [RFC 3/3] wflinfo.c: Add a --json flag that prints json

On 12/31/2015 09:51 AM, Dylan Baker wrote: > > > On Wed, Dec 30, 2015 at 4:32 PM, Chad Versace <mailto:chad.vers...@intel.com>> wrote: > > On 12/27/2015 07:49 AM, Frank Henigman wrote: > > On Wed, Dec 16, 2015 at 8:37 PM, <mailto:baker.dyla...@gmail.

Re: [waffle] [RFC 3/3] wflinfo.c: Add a --json flag that prints json

On 12/27/2015 07:49 AM, Frank Henigman wrote: > On Wed, Dec 16, 2015 at 8:37 PM, wrote: >> From: Dylan Baker >> >> This adds some code to print a JSON formatted version of data provided >> by wflinfo. >> >> Signed-off-by: Dylan Baker >> --- >> src/utils/wflinfo.c | 174 >>

Re: [waffle] [RFC 2/3] wflinfo.c: split version, renderer, and vendor checks

On 12/29/2015 02:37 PM, Dylan Baker wrote: > Okay, I can fix that too. > > On Sun, Dec 27, 2015 at 7:43 AM, Frank Henigman > wrote: > > On Wed, Dec 16, 2015 at 8:37 PM, > wrote: > > From: Dylan Baker

Re: [waffle] [RFC 1/3] wflinfo.c: split out flags struct

On 12/16/2015 05:37 PM, baker.dyla...@gmail.com wrote: > From: Dylan Baker > > This is groundwork for adding a json interface to wflinfo. > --- > src/utils/wflinfo.c | 19 +++ > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/src/utils/wflinfo.c b/src/utils/wfl

Re: [waffle] [PATCH 3/4] glx: remove dl_can_open restriction for supports_context_api()

On Tue 01 Sep 2015, Emil Velikov wrote: > This seems like unnecessary book-keeping which makes the topic > "supported by the display" vs "there is a library that one can manage" > more convoluted than needed. > > One can safely assume that if the GLX implementation exposes the > extension(s) then

Re: [waffle] [PATCH 2/4] wcore: don't parse/validate the exact major/minor version

On Tue 01 Sep 2015, Emil Velikov wrote: > Keeping track what is and isn't the correct version at any given time > sounds unfeasable. > > On one hand currently we allow any random value as minor for ES2 and > ES3, whist for GL we allow any values as long as they are >= 1.0 I agree, that inconsiste

Re: [waffle] [PATCH 1/4] wcore: do not use get_with_default() when default_value is the same as value

On Tue 01 Sep 2015, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > src/waffle/core/wcore_config_attrs.c | 18 ++ > 1 file changed, 6 insertions(+), 12 deletions(-) Thanks. This patch is pushed to the master branch. ___ waffle

Re: [waffle] [PATCH] glx: provide our own GLX_ARB_create_context_profile defines

On Tue 01 Sep 2015, Emil Velikov wrote: > As of recently the official Nvidia driver does provide its own GL > headers. Although they seem to be missing the defines needed to manage > desktop GL contexts. > > Include them for now to fix the build as mentioned in github issue #31. > Tested against v

Re: [waffle] CI, static analisys, tests and waffle

On Sat 05 Sep 2015, Emil Velikov wrote: > On 3 September 2015 at 21:27, Chad Versace wrote: > > Yes, I think this is worth doing. I prefer to see the cleanups arrive in > > this order, but it's not a strong preference: > > > > *. Fix bugs and leaks as they&#

Re: [waffle] CI, static analisys, tests and waffle

On Tue 01 Sep 2015, Emil Velikov wrote: > Hello all, > > Not too long ago I had the crazy idea of using some of the free > utilities out there with waffle. > > For example Coverity provides a free scan to open-source projects, > which nicely integrates with Travis-CI, > The latter of which suppor

[waffle] [ANNOUNCE] Waffle 1.5.2

it uses udev to search for a sensible DRM device node. (See 8d20f3a). Changes since 1.5.1 --- Bernhard Rosenkränzer (1): android: Don't specify -std=gnu99 for C++ builds -- it breaks clang Chad Versace (3): gbm: Fix crash when eglChooseConfig fails gbm: A

Re: [waffle] [PATCH] gbm: allow user to specify device

On Sat 15 Aug 2015, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/waffle/gbm/wgbm_display.c | 8 > 1 file changed, 8 insertions(+) Hi Ilia, The patch, as-is, silently falls back to searching udev if it fails to open the device path given in the environment. I think that's

Re: [waffle] [PATCH] linux: Use full libGLES*.so.[12] SONAMEs

On Thu 04 Jun 2015, Michel Dänzer wrote: > On 03.06.2015 03:19, Emil Velikov wrote: > > On 2 June 2015 at 18:13, Chad Versace wrote: > >> On Mon 01 Jun 2015, Michel Dänzer wrote: > >>> From: Michel Dänzer > >>> > >>> The libGLES*.so symlinks

Re: [waffle] [PATCH] linux: Use full libGLES*.so.[12] SONAMEs

here. > * Remove stale comment line > > Signed-off-by: Michel Dänzer Emil, does this patch look good to you? It looks good to me. Reviewed-by: Chad Versace ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 00/10] null platform WIP

Frank, sorry the late reply. On Mon 30 Mar 2015, Frank Henigman wrote: > This patch set adds a new platform: WAFFLE_PLATFORM_NULL. > This platform uses EGL_PLATFORM_NULL, KHR_surfaceless_context, > EXT_image_dma_buf_import and gbm. > In this platform a waffle window contains gbm buffers and sets u

Re: [waffle] [PATCH 1/4] waffle: put waffle_enum items in a macro

On Wed 06 May 2015, Jordan Justen wrote: > On 2015-05-05 21:18:52, Chad Versace wrote: > > Since the only dynamically generated portion of waffle.h (for now, at > > least) will be the enum definitions, there's no reason to use XML if you > > feel it's overkill. (I&#x

Re: [waffle] [PATCH 3/4] waffle: add waffle_string_to_enum()

On Thu 23 Apr 2015, Emil Velikov wrote: > On 22 April 2015 at 19:03, Frank Henigman wrote: > > From: Frank Henigman > > > > Add waffle_string_to_enum() which, given a string, returns the > > corresponding enum value. > > Since the main use is expected to be parsing command lines, > > the string c

  1   2   3   4   5   6   >