Re: [Warzone-dev] assert & return macro

2009-02-01 Thread Per Inge Mathisen
On Sun, Feb 1, 2009 at 11:55 PM, Giel van Schijndel wrote: > I'd rather not use assert(false) as on some systems assert() is used to > produce a nice GUI message. E.g. on Windows you'll get a message like > "assertion $expression failed, abort, ignore, attach debugger?". > Deciding which of those

Re: [Warzone-dev] assert & return macro

2009-02-01 Thread Giel van Schijndel
On Sat, Jan 31, 2009 at 11:45:11PM +0100, Per Inge Mathisen wrote: > No. There are in fact three places now that the expression result is checked: > 1) Checking if we should log an error > 2) The assert() > 3) The return condition > > In my patch I only cache it in the first case for the last case