Re: [PATCH 2/2 weston v6] desktop-shell: Implement panel window list.

2012-10-04 Thread Scott Moreau
On Thu, Oct 4, 2012 at 5:07 PM, Scott Moreau wrote: > This patch uses the special surface_data interface to send surface_data to > the > shell. The shell then uses this information to render a window list in the > panel. > > --- > > v6: > > * Rebased on latest master > * Clean up window list when

[PATCH 2/2 weston v6] desktop-shell: Implement panel window list.

2012-10-04 Thread Scott Moreau
This patch uses the special surface_data interface to send surface_data to the shell. The shell then uses this information to render a window list in the panel. --- v6: * Rebased on latest master * Clean up window list when desktop-shell exits * Renamed some functions to better fit their argume

[PATCH 2/2] compositor-wayland: Use some nicer border sizes.

2012-10-04 Thread John Kåre Alsaker
--- src/compositor-wayland.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 2194010..8ddebf2 100644 --- a/src/compositor-wayland.c +++ b/src/compositor-wayland.c @@ -838,10 +838,10 @@ wayland_compositor_create(str

[PATCH 1/2] compositor-wayland: Make sure border fields are set before wayland_compositor_create_output and document some function dependencies.

2012-10-04 Thread John Kåre Alsaker
--- src/compositor-wayland.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 05f21c2..2194010 100644 --- a/src/compositor-wayland.c +++ b/src/compositor-wayland.c @@ -237,11 +237,6 @@ create_border(struct w

Pixman no-longer builds with gcc v4.6.x

2012-10-04 Thread darxus
https://bugs.freedesktop.org/show_bug.cgi?id=55630 Workarounds: 1) Build with the last good commit: 7a9c2d586b2349b5e17966a96d7fe8c390abb75a 2) Upgrade gcc. 3) Build with clang instead of gcc, although that may have other problems. '"export CC=clang" before autogen.sh/configure' 'it's bes

Re: [PATCH libxkbcommon v2 1/2] makekeys: use GNU gperf to generate perfect hashtables

2012-10-04 Thread David Herrmann
Hi Bill On Thu, Oct 4, 2012 at 6:46 PM, Bill Spitzak wrote: > > > David Herrmann wrote: >> >> Hi Bill >> >> On Thu, Oct 4, 2012 at 6:40 PM, Bill Spitzak wrote: >>> >>> David Herrmann wrote: >>> > So since makekeys is ugly and gperf is a bit excessive, maybe we should > just keep it simpl

Re: [PATCH libxkbcommon v2 1/2] makekeys: use GNU gperf to generate perfect hashtables

2012-10-04 Thread Bill Spitzak
David Herrmann wrote: Hi Bill On Thu, Oct 4, 2012 at 6:40 PM, Bill Spitzak wrote: David Herrmann wrote: So since makekeys is ugly and gperf is a bit excessive, maybe we should just keep it simple, what do you think? Works all very nice here! Thanks, I am all in favor of this approach. Re

Re: [PATCH libxkbcommon v2 1/2] makekeys: use GNU gperf to generate perfect hashtables

2012-10-04 Thread David Herrmann
Hi Bill On Thu, Oct 4, 2012 at 6:40 PM, Bill Spitzak wrote: > David Herrmann wrote: > >>> So since makekeys is ugly and gperf is a bit excessive, maybe we should >>> just keep it simple, what do you think? >> >> >> Works all very nice here! Thanks, I am all in favor of this approach. >> Reviewed-

Re: [PATCH libxkbcommon v2 1/2] makekeys: use GNU gperf to generate perfect hashtables

2012-10-04 Thread Bill Spitzak
David Herrmann wrote: So since makekeys is ugly and gperf is a bit excessive, maybe we should just keep it simple, what do you think? Works all very nice here! Thanks, I am all in favor of this approach. Reviewed-by: David Herrmann No need to resend for the small fixes I suggested, though. I

Re: [PATCH] compositor-wayland: Create border after creating the OpenGL context.

2012-10-04 Thread Kristian Høgsberg
On Wed, Oct 03, 2012 at 06:02:22PM +0200, John Kåre Alsaker wrote: Yes, that works better, thanks. Kristian > --- > src/compositor-wayland.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c > index d665641..05f21c2 1

Re: [PATCH] tests: add keyboard test

2012-10-04 Thread Kristian Høgsberg
On Mon, Oct 01, 2012 at 03:21:16PM -0700, U. Artie Eoff wrote: > From: "U. Artie Eoff" Thanks Artie, this one and the previous three tests all committed. I really appreciate the work, it's good to see the test suite become more useful. Kristian > Signed-off-by: U. Artie Eoff > --- > tests/Ma

Re: [PATCH] desktop-shell: destroy data before exiting.

2012-10-04 Thread Kristian Høgsberg
On Tue, Oct 02, 2012 at 09:12:35PM -0700, U. Artie Eoff wrote: > From: "U. Artie Eoff" > > desktop-shell never returned from display_run() since it > was essentially killed when weston exited. To fix this, > it is necessary to watch for EPOLLHUP in window.c so that > toytoolkit clients will retu

Re: [PATCH 1/2] simple-shm: Don't attach the buffer to the surface for every redraw

2012-10-04 Thread Kristian Høgsberg
On Tue, Oct 02, 2012 at 06:03:14PM +0100, Rob Bradford wrote: > From: Rob Bradford > > This will allow us to change just a sub region of the buffer. Good changes, makes simple-shm a more useful test case. Committed. Kristian > --- > clients/simple-shm.c | 2 +- > 1 file changed, 1 insertion

Re: [PATCH 1/4] editor: fix assert to take preedit string into account

2012-10-04 Thread Kristian Høgsberg
On Tue, Oct 02, 2012 at 11:06:51AM +0200, Philipp Brüschweiler wrote: Thanks, all four fixes applied. Kristian > --- > clients/editor.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/clients/editor.c b/clients/editor.c > index 5643338..c656b06 100644 > --- a/clients

Re: [PATCH] Fix spelling errors

2012-10-04 Thread Kristian Høgsberg
On Sat, Sep 29, 2012 at 03:13:56PM +0200, Martin Olsson wrote: Thanks Martin, applied. Kristian > --- > clients/eventdemo.c |4 ++-- > protocol/text.xml|2 +- > src/compositor-drm.c |2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/clients/eventdemo.c

Re: [PATCH libxkbcommon v2 1/2] makekeys: use GNU gperf to generate perfect hashtables

2012-10-04 Thread Ran Benita
On Thu, Oct 04, 2012 at 04:58:50PM +0200, David Herrmann wrote: > Hi Ran > > On Wed, Oct 3, 2012 at 10:18 AM, Ran Benita wrote: > > [snip] > > > So since makekeys is ugly and gperf is a bit excessive, maybe we should > > just keep it simple, what do you think? > > Indeed. Thanks a lot for revi

Re: [PATCH weston 3/3] xwm: Plug kill signal for killing X apps

2012-10-04 Thread Kristian Høgsberg
On Thu, Sep 27, 2012 at 05:48:37PM +0300, Tiago Vignatti wrote: > Xeyes is the counter-example that fails on that heuristic and won't be caught > on kill binding. This and the last two patches should fix: > > https://bugs.freedesktop.org/show_bug.cgi?id=53679 > > Signed-off-by: Tiago Vignatti

Re: [PATCH weston 2/3] compositor: Add kill signal

2012-10-04 Thread Kristian Høgsberg
On Thu, Sep 27, 2012 at 05:48:36PM +0300, Tiago Vignatti wrote: > For now it's being emitted only on the desktop shell kill binding. Ok, let's go with this approach. Kristian > Signed-off-by: Tiago Vignatti > --- > src/compositor.c |1 + > src/compositor.h |1 + > src/shell.c |

Re: [PATCH weston 1/3] shell: Skip malicious clients on kill binding

2012-10-04 Thread Kristian Høgsberg
On Thu, Sep 27, 2012 at 05:48:35PM +0300, Tiago Vignatti wrote: > Also remove superfluous variables. Committed with a tweak to the comments: it's not malicious clients, in fact it's the opposite, it's clients that we've forked ourselves and typically trust more than the average client. Kristian

Re: [PATCH libxkbcommon v2 1/2] makekeys: use GNU gperf to generate perfect hashtables

2012-10-04 Thread David Herrmann
And one minor style-fix below: On Thu, Oct 4, 2012 at 4:58 PM, David Herrmann wrote: >> #include "xkbcommon/xkbcommon.h" >> #include "utils.h" >> -#include "ks_tables.h" >> #include "keysym.h" >> +#include "ks_tables.h" >> + >> +static int compare_by_keysym(const void *a, const void *b) >> +{

Re: [PATCH weston] shell: Start the desktop-shell client in the idle handler

2012-10-04 Thread Kristian Høgsberg
On Tue, Sep 25, 2012 at 05:57:01PM +0300, Tiago Vignatti wrote: > It fix https://bugs.freedesktop.org/show_bug.cgi?id=55259 Looks good, committed. Kristian > Signed-off-by: Tiago Vignatti > --- > src/shell.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff -

Re: [PATCH libxkbcommon v2 1/2] makekeys: use GNU gperf to generate perfect hashtables

2012-10-04 Thread David Herrmann
Hi Ran On Wed, Oct 3, 2012 at 10:18 AM, Ran Benita wrote: [snip] > So since makekeys is ugly and gperf is a bit excessive, maybe we should > just keep it simple, what do you think? Indeed. Thanks a lot for reviewing though. Just some comments on your patch below: > From 8fb5efb045b7207b010c97

Re: [PATCH] tests: Remove GLfloat usage.

2012-10-04 Thread John Kåre Alsaker
On Thu, Oct 4, 2012 at 8:22 AM, Pekka Paalanen wrote: > On Wed, 3 Oct 2012 17:30:05 +0200 > John Kåre Alsaker wrote: > >> --- >> tests/matrix-test.c | 3 +-- >> tests/surface-test.c | 2 +- >> tests/test-client.c | 3 +-- >> 3 files changed, 3 insertions(+), 5 deletions(-) > > Hi John, > > Wi

Re: [PATCH weston 4/8] shell: Update bindings to conform to pointer axis protocol

2012-10-04 Thread Jonas Ådahl
On Thu, Oct 4, 2012 at 1:33 PM, Daniel Stone wrote: > Hi, > > On 4 October 2012 17:06, Jonas Ådahl wrote: >> On Thu, Oct 4, 2012 at 12:47 AM, Daniel Stone wrote: >>> I agree it makes perfect sense, but note that axis events are already >>> fixed-point, so you already get fairly fluid motion (mot

Re: [PATCH weston 4/8] shell: Update bindings to conform to pointer axis protocol

2012-10-04 Thread Daniel Stone
Hi, On 4 October 2012 17:06, Jonas Ådahl wrote: > On Thu, Oct 4, 2012 at 12:47 AM, Daniel Stone wrote: >> I agree it makes perfect sense, but note that axis events are already >> fixed-point, so you already get fairly fluid motion (motion in units >> of 1/256th of a wheel 'chunk', i.e. already s

Re: [PATCH weston 4/8] shell: Update bindings to conform to pointer axis protocol

2012-10-04 Thread Jonas Ådahl
On Thu, Oct 4, 2012 at 12:47 AM, Daniel Stone wrote: > Hi, > > On 29 September 2012 19:31, Jonas Ådahl wrote: >> Ok, so what I'm trying to do is to enable what people call "smooth >> scrolling" on an input level, meaning that scrolling is not based on >> discrete arbitrary "steps" but on a more f

Re: [RFC Wayland 2/2] protocol: change input and opaque region interface

2012-10-04 Thread Pekka Paalanen
On Wed, 3 Oct 2012 16:14:16 +0300 Pekka Paalanen wrote: > This change breaks the protocol. > > Now that set_input_region and set_opaque_region no longer have to > describe the region atomically in one request, we can simplify the > protocol by not using wl_region for them. > > Instead, the new

Re: [PATCH] tests: Remove GLfloat usage.

2012-10-04 Thread Pekka Paalanen
On Wed, 3 Oct 2012 17:30:05 +0200 John Kåre Alsaker wrote: > --- > tests/matrix-test.c | 3 +-- > tests/surface-test.c | 2 +- > tests/test-client.c | 3 +-- > 3 files changed, 3 insertions(+), 5 deletions(-) Hi John, With the reservation, that GLfloat is always the same as float type in C

[PATCH 2/2 weston v5] desktop-shell: Implement panel window list.

2012-10-04 Thread Scott Moreau
This patch uses the special surface_data interface to send surface_data to the shell. The shell then uses this information to render a window list in the panel. --- v5: * Removed unneeded calls in map(). The call to send_output_mask() in weston_surface_update_output_mask() takes care of sendi

[PATCH 1/2 weston v4] desktop-shell: Install protocol for surface_data objects.

2012-10-04 Thread Scott Moreau
This patch introduces a new surface_data_manager interface that allows the compositor to send surface data to the shell client, using the accompanying surface_data object interface. This allows the shell client to receive information about surfaces to build a window list, for example. --- Bumped