Re: [PATCH v2] Building: update the Raspberry Pi weston section

2013-09-17 Thread Pekka Paalanen
On Tue, 17 Sep 2013 21:16:38 +0200 Silvan Jegen wrote: > Update the Weston autogen.sh flags and make the accompanying text less > confusing. > --- > raspberrypi.html | 21 +++-- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/raspberrypi.html b/raspberrypi.h

[PATCH 9/9] improve hotplug remove a output in clone mode

2013-09-17 Thread Xiong Zhang
primary output is A, clone output is B first situation: if the event sequence is A's flip event, A's remove event, B's flip event. Then in the B's flip event handler, because A is destroied, B can't get a correct primary output A to release fb. So A's remove event must wait B's flip event. seco

[PATCH 8/9] hot plug remove a output in clone mode

2013-09-17 Thread Xiong Zhang
if removed output is clone output, just delete this output if removed output is primary output, find a new primary output and adjust clone output's mode necessary Signed-off-by: Xiong Zhang --- src/compositor-drm.c | 57 +++- 1 file changed, 56 ins

[PATCH 7/9] maximize and fullscreen support in clone mode

2013-09-17 Thread Xiong Zhang
App can specify the output for maximize and fullscreen show, limited the output to primary output when clone mode enabled to avoid App assign a fault output Signed-off-by: Xiong Zhang --- src/shell.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/shell.c b/src/sh

[PATCH 6/9] hot plug add a output in clone mode

2013-09-17 Thread Xiong Zhang
if added output used as primary output, old primary output's fb should be freed and recreated so that when this old primary output is used as priamry output again in future, it has a clean state; if added output is used as clone output, adjust it mode necessary and set it mode At the same time, al

[PATCH 5/9] deal with VT switch in clone mode

2013-09-17 Thread Xiong Zhang
clone output should use primary output's fb to restore mode Signed-off-by: Xiong Zhang --- src/compositor-drm.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 0b9ab45..a9d2ab5 100644 --- a/src/compositor-drm

[PATCH 4/9] output gl repaint in clone mode

2013-09-17 Thread Xiong Zhang
Only repsone to primary output repaint request; Primary output and clone output share the same frame buffer, once primary output do page flip, clone output will do page flip also. When both primary output and clone output finish the page flip, the fb obj can be released. Signed-off-by: Xiong Zhang

[PATCH 3/9] one pointer exist in only one output

2013-09-17 Thread Xiong Zhang
one pointer can exist in only one output, once find the output, break the loop Signed-off-by: Xiong Zhang --- src/input.c | 7 +-- src/shell.c | 2 ++ src/zoom.c | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/input.c b/src/input.c index 85b772f..6b26f3c 100644 ---

[PATCH 2/9] find primary output during drm_compositor_create in clone mode

2013-09-17 Thread Xiong Zhang
the output with most width will be selected as primary output. primary output occupy the first position in weston_compositor->output_list if clone_output's height is larger than primary_output's height clone_output's mode should be changed, otherwise the setting mode for clone_output will fail. ch

[PATCH 1/9] add multi-screen-mode option to weston.ini

2013-09-17 Thread Xiong Zhang
multi-screen-mode=clone/extend to control multi screen mode Signed-off-by: Xiong Zhang --- src/compositor.c | 9 + src/compositor.h | 7 +++ weston.ini | 1 + 3 files changed, 17 insertions(+) diff --git a/src/compositor.c b/src/compositor.c index 6a53984..f9e9ba1 100644 --- a

[PATCH 0/9] implement multi screen clone mode in drm-backend.so

2013-09-17 Thread Xiong Zhang
the theory for clone mode is: all the outputs share the same fb, when primary output do modeset and pageflip, clone output do this also. I fulfill repaint, VT switch and hotplug function. I don't implement dynamical setting output's mdoe. Xiong Zhang (9): add multi-screen-mode option to westo

[PATCH] client: fix an inconsistency in documentation

2013-09-17 Thread Chang Liu
The errno is set to EAGAIN when there are undispatched events, according to L1066 of wayland-client.c. --- src/wayland-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-client.c b/src/wayland-client.c index 04d988b..d043459 100644 --- a/src/wayland-client.c +

[PATCH] client: fix an inconsistency in documentation

2013-09-17 Thread Chang Liu
The errno is set to EAGAIN when there are undispatched events, according to L1066 of wayland-client.c. --- src/wayland-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-client.c b/src/wayland-client.c index 04d988b..d043459 100644 --- a/src/wayland-client.c +

Re: [PATCH 1/2] utils: Document wl_container_of

2013-09-17 Thread Aaron Faanes
--- Here's the full patch with those changes applied. This uses \comment{} as well, so it's dependent on that patch. src/wayland-util.h | 35 +++ 1 file changed, 35 insertions(+) diff --git a/src/wayland-util.h b/src/wayland-util.h index aa74512..68d91e2 100644 -

[PATCH wayland] doc: Slight tweaks to wl_listener

2013-09-17 Thread Aaron Faanes
Prefer \comment over // in code blocks for consistency's sake and keep variable definitions separated by a line from the rest of the body. --- src/wayland-server.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/wayland-server.h b/src/wayland-server.h index 997e6

[PATCH wayland] doc: Create \comment alias for C-style comments

2013-09-17 Thread Aaron Faanes
Since /* */ do not nest, documentation is forced to either use C++ style // comments or some other foreign notation. This commit provides an alias that allows C-style comments to be introduced in code blocks that support aliases. It should be noted that this macro will not work within \code blocks

Re: [PATCH 6/6] utils: Document wl_list methods

2013-09-17 Thread Aaron Faanes
On Tue, Sep 17, 2013 at 12:15 AM, Kristian Høgsberg wrote: > On Sun, Sep 15, 2013 at 01:37:11PM -0500, Aaron Faanes wrote: > > +/** Inserts the specified element directly after the specified list > node. > > + * > > + * \param list the list that will be directly previous to \c elm > > + * \param e

Re: [PATCH 5/6] utils: Ensure wl_list's doxygen formats properly

2013-09-17 Thread Bill Spitzak
Doxygen itself can parse nested C comments. So a solution I found is this: #ifdef THIS_IS_NOT_DEFINED /** This is some documentation. * Example: * \code * /* look this is a c-style comment! */ * \endcode */ #endif Unfortunately, it doesn't seem possible to get Doxygen not to escape the amp

[PATCH v2] Building: update the Raspberry Pi weston section

2013-09-17 Thread Silvan Jegen
Update the Weston autogen.sh flags and make the accompanying text less confusing. --- raspberrypi.html | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/raspberrypi.html b/raspberrypi.html index 44d9ce4..153b8a2 100644 --- a/raspberrypi.html +++ b/raspberr

Re: [PATCH 5/6] utils: Ensure wl_list's doxygen formats properly

2013-09-17 Thread Kristian Høgsberg
On Tue, Sep 17, 2013 at 1:47 AM, Aaron Faanes wrote: > On Tue, Sep 17, 2013 at 12:09 AM, Kristian Høgsberg > wrote: >> >> On Sun, Sep 15, 2013 at 01:37:10PM -0500, Aaron Faanes wrote: >> > This changes the "struct foo" mentions to use , which appears as >> > monospaced font. This also wraps code

Re: Absolute coordinates using "wl_shell_surface_set_transient"

2013-09-17 Thread Bill Spitzak
On 09/17/2013 01:37 AM, Tarnyko wrote: (BTW, it would be great if you had an opinion/insight on this matter) My opinion? Clients should be able to directly set the transform from their surfaces to compositor space. However I don't think my opinion is going to influence anything here. _

Re: [PATCH weston] xwm: set the window's shsurf pointer to NULL on unmap handling

2013-09-17 Thread Giulio Camuffo
This fixes the bug found by Axel ( http://lists.freedesktop.org/archives/wayland-devel/2013-September/011066.html ). 2013/9/17 Giulio Camuffo > the unmap event will be followed by the deletion of the weston_surface, > so the shell_surface will also be deleted by the shell. Having removed > the

[PATCH weston] xwm: set the window's shsurf pointer to NULL on unmap handling

2013-09-17 Thread Giulio Camuffo
the unmap event will be followed by the deletion of the weston_surface, so the shell_surface will also be deleted by the shell. Having removed the surface_destroy_listener, the surface_destroy callback doesn't get called, so reset the value of shsurf here. --- src/xwayland/window-manager.c | 1 +

Re: Absolute coordinates using "wl_shell_surface_set_transient"

2013-09-17 Thread Giulio Camuffo
It's a Weston commit, ca43f09. 2013/9/17 Tarnyko > Great ! Do you by chance have the reference of the patch, and know if it's > applied on the Wayland, Weston, Xorg... repository ? > Regards > Axel Davy writes: > >> Did you test with git master? There has been a patch recently about this. >> Ax

Re: Absolute coordinates using "wl_shell_surface_set_transient"

2013-09-17 Thread Axel Davy
Yes: http://cgit.freedesktop.org/wayland/weston/commit/?id=ca43f0942e23356a0a0f3e08e4d20a8a31b4d629 Axel Davy On Tue, 17 Sep 2013, Tarnyko wrote: Great ! Do you by chance have the reference of the patch, and know if it's applied on the Wayland, Weston, Xorg... repository ? Regards Axel Davy

Re: Absolute coordinates using "wl_shell_surface_set_transient"

2013-09-17 Thread Tarnyko
Great ! Do you by chance have the reference of the patch, and know if it's applied on the Wayland, Weston, Xorg... repository ? Regards Axel Davy writes: Did you test with git master? There has been a patch recently about this. Axel Davy Le 17/09/2013 10:37, Tarnyko a écrit : Hi Giulio

[PATCH v3] Restoring alpha after the shell effects.

2013-09-17 Thread Axel Davy
After the fade or zoom effects, alpha could not have been 1.0, preventing not redrawing behind opaque windows. This patch add a reset function in weston_surface_animation to reset some variables the effects affect. Signed-off-by: Axel Davy --- src/animation.c | 24 1 fi

Re: Absolute coordinates using "wl_shell_surface_set_transient"

2013-09-17 Thread Axel Davy
Did you test with git master? There has been a patch recently about this. Axel Davy Le 17/09/2013 10:37, Tarnyko a écrit : Hi Giulio, Bill, We were originally investigating a problem happening when using X/GTK applications under XWayland ; most of the menus appeared badly positioned when they

[PATCH] input: Fix trailing whitspaces and indent.

2013-09-17 Thread Stefan Schmidt
Just some cosmetics to conform to the wayland coding style. Signed-off-by: Stefan Schmidt --- src/input.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/input.c b/src/input.c index 9c30460..fb5bfee 100644 --- a/src/input.c +++ b/src/input.c @@ -238,7 +238,7

Re: [PATCH 4/4] Added tests for the vertex clipping code.

2013-09-17 Thread Sam Spilsbury
Thanks. We should probably have a discussion at some point as to the best guidelines on how to split the code up for unit testing purposes. For now I'll move ahead with getting the vertex clipping code to support N vertices while still passing these tests. I probably won't be able to start that fo

Re: [PATCH 5/6] utils: Ensure wl_list's doxygen formats properly

2013-09-17 Thread Aaron Faanes
On Tue, Sep 17, 2013 at 12:09 AM, Kristian Høgsberg wrote: > On Sun, Sep 15, 2013 at 01:37:10PM -0500, Aaron Faanes wrote: > > This changes the "struct foo" mentions to use , which appears as > > monospaced font. This also wraps code examples with \code tags to > > ensure they're detected as code.

Re: Absolute coordinates using "wl_shell_surface_set_transient"

2013-09-17 Thread Tarnyko
Hi Pekka, I'm taking that as a compliment :-). Thanks ! So we won't rely on that code in the future. If you're curious about why we tried to do that, please look at my answer to Bill and Giulio. Regards, Tarnyko Pekka Paalanen writes: On Mon, 16 Sep 2013 11:41:50 +0200 Tarnyko wrote:

Re: Absolute coordinates using "wl_shell_surface_set_transient"

2013-09-17 Thread Tarnyko
Hi Giulio, Bill, We were originally investigating a problem happening when using X/GTK applications under XWayland ; most of the menus appeared badly positioned when they opened. For example, under Evolution with XWayland, when opening the "File" menu, the menu appears but outside the applic

Re: Problems building Weston/demo applications on the Raspberry Pi

2013-09-17 Thread Silvan Jegen
> thanks for the patch! :-) You are very welcome! > One minor correction: it is not exactly the flag, but removing > wayland-egl.pc that makes sure that toytoolkit does not use cairo-egl. > Otherwise looks good, and the patch is an improvement even as is. You see, I TOLD you the text is confusi

Re: [PATCH v2] Post buffer release events instead of queue when no frame callback

2013-09-17 Thread Pekka Paalanen
On Mon, 16 Sep 2013 16:28:31 +0100 Neil Roberts wrote: > Pekka Paalanen wrote: > > > Instead of all this, could you not have made Weston simply use > > wl_resource_post_event() instead of wl_resource_queue_event()? > > Yes, posting the event rather than queuing it when there are no frame > call

Re: Problems building Weston/demo applications on the Raspberry Pi

2013-09-17 Thread Pekka Paalanen
On Mon, 16 Sep 2013 18:17:16 +0200 Silvan Jegen wrote: > > the "When adding" refers to the old version of the guide. This > > is about migrating from a old build where the configure flags > > were different. That's what the "if you installed it before" > > meant. Granted, is not too clearly writ

Re: [PATCH 1/2] utils: Document wl_container_of

2013-09-17 Thread Kristian Høgsberg
On Mon, Sep 16, 2013 at 11:38:28PM -0500, Aaron Faanes wrote: > On Mon, Sep 16, 2013 at 11:12 PM, Kristian Høgsberg wrote: > > > > /** > > > * Retrieves a pointer to the containing struct of a given member item. > > > * > > > * This macro allows conversion from a pointer to a item, in a member

Re: [PATCH] egl: add EGL_WAYLAND_Y_INVERTED_WL attribute

2013-09-17 Thread Kristian Høgsberg
On Mon, Sep 16, 2013 at 01:02:46PM +0400, Stanislav Vorobiov wrote: > This enables querying of wl_buffer's orientation Thanks, committed. I followed up with a commit to also add EGL_TEXTURE_FORMAT to the new table of valid eglQueryWaylandBufferWL attributes. Kristian > --- > docs/specs/WL_bind

Re: [PATCH 6/6] utils: Document wl_list methods

2013-09-17 Thread Kristian Høgsberg
On Sun, Sep 15, 2013 at 01:37:11PM -0500, Aaron Faanes wrote: > --- > > As I understand it, a wl_list can be either content-bearing node or a list > head. > I believe this is correct, but if it isn't (in other words, there is no > distinction > between list heads and content-bearing elements), t

Re: [PATCH 5/6] utils: Ensure wl_list's doxygen formats properly

2013-09-17 Thread Kristian Høgsberg
On Sun, Sep 15, 2013 at 01:37:10PM -0500, Aaron Faanes wrote: > This changes the "struct foo" mentions to use , which appears as > monospaced font. This also wraps code examples with \code tags to > ensure they're detected as code. Is there a doxygen markup we can use instead of ? Most of the us

Re: [PATCH 0/6] More utils/wayland-server documentation

2013-09-17 Thread Kristian Høgsberg
On Sun, Sep 15, 2013 at 01:37:05PM -0500, Aaron Faanes wrote: > Howdy, > > I went ahead and added some more documentation for some utils classes, the > big one being wl_list. Thanks, I appreciate it. > I know I have some patches still outstanding, so I apologize if it's rude > to submit another

Re: [PATCH 2/2] wayland-server: Document wl_listener

2013-09-17 Thread Kristian Høgsberg
On Sun, Sep 15, 2013 at 01:09:18PM -0500, Aaron Faanes wrote: > This patch takes Kristian's comments into account, adding a demonstration and > giving a more thorough idea of how wl_listener is used. This looks fine. I'd rather see /* Direct access */ instead of // Direct acces

Re: [PATCH weston v3] compositor: reset surface's resource field on resource destruction

2013-09-17 Thread Kristian Høgsberg
On Fri, Sep 13, 2013 at 11:54:59AM -0500, Jason Ekstrand wrote: > Perhaps a better long-term solution would be to have the pointer register a > destroy listener on the surface's resource and use that to null out the > focus. Then we wouldn't have to worry about specifically flagging this > strange

Re: [PATCH 4/4] Added tests for the vertex clipping code.

2013-09-17 Thread Kristian Høgsberg
On Fri, Sep 13, 2013 at 10:01:22AM +0800, Sam Spilsbury wrote: > This tests (via the table-driven testing method) that the correct > number of vertices and also the correct vertices themselves > are generated for an clip box and polygon of up to eight vertices. > > Also add a libshared-test.la so

Re: [PATCH 1/2] utils: Document wl_container_of

2013-09-17 Thread Aaron Faanes
On Mon, Sep 16, 2013 at 11:12 PM, Kristian Høgsberg wrote: > > /** > > * Retrieves a pointer to the containing struct of a given member item. > > * > > * This macro allows conversion from a pointer to a item, in a member > called > > * link, to its containing struct. > > I think the 'in a memb

Re: [PATCH 1/2] utils: Document wl_container_of

2013-09-17 Thread Kristian Høgsberg
On Mon, Sep 16, 2013 at 11:46 AM, Aaron Faanes wrote: > On Mon, Sep 16, 2013 at 12:57 PM, Bill Spitzak wrote: >> >> >>> What if the example was expanded slightly, like so: >>> >>> \code >>> struct wl_container { >>> wl_list link; >>> ... >>> }; >>> >>> struct wl_container container; >>> s

Re: [PATCH 1/2] utils: Document wl_container_of

2013-09-17 Thread Aaron Faanes
--- Here's the updated patch. Thanks, Bill and Kristian, for your reviews. Feel free to let me know if anything else needs correcting with this one. src/wayland-util.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/src/wayland-util.h b/src/wayland-util.h index d

Re: Absolute coordinates using "wl_shell_surface_set_transient"

2013-09-17 Thread Bill Spitzak
Giulio Camuffo wrote: No, it's not supposed to work, and if it works it's just by pure chance and/or because of how the shell works internally. There is no way to place a surface to an absolute position from the client side, but there may be ways to solve your problem in a different way. Wha