Re: [PATCH] update protocol specification to match wire protocol

2014-09-05 Thread Pekka Paalanen
On Fri, 5 Sep 2014 19:18:44 -0500 Paul Sbarra wrote: > On Fri, Sep 5, 2014 at 7:51 AM, Pekka Paalanen wrote: > > > > I took a look at both of them, you are making an incompatible change to > > wayland.xml, and breaking the generator. > > > > Essentially you are breaking the unwritten specifica

Re: [PATCH weston 2/2] main: don't leak option strings

2014-09-05 Thread Ryo Munakata
Hi, Bill. Thank you for reviewing. On Fri, 05 Sep 2014 18:08:44 -0700 Bill Spitzak wrote: > I think if the strdup's were removed it would get rid of the memory leak > in a much cleaner way. Do you mean the strdup's in handle_options()? handle_options() copies the content of argv, so if ha

Re: [PATCH weston 2/2] main: don't leak option strings

2014-09-05 Thread Bill Spitzak
I think if the strdup's were removed it would get rid of the memory leak in a much cleaner way. On 09/05/2014 03:32 PM, Ryo Munakata wrote: Signed-off-by: Ryo Munakata --- src/compositor.c | 45 +++-- 1 file changed, 19 insertions(+), 26 deletions(-)

Re: [PATCH v2 weston] xdg-shell: handle clients launched in fullscreen

2014-09-05 Thread Bill Spitzak
I would think the same decision should be made for clients that are not fullscreen. Actually it does look like this is discussed on http://lists.freedesktop.org/archives/wayland-devel/2014-May/014568.html Nobody really has a good idea what the rules should be, but everbody does seem to think

Re: [PATCH V2] fixes to parse_options, help info

2014-09-05 Thread Bill Spitzak
Those look good. Supporting space-separated values would be a nice addition. On 09/05/2014 01:45 AM, Pekka Paalanen wrote: On Tue, 19 Aug 2014 18:13:08 -0700 Bill Spitzak wrote: This replaces the two unpushed patches from my previous set. Includes changes based on Pekka's comments: Removed

Re: [PATCH] update protocol specification to match wire protocol

2014-09-05 Thread Paul Sbarra
On Fri, Sep 5, 2014 at 7:51 AM, Pekka Paalanen wrote: > I took a look at both of them, you are making an incompatible change to > wayland.xml, and breaking the generator. > > Essentially you are breaking the unwritten specification on how the XML > files are processed into wire format and langua

Re: [PATCH weston] compositor.c: do not leak option strings

2014-09-05 Thread Ryo Munakata
On Fri, 5 Sep 2014 13:56:23 +0300 Pekka Paalanen wrote: > > + if (!backend) { > > + if (getenv("WAYLAND_DISPLAY") || > > getenv("WAYLAND_SOCKET")) > > + backend = strdup("wayland-backend.so"); > > + else if (getenv("DISPLAY"

[PATCH weston 2/2] main: don't leak option strings

2014-09-05 Thread Ryo Munakata
Signed-off-by: Ryo Munakata --- src/compositor.c | 45 +++-- 1 file changed, 19 insertions(+), 26 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 0ecae23..de58c59 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4328,15 +4328,13

[PATCH weston 1/2] main: usual patterns can be extracted to functions

2014-09-05 Thread Ryo Munakata
Signed-off-by: Ryo Munakata --- src/compositor.c | 66 +++- 1 file changed, 41 insertions(+), 25 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 20ff6b2..0ecae23 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4279,

[PATCH weston v2] compositor.c: do not leak option strings

2014-09-05 Thread Ryo Munakata
Hi. This patch series is a version 2 of 'compositor.c: do not leak option strings' 1/2 extracts new functions from usual patterns in main. 2/2 fixes leaks of option strings Thanks. -- Ryo Munakata ___ wayland-devel mailing list wayland-devel@lists.

[PATCH weston] compositor: remove unused signal

2014-09-05 Thread Giulio Camuffo
The move_signal in weston_output isn't used, and not even initialized, so anything trying to listen to it will crash on wl_signal_add(). Instead of it, the 'output_moved_signal' in weston_compositor is used, so remove it. --- src/compositor.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/

Re: [PATCH weston] shell: fix various interactions with the minimized state

2014-09-05 Thread Manuel Bachmann
Hi Giulio, Sorry for the late answer, I happen to be very busy lately. > How do you test that? Did you have to craft an ad-hoc client? Yes ; you will find the client I use at this URL : http://www.tarnyko.net/repo/wayland-9b-xdg_shell_150.zip (run "./build.sh" to compile). If you then start the

[PATCH wayland-web] extras: list three Wayland protocol dumping tools

2014-09-05 Thread Pekka Paalanen
From: Pekka Paalanen Cc: tomek.obreb...@gmail.com Cc: Boyan Ding Cc: Ismo Puustinen Signed-off-by: Pekka Paalanen --- Hi guys, could you check if you are happy with the descriptions I wrote and if you want something else mentioned. Thanks, pq extras.html | 19 +++ 1 file

Re: [PATCH] update protocol specification to match wire protocol

2014-09-05 Thread Daniel Stone
Hi, On 5 September 2014 13:51, Pekka Paalanen wrote: > Essentially you are breaking the unwritten specification on how the XML > files are processed into wire format and language bindings. > Wayland-scanner is not the only generator, and wayland.xml is not the > only XML file in existence. > > [

Re: [PATCH] update protocol specification to match wire protocol

2014-09-05 Thread Pekka Paalanen
On Fri, 5 Sep 2014 07:05:55 -0500 Paul Sbarra wrote: > On Thu, Sep 4, 2014 at 10:33 PM, Boyan Ding wrote: > > > Hi, > > > > Actually it is not a hack, it is a very well-defined behavior (though > > not clearly documented at present). We'll update the documentation to > > reflect that. The mecha

Wayland and Weston 1.6 RC1 snapshot (1.5.92)

2014-09-05 Thread Pekka Paalanen
Hi, this is the first release candidate towards Wayland and Weston 1.6. The SHA1s are: 414322c106a8ed6a2f76e97c0af90c389443b8f0 wayland-1.5.92.tar.xz 44bf13ba0f3b881c0c5055a7225591395bc80583 wayland 1.5.92 tag 01c662d5cc676e0e5106c0912dc6d3f0880a8ac7 weston-1.5.92.tar.xz 386754cf79a02

Re: [PATCH] update protocol specification to match wire protocol

2014-09-05 Thread Paul Sbarra
On Thu, Sep 4, 2014 at 10:33 PM, Boyan Ding wrote: > Hi, > > Actually it is not a hack, it is a very well-defined behavior (though > not clearly documented at present). We'll update the documentation to > reflect that. The mechanic of creating objects undergoes some change as > Pekka mentioned [1

Re: [PATCH weston] compositor.c: do not leak option strings

2014-09-05 Thread Pekka Paalanen
On Tue, 2 Sep 2014 00:14:45 +0900 Ryo Munakata wrote: > Also some refactoring to achieve this. > > Signed-off-by: Ryo Munakata > --- > src/compositor.c | 52 +++- > 1 file changed, 27 insertions(+), 25 deletions(-) > > diff --git a/src/composit

Re: [PATCH v2 1/2] shell: update shsurf->output when it might changed

2014-09-05 Thread Pekka Paalanen
On Mon, 1 Sep 2014 17:20:32 +0200 Marek Chalupa wrote: > When we are moving window or its state changed, update the > output, so that configure event and maximizing/fullscreening actions > have up-to-date information. > > Signed-off-by: Marek Chalupa > --- > desktop-shell/shell.c | 39 +++

Re: how to make Xwayland auto start on tizen-ivi-3.0 image

2014-09-05 Thread Dominig ar Foll (Intel OTC)
Le 05/09/2014 09:09, Pekka Paalanen a écrit : On Fri, 5 Sep 2014 10:38:10 +0800 "Steve (YiLiang) Zhou" wrote: Well, that’s a history problem. What’s the shortage of running things as root? You might want to read this paper  

Re: [PATCH v2 weston] xdg-shell: handle clients launched in fullscreen

2014-09-05 Thread Pekka Paalanen
On Tue, 2 Sep 2014 11:35:12 +0200 Marek Chalupa wrote: > When client is lauched in fullscreen, it is placed on the > first output, because it is not mapped and > shell_surface_set_output() therefore sets default output. > > Since we have no better way how to position newly created windows, > (h

Re: [PATCH] doc: Quell warnings about missing man3 directory before its been built

2014-09-05 Thread Pekka Paalanen
On Mon, 4 Aug 2014 11:26:28 +1000 Peter Hutterer wrote: > sorry about the delay, was on holidays. > > On Fri, Jul 25, 2014 at 04:30:41PM +0300, Pekka Paalanen wrote: > > On Mon, 21 Jul 2014 19:23:49 + > > "Bryce W. Harrington" wrote: > > > > > The shell command for dist_man3_MANS gets invo

Re: [PATCH V2] fixes to parse_options, help info

2014-09-05 Thread Pekka Paalanen
On Tue, 19 Aug 2014 18:13:08 -0700 Bill Spitzak wrote: > This replaces the two unpushed patches from my previous set. > Includes changes based on Pekka's comments: > > Removed merging of 1-letter boolean switches > > Fixed the error message for image files less than 4 bytes long > > Style fixe

Re: [PATCH] matrix-test: fix units in report

2014-09-05 Thread Pekka Paalanen
On Thu, 4 Sep 2014 14:31:30 -0500 Derek Foreman wrote: > The matrix-test speed tests are calculated in ns but some printed the > units as us > --- > tests/matrix-test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/matrix-test.c b/tests/matrix-test.c > inde

Re: [PATCH] touch-input: Don't dereference NULL pointer during full screen fade

2014-09-05 Thread Pekka Paalanen
On Thu, 4 Sep 2014 10:23:05 -0500 Derek Foreman wrote: > If a full screen program is fading out and a touch start happens, it > will result in a NULL pointer dereference when weston_touch_set_focus > tries to derefernce view->surface->resource. > > Instead, this patch sets the focus to NULL, wh

RE: how to make Xwayland auto start on tizen-ivi-3.0 image

2014-09-05 Thread Steve (YiLiang) Zhou
Thanks Pekka, I see, I'll try to make the app access /home rather than /usr directory. Thanks again for your passional reply. Thanks and Best Regards Steve Zhou -Original Message- From: Pekka Paalanen [mailto:ppaala...@gmail.com] Sent: Friday, September 05, 2014 3:09 PM To: Steve (Yi

Re: [PATCH] update protocol specification to match wire protocol

2014-09-05 Thread Pekka Paalanen
On Thu, 4 Sep 2014 22:05:00 -0500 Paul Sbarra wrote: > I agree it's a hack, but it's also one that invalidates the protocol > specification. If the wire protocol requires four arguments then the > specification needs to reflect that. Currently if another tool or protocol > implementation (like

Re: how to make Xwayland auto start on tizen-ivi-3.0 image

2014-09-05 Thread Pekka Paalanen
On Fri, 5 Sep 2014 10:38:10 +0800 "Steve (YiLiang) Zhou" wrote: > Well, that’s a history problem. What’s the shortage of running things as root? It is pretty much the same thing as why guns tend to have safeties, and are kept in locked cabinets when not actively handled, with keys only with thos