[PATCH 1/2] compositor: Remove extra blank line

Signed-off-by: Chris Michael --- src/compositor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index bbac110..5fa30cb 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -768,7 +768,6 @@

[PATCH 2/2] clients: Adjust grammar of comment for toysurface->prepare function pointer

Signed-off-by: Chris Michael --- clients/window.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/window.c b/clients/window.c index bf3c470..5d69116 100644 --- a/clients/window.c +++ b/clients/window.c @@ -145,7 +145,7 @@ struct window_output {

Re: [PATCH 1/2] compositor: Remove extra blank line

Both look fine to me. Reviewed-by: Derek Foreman On 23/11/15 02:13 PM, Chris Michael wrote: > Signed-off-by: Chris Michael > --- > src/compositor.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/compositor.c b/src/compositor.c >

Re: [PATCH weston v4 02/20] desktop-shell: Track the black surface by its view

On 17/11/15 04:10 AM, Jonas Ådahl wrote: > In preparation for further refactoring. > > Signed-off-by: Jonas Ådahl > Signed-off-by: Arnaud Vrac Looks fine to me. Reviewed-by: Derek Foreman > --- > desktop-shell/shell.c | 34

Re: [PATCH 3/5] socket-test: Fix indentation to follow project code style policy

Hi On 11/19/2015 08:23 PM, Bill Spitzak wrote: On Thu, Nov 19, 2015 at 1:36 AM, Bryce Harrington > wrote: From: Bryce Harrington > Signed-off-by: Bryce Harrington

Re: [PATCH] Refine compositor grabs behavior

On Mon, Nov 23, 2015 at 10:57:01AM -0800, Bill Spitzak wrote: > On Sun, Nov 22, 2015 at 4:19 PM, Peter Hutterer > wrote: > > > > > p1.leave, p2.leave, \ > > p1.enter, p2.enter,\ > > p1.frame *FOCUS TRANSITIONED*, p2.frame *FOCUS TRANSITIONED* > > > > we have the

[PATCH weston] compositor-drm: Use view transform in cursor plane setup

Make sure a view's transform is viable for a drm plane and then actually apply it before setting the cursor plane location. Now if a subsurface ends up in the cursor plane, the plane will be properly positioned. Signed-off-by: Derek Foreman --- src/compositor-drm.c | 7

Re: [PATCH wayland-protocols 1/2] Introduce wp_relative_pointer interface

Hi, On 17 November 2015 at 11:09, Jonas Ådahl wrote: > The wp_relative_pointer interface is an extension to the wl_pointer > interface created from wl_seat. It has the same focus, but adds the > functionality of sending relative pointer motions unhindered by > constraints such

Re: [PATCH wayland-protocols 2/2] Introduce pointer locking and confinement protocol

On 18/11/15 06:59 PM, Peter Hutterer wrote: > On Tue, Nov 17, 2015 at 06:09:18PM +0800, Jonas Ådahl wrote: >> This patch introduces a new protocol for locking and confining a >> pointer. It consists of a new global object with two requests; one for >> locking the surface to a position, one for

Re: Lifetime of wl_seat objects (was Re: [PATCH wayland-protocols 1/2] Introduce wp_relative_pointer) interface

On Tue, Nov 24, 2015 at 11:44:54AM +0800, Jonas Ådahl wrote: > On Tue, Nov 24, 2015 at 10:21:45AM +1000, Peter Hutterer wrote: > > On Mon, Nov 23, 2015 at 12:01:01PM -0600, Derek Foreman wrote: > > > On 23/11/15 12:32 AM, Jonas Ådahl wrote: > > > > On Mon, Nov 23, 2015 at 02:42:09PM +1000, Peter

Re: Lifetime of wl_seat objects (was Re: [PATCH wayland-protocols 1/2] Introduce wp_relative_pointer) interface

On Tue, Nov 24, 2015 at 03:11:26PM +1000, Peter Hutterer wrote: > On Tue, Nov 24, 2015 at 11:44:54AM +0800, Jonas Ådahl wrote: > > On Tue, Nov 24, 2015 at 10:21:45AM +1000, Peter Hutterer wrote: > > > On Mon, Nov 23, 2015 at 12:01:01PM -0600, Derek Foreman wrote: > > > > On 23/11/15 12:32 AM,

Re: [PATCH wayland-protocols 1/2] Introduce wp_relative_pointer interface

On Mon, Nov 23, 2015 at 03:24:20PM -0600, Derek Foreman wrote: > On 17/11/15 04:09 AM, Jonas Ådahl wrote: > > The wp_relative_pointer interface is an extension to the wl_pointer > > interface created from wl_seat. It has the same focus, but adds the > > functionality of sending relative pointer

Re: Lifetime of wl_seat objects (was Re: [PATCH wayland-protocols 1/2] Introduce wp_relative_pointer) interface

On Mon, Nov 23, 2015 at 12:01:01PM -0600, Derek Foreman wrote: > On 23/11/15 12:32 AM, Jonas Ådahl wrote: > > On Mon, Nov 23, 2015 at 02:42:09PM +1000, Peter Hutterer wrote: > >> On Fri, Nov 20, 2015 at 02:59:50PM +0800, Jonas Ådahl wrote: > >> [...] > > + > > + > > + >

Re: [PATCH libinput v9 0/2] add orientation, size and pressure of touch

On Mon, Nov 23, 2015 at 07:58:28PM +0100, Andreas Pokorny wrote: > Hi, > The scale of major minor is still an open problem. As you know none of the > reported absinfos contains resolution information. The reported size range > is somewhat similar acress various devices, but needs different scaling

Re: Lifetime of wl_seat objects (was Re: [PATCH wayland-protocols 1/2] Introduce wp_relative_pointer) interface

On Tue, Nov 24, 2015 at 10:21:45AM +1000, Peter Hutterer wrote: > On Mon, Nov 23, 2015 at 12:01:01PM -0600, Derek Foreman wrote: > > On 23/11/15 12:32 AM, Jonas Ådahl wrote: > > > On Mon, Nov 23, 2015 at 02:42:09PM +1000, Peter Hutterer wrote: > > >> On Fri, Nov 20, 2015 at 02:59:50PM +0800, Jonas

Re: [PATCH 3/5] socket-test: Fix indentation to follow project code style policy

On Thu, Nov 19, 2015 at 11:23:42AM -0800, Bill Spitzak wrote: > On Thu, Nov 19, 2015 at 1:36 AM, Bryce Harrington > wrote: > > > From: Bryce Harrington > > > > Signed-off-by: Bryce Harrington > > --- > >

Re: Re: [PATCH 2/5] wayland-server: Add code docs for new display socket API's

Title: Samsung Enterprise Portal mySingle >> Also (on the patch) it looks like if there is an error it destroys the>> wl_socket object, could this do the wrong thing if the fd was supplied from>> outside?> So like if the socket object couldn't be initted or added to the display> for some

[PATCH wayland v2 0/5] Allow passing fd when adding socket for display

This patchset adds functionality to allow system-level control over handing out file descriptors for sockets, to allow tighter security when running a Wayland compositor under a Wayland session server. A Wayland session service is run with system daemon permission levels, and individual Wayland

[PATCH wayland v2 4/5] socket-test: Refactor if check into the assert

Signed-off-by: Bryce Harrington --- tests/socket-test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/socket-test.c b/tests/socket-test.c index 2e336fd..bb034f4 100644 --- a/tests/socket-test.c +++ b/tests/socket-test.c @@ -47,8 +47,7 @@

[PATCH wayland v2 1/5] server: Add new api for add socket for fd

From: Sangjin Lee Currently the server can add a socket by name. To support an embedded compositor in a Simplified Mandatory Access Control Kernel (Smack) enabled environment, the embedded compositor should use the socket that it gets from the system or session compositor.

[PATCH wayland v2 2/5] wayland-server: Add code docs for new display socket API's

Signed-off-by: Bryce Harrington --- src/wayland-server.c | 67 +--- 1 file changed, 53 insertions(+), 14 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index bac98bf..e84858d 100644 ---

[PATCH wayland v2 3/5] socket-test: Fix some comment typos

Signed-off-by: Bryce Harrington --- tests/socket-test.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/socket-test.c b/tests/socket-test.c index c53f972..2e336fd 100644 --- a/tests/socket-test.c +++ b/tests/socket-test.c @@ -107,11

Re: [PATCH 1/2] compositor: Remove extra blank line

On Mon, Nov 23, 2015 at 02:23:15PM -0600, Derek Foreman wrote: > Both look fine to me. > > Reviewed-by: Derek Foreman LGTM2, pushed: f69bd1a..b50ed17 master -> master > On 23/11/15 02:13 PM, Chris Michael wrote: > > Signed-off-by: Chris Michael

Re: [PATCH 2/5] wayland-server: Add code docs for new display socket API's

On Thu, Nov 19, 2015 at 11:21:04AM -0800, Bill Spitzak wrote: > Also (on the patch) it looks like if there is an error it destroys the > wl_socket object, could this do the wrong thing if the fd was supplied from > outside? So like if the socket object couldn't be initted or added to the display

Re: [PATCH] compositor.h: Remove unused variable from weston_seat structure

On Wed, Nov 18, 2015 at 09:24:31AM -0600, Derek Foreman wrote: > On 18/11/15 09:22 AM, Chris Michael wrote: > > This variable may have been used previously when evdev.c was used > > however that functionality seems to have been consumed by libinput, so > > there is no need for this variable in the

Re: [PATCH wayland] protocol: fix a couple of whitespace issues

On Mon, Nov 23, 2015 at 02:28:28PM +1000, Peter Hutterer wrote: > 8 spaces is one tab > > Signed-off-by: Peter Hutterer Thanks, pushed: a5ef930..d5f22d2 master -> master > --- > protocol/wayland.xml | 22 +++--- > 1 file changed, 11

Re: [PATCH libinput v9 0/2] add orientation, size and pressure of touch

Hi, The scale of major minor is still an open problem. As you know none of the reported absinfos contains resolution information. The reported size range is somewhat similar acress various devices, but needs different scaling factors. I have tested the patch with meizu mx4, nexus4, aquaris e4.5,

Re: [PATCH libinput v9 0/2] add orientation, size and pressure of touch

Hi, one more thing.. On Mon, Nov 23, 2015 at 7:58 PM, Andreas Pokorny < andreas.poko...@canonical.com> wrote: > [...] > > On Mon, Nov 23, 2015 at 5:19 AM, Peter Hutterer > wrote: > >> On Fri, Nov 13, 2015 at 08:46:42AM +0100, Andreas Pokorny wrote: >> > Hi, >> > This

Re: Lifetime of wl_seat objects (was Re: [PATCH wayland-protocols 1/2] Introduce wp_relative_pointer) interface

On 23/11/15 12:32 AM, Jonas Ådahl wrote: > On Mon, Nov 23, 2015 at 02:42:09PM +1000, Peter Hutterer wrote: >> On Fri, Nov 20, 2015 at 02:59:50PM +0800, Jonas Ådahl wrote: >> [...] > + > + > + > + Should we add something about pairing this with wl_seat

Re: [PATCH wayland-protocols 1/2] Introduce wp_relative_pointer interface

On 17/11/15 04:09 AM, Jonas Ådahl wrote: > The wp_relative_pointer interface is an extension to the wl_pointer > interface created from wl_seat. It has the same focus, but adds the > functionality of sending relative pointer motions unhindered by > constraints such as monitor edges or other

Re: [PATCH wayland-protocols 1/2] Introduce wp_relative_pointer interface

On 23/11/15 03:24 PM, Derek Foreman wrote: > On 17/11/15 04:09 AM, Jonas Ådahl wrote: >> The wp_relative_pointer interface is an extension to the wl_pointer >> interface created from wl_seat. It has the same focus, but adds the >> functionality of sending relative pointer motions unhindered by >>