On Thu, Apr 28, 2016 at 02:28:21PM +0300, Pekka Paalanen wrote:
> On Thu, 28 Apr 2016 15:31:31 +0800
> Jonas Ådahl wrote:
>
> > Using the libwayland-client client API with multiple threads with
> > thread local queues are prone to race conditions.
> >
> > The problem is that one thread can read
On Thu, Apr 28, 2016 at 08:44:54PM -0500, Yong Bakos wrote:
> On Apr 28, 2016, at 1:57 PM, Benoit Gschwind wrote:
> >
> > Signed-off-by: Benoit Gschwind
> > ---
> > src/main.c | 10 +++---
> > 1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/src/main.c b/src/main.c
> > in
On Apr 28, 2016, at 1:57 PM, Benoit Gschwind wrote:
>
> Signed-off-by: Benoit Gschwind
> ---
> src/main.c | 10 +++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/src/main.c b/src/main.c
> index f034dda..9c15b71 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -692,7
On Apr 28, 2016, at 1:33 PM, Benoit Gschwind wrote:
>
> Extract configuration parsing from init_backend function. The new
> init_backend start by generating the configuration structure from
> configuration file with separated function and then use this structure
> to load the backend.
>
> Signed
On Thu, Apr 28, 2016 at 11:57:51AM -0500, Yong Bakos wrote:
> From: Yong Bakos
>
> The following ten patches:
>
> 1) hyphenate all occurrences of surface local and window local
> 2) remove 'local' from one occurrence of 'buffer local' where the use of
>'local' is superfluous.
> 3) correct mi
Signed-off-by: Benoit Gschwind
---
src/main.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/main.c b/src/main.c
index f034dda..9c15b71 100644
--- a/src/main.c
+++ b/src/main.c
@@ -692,7 +692,7 @@ load_headless_backend(struct weston_compositor *c, char
const *
On 26/04/16 07:50 AM, Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> Rather than silenty doing things, make them explicit and error if
> anything is not quite right. Suggested by Daniel Stone.
>
> Signed-off-by: Pekka Paalanen
> Reviewed-by: Daniel Stone
> [Pekka: updated copyright years]
>
Move all parsing functions from the wayland backend and put
them into the weston code and add versionning to configuration
structure.
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 232 ---
src/compositor-wayland.h | 5 +
src/main.c
Signed-off-by: Benoit Gschwind
---
Makefile.am | 3 +++
src/compositor-wayland.c | 20 +
src/compositor-wayland.h | 58
3 files changed, 62 insertions(+), 19 deletions(-)
create mode 100644 src/compositor-wayland.h
d
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
index 0bfd3ad..0440057 100644
--- a/src/compositor-wayland.c
+++ b/src/compositor-wayland.c
@@ -2226,9
The splitting intend to separate configuration parsing from output
setup.
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 96 ++--
1 file changed, 60 insertions(+), 36 deletions(-)
diff --git a/src/compositor-wayland.c b/src/compositor-w
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
index 8577a74..0bfd3ad 100644
--- a/src/compositor-wayland.c
+++ b/src/compositor-wayland.c
@@ -2440,9 +2440,11 @@ backend_init(str
Extract configuration parsing from init_backend function. The new
init_backend start by generating the configuration structure from
configuration file with separated function and then use this structure
to load the backend.
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 179 ++
Move configuration parsing from create_cursor to backend_init. Use newer
configuration structure to initialize the cursor in create_cursor.
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 32 +++-
1 file changed, 19 insertions(+), 13 deletions(-)
diff -
I did a patches set that split the previous patch in severals steps. The step
intend to help the review, and may not be logical. The patch is focuced on
keeping the legacy configuration behaviours.
Benoit Gschwind (9):
wayland-backend: Create a basic config structure to use in new init
API
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 37 +++--
1 file changed, 23 insertions(+), 14 deletions(-)
diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
index 9d1a251..8577a74 100644
--- a/src/compositor-wayland.c
+++ b/src/compos
The structure is not used currently, just the definition to be used.
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
index 175bd68..f218c9e 100644
--- a/src/compositor-wayl
On 26/04/16 07:50 AM, Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> Remove the old, redundant request. The new way is to call both
> wp_viewport.set_source and wp_viewport.set_destination when you want to
> set everything.
Makes sense. It's all made atomic by the surface commit anyway...
>
On 26/04/16 07:50 AM, Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> This XML file has been copied verbatim from Weston 1.10.0 release,
> protocol/scaler.xml.
>
> The interfaces still need renaming according to wayland-protocols
> policy. Also a redundant request needs to be removed. These wil
Hello Pekka,
The patch look good, but leave a leak in backend_init: the param.device
is never freed.
This fixed you get my Reviewed-by ;)
Best regards
Le 28/04/2016 16:08, Pekka Paalanen a écrit :
> From: Pekka Paalanen
>
> Ensuring that the pointer to the device path stays valid gets harder
On 28/04/16 02:31 AM, Jonas Ådahl wrote:
> Using the libwayland-client client API with multiple threads with
> thread local queues are prone to race conditions.
>
> The problem is that one thread can read and queue events after another
> thread creates a proxy but before it sets the queue.
>
> Th
From: Yong Bakos
See https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html.
Signed-off-by: Yong Bakos
---
unstable/pointer-constraints/pointer-constraints-unstable-v1.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/unstable/pointer-constraints/
From: Yong Bakos
Hyphenate 'multi screen' coordinates, and correct misspellings and
grammar within changed lines.
See https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html.
Signed-off-by: Yong Bakos
---
ivi-shell/ivi-layout.c | 16
1 file changed, 8 inse
From: Yong Bakos
Remove superfluous 'local' from 'buffer local'.
In addition, simplify the phrasing of local x/y coordinates in parameter
summaries.
See https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html.
Signed-off-by: Yong Bakos
---
protocol/wayland.xml | 50 +++
From: Yong Bakos
See https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html.
Signed-off-by: Yong Bakos
---
doc/publican/sources/Architecture.xml | 4 ++--
doc/publican/sources/Protocol.xml | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/publi
From: Yong Bakos
In addition, simplify relevant x/y coordinate parameter summaries.
See https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html.
Signed-off-by: Yong Bakos
---
unstable/tablet/tablet-unstable-v1.xml | 10 +-
1 file changed, 5 insertions(+), 5 deletio
From: Yong Bakos
See https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html.
Signed-off-by: Yong Bakos
---
src/compositor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compositor.c b/src/compositor.c
index 5500197..94e1b9f 100644
--- a/src/compo
From: Yong Bakos
See https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html.
Signed-off-by: Yong Bakos
---
protocol/ivi-application.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/protocol/ivi-application.xml b/protocol/ivi-application.xml
index 8f2
From: Yong Bakos
Correct the pluralization by simplifying with 'surface-local'.
See https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html.
Signed-off-by: Yong Bakos
---
fullscreen-shell/fullscreen-shell.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Yong Bakos
Correct the pluralization by simplifying with 'surface-local'.
See https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html.
Signed-off-by: Yong Bakos
---
desktop-shell/shell.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/desktop-shel
From: Yong Bakos
See https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html.
Signed-off-by: Yong Bakos
---
architecture.html | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/architecture.html b/architecture.html
index 6f3c554..0552e90 100644
--- a/ar
From: Yong Bakos
The following ten patches:
1) hyphenate all occurrences of surface local and window local
2) remove 'local' from one occurrence of 'buffer local' where the use of
'local' is superfluous.
3) correct minor grammar errors within lines changed by 1 above
The patches affect wayla
On Thu, 28 Apr 2016 16:23:03 +0200
Quentin Glidic wrote:
> On 28/04/2016 16:08, Pekka Paalanen wrote:
> > From: Pekka Paalanen
> >
> > Ensuring that the pointer to the device path stays valid gets harder and
> > harder with migrating to the libweston-style config handling. Therefore,
> > make a
On Wed, 27 Apr 2016 23:56:41 +0200
Benoit Gschwind wrote:
> I hope I covered all remaining issues.
>
> v3:
> - update Makefile.am
> - fix memory corruption/leak of device variable
> - move transform configuration in the weston side
>
> v2:
> - add src/compositor-fbdev.h in the Makefile.am
>
On 28/04/2016 16:08, Pekka Paalanen wrote:
From: Pekka Paalanen
Ensuring that the pointer to the device path stays valid gets harder and
harder with migrating to the libweston-style config handling. Therefore,
make a copy of the string, private to struct fbdev_output.
Now the pointer passed in
From: Pekka Paalanen
Ensuring that the pointer to the device path stays valid gets harder and
harder with migrating to the libweston-style config handling. Therefore,
make a copy of the string, private to struct fbdev_output.
Now the pointer passed in to fbdev_output_create() could be freed righ
On Thu, 28 Apr 2016 15:31:32 +0800
Jonas Ådahl wrote:
> Test that doing wl_display.sync on a wrapped proxy with a special queue
> works as expected.
>
> Test that creating a wrapper on a destroyed but not freed proxy fails.
>
> Signed-off-by: Jonas Ådahl
> ---
>
> Changes since v1:
>
> - Ma
On Thu, 28 Apr 2016 15:31:31 +0800
Jonas Ådahl wrote:
> Using the libwayland-client client API with multiple threads with
> thread local queues are prone to race conditions.
>
> The problem is that one thread can read and queue events after another
> thread creates a proxy but before it sets the
On Wed, 27 Apr 2016 19:23:47 +0530
Vikas Patil wrote:
> Dear All,
>
> I have a requirement to start the weston 1.8.0 with non-root user. I
> tried it starting weston using following commands in systemd unit file
> with "root" user (first to verify if all commands works) .
Ah, so *that* was the
On Thu, 28 Apr 2016 17:36:58 +0800
Jonas Ådahl wrote:
> On Thu, Apr 28, 2016 at 10:36:14AM +0200, Martin Graesslin wrote:
> > Hi Wayland and Plasma,
> >
> > I finished the implementation of xdg-shell in KWayland [1] and KWin [2].
> > Overall it was more straight forward than I would have expect
On Thu, Apr 28, 2016 at 10:36:14AM +0200, Martin Graesslin wrote:
> Hi Wayland and Plasma,
>
> I finished the implementation of xdg-shell in KWayland [1] and KWin [2].
> Overall it was more straight forward than I would have expected. Especially
> the changes to KWin were surprisingly minor (wit
Hi Wayland and Plasma,
I finished the implementation of xdg-shell in KWayland [1] and KWin [2].
Overall it was more straight forward than I would have expected. Especially
the changes to KWin were surprisingly minor (with one huge exception).
Now some questions/remarks:
* What's a server suppos
The 2016 Election is now over and the results are in. Two questions were up
for voting, 4 seats on the Board of Directors and approval of the amended
By-Laws to join SPI.
The Results of the Board of Director elections:
Candidates and their respective points:
Egbert Eich 205
Test that doing wl_display.sync on a wrapped proxy with a special queue
works as expected.
Test that creating a wrapper on a destroyed but not freed proxy fails.
Signed-off-by: Jonas Ådahl
---
Changes since v1:
- Made the test single threaded, instead pretending to be multi threaded.
- Added
Using the libwayland-client client API with multiple threads with
thread local queues are prone to race conditions.
The problem is that one thread can read and queue events after another
thread creates a proxy but before it sets the queue.
This may result in the event to the proxy being silently
45 matches
Mail list logo
