Re: [PATCH weston 1/2] weston: remove SEGV and ABRT handlers

2018-02-07 Thread Peter Hutterer
On Wed, Feb 07, 2018 at 12:03:56PM +, Simon McVittie wrote: > On Wed, 07 Feb 2018 at 12:51:14 +0200, Pekka Paalanen wrote: > > Catching an ABRT is kind of ok, catching a SEGV is russian roulette. We > > have been quite lucky with it, but I've started hitting crashes inside > > malloc() which ca

Re: [PATCH weston] xwayland: Fix crash on weston shutdown

2018-02-07 Thread Derek Foreman
On 2018-02-05 04:35 PM, Daniel Stone wrote: Hi, On 5 February 2018 at 22:02, Derek Foreman wrote: commit e7fff215ada3fd3d1b2af664888f960c082f9065 made initializing the selection_listener conditional, but didn't make its clean-up conditional at shutdown. To see this, run weston -Bheadless-back

Re: [PATCH weston 1/2] weston: remove SEGV and ABRT handlers

2018-02-07 Thread Simon McVittie
On Wed, 07 Feb 2018 at 15:12:48 +0200, Pekka Paalanen wrote: > Weston handles all other signals via signalfd(), these were the only ones > that used the signal()/sigaction() kind of API. That's good. The traditional pipe-to-self is basically an implementation of signalfd() for kernels that don't n

Re: [PATCH v14 21/41] [XXX] compositor-drm: Only disallow scaling for overlay planes

2018-02-07 Thread Daniel Stone
Hi Pekka, On 24 January 2018 at 10:28, Pekka Paalanen wrote: > On Wed, 20 Dec 2017 12:26:38 + > Daniel Stone wrote: >> Now we have a more comprehensive overview of the transform we're going >> to apply, use this to explicitly disallow scaling and rotation. >> >> XXX: This does not actually d

Re: [PATCH v14 22/41] compositor-drm: Use plane_state_coords_for_view for scanout

2018-02-07 Thread Daniel Stone
Hi Pekka, On 24 January 2018 at 11:30, Pekka Paalanen wrote: > On Wed, 20 Dec 2017 12:26:39 + > Daniel Stone wrote: >> @@ -1660,44 +1630,50 @@ drm_output_prepare_scanout_view(struct >> drm_output_state *output_state, >> return NULL; >> } >> >> + state->output = outpu

[PATCH weston v2 3/4] ivi-shell: don't expilicitly assign outputs to views

2018-02-07 Thread Emre Ucan
it is assigned in weston_view_assign_outputs Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c index 3c52ce1..ea31dea 100644 --- a/ivi-shell/ivi-layout.c +++ b/ivi-shell/ivi-layout.c @@ -822,7 +8

Re: [PATCH weston 3/4] ivi-shell: don't expilicitly assign outputs to views

2018-02-07 Thread Pekka Paalanen
On Wed, 7 Feb 2018 11:54:16 + "Ucan, Emre (ADITG/ESB)" wrote: > Hi, > > > -Original Message- > > From: Pekka Paalanen [mailto:ppaala...@gmail.com] > > Sent: Mittwoch, 7. Februar 2018 11:22 > > To: Ucan, Emre (ADITG/ESB) > > Cc: wayland-devel@lists.freedesktop.org > > Subject: Re: [PA

Re: [PATCH weston 1/2] weston: remove SEGV and ABRT handlers

2018-02-07 Thread Pekka Paalanen
On Wed, 7 Feb 2018 12:03:56 + Simon McVittie wrote: > On Wed, 07 Feb 2018 at 12:51:14 +0200, Pekka Paalanen wrote: > > Catching an ABRT is kind of ok, catching a SEGV is russian roulette. We > > have been quite lucky with it, but I've started hitting crashes inside > > malloc() which causes a

Re: [PATCH weston 1/2] weston: remove SEGV and ABRT handlers

2018-02-07 Thread Simon McVittie
On Wed, 07 Feb 2018 at 12:51:14 +0200, Pekka Paalanen wrote: > Catching an ABRT is kind of ok, catching a SEGV is russian roulette. We > have been quite lucky with it, but I've started hitting crashes inside > malloc() which causes a deadlock when our SEGV handler needs to malloc() > as well (westo

RE: [PATCH weston 3/4] ivi-shell: don't expilicitly assign outputs to views

2018-02-07 Thread Ucan, Emre (ADITG/ESB)
Hi, > -Original Message- > From: Pekka Paalanen [mailto:ppaala...@gmail.com] > Sent: Mittwoch, 7. Februar 2018 11:22 > To: Ucan, Emre (ADITG/ESB) > Cc: wayland-devel@lists.freedesktop.org > Subject: Re: [PATCH weston 3/4] ivi-shell: don't expilicitly assign outputs to > views > > On Fri,

[PATCH weston 2/2] libweston: remove restore functionality

2018-02-07 Thread Pekka Paalanen
From: Pekka Paalanen This was used from the crash handlers, which do not exist anymore. Nothing calls restore, so delete the dead code. Signed-off-by: Pekka Paalanen --- libweston/compositor-drm.c | 7 --- libweston/compositor-fbdev.c | 7 --- libweston/compositor-headles

[PATCH weston 1/2] weston: remove SEGV and ABRT handlers

2018-02-07 Thread Pekka Paalanen
From: Pekka Paalanen Catching an ABRT is kind of ok, catching a SEGV is russian roulette. We have been quite lucky with it, but I've started hitting crashes inside malloc() which causes a deadlock when our SEGV handler needs to malloc() as well (weston_log_timestamp()). One reason to catch SEGV

Re: [PATCH weston 1/4] ivi-shell: change layer visibility to bool

2018-02-07 Thread Pekka Paalanen
On Wed, 7 Feb 2018 10:19:39 + "Ucan, Emre (ADITG/ESB)" wrote: > Hi Pekka, > > Yes, I know that it is an ABI breakage. But there is already another > ABI breakage in compositor.h: > fbf165f5e89576730eed4a7e3979100311c4f0f8 Users of ivi-shell has to > recompile for weston 4.0 anyway. Ok. To b

Re: [PATCH weston 4/4] ivi-shell: fix the layer assignment change from one screen to another

2018-02-07 Thread Pekka Paalanen
On Fri, 26 Jan 2018 15:04:59 +0100 Emre Ucan wrote: > if the layer is in order of some screen we need to remove it > from there and mark the screen order as dirty so it will be removed > in commit_screen_list call later > layer should only be assigned to one screen at a time > > Signed-off-by: E

Re: [PATCH weston 3/4] ivi-shell: don't expilicitly assign outputs to views

2018-02-07 Thread Pekka Paalanen
On Fri, 26 Jan 2018 15:04:58 +0100 Emre Ucan wrote: > it is assigned in weston_view_assign_outputs > > Signed-off-by: Emre Ucan > --- > ivi-shell/ivi-layout.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c > index 3c52ce1..4799c25 1

Re: [PATCH weston 2/4] ivi-shell: don't schedule compositor repaint

2018-02-07 Thread Pekka Paalanen
On Fri, 26 Jan 2018 15:04:57 +0100 Emre Ucan wrote: > it is not necessary to repaint all outputs after > each commit_changes. Only outputs with modified > views has to be repainted. > > We need to call weston_view_update_transform > for assigning views to outputs first. > Then, We can call westo

RE: [PATCH weston 1/4] ivi-shell: change layer visibility to bool

2018-02-07 Thread Ucan, Emre (ADITG/ESB)
Hi Pekka, Yes, I know that it is an ABI breakage. But there is already another ABI breakage in compositor.h: fbf165f5e89576730eed4a7e3979100311c4f0f8 Users of ivi-shell has to recompile for weston 4.0 anyway. Best regards Emre Ucan Engineering Software Base (ADITG/ESB) Tel. +49 5121 49 6937 >

Re: [PATCH weston 1/4] ivi-shell: change layer visibility to bool

2018-02-07 Thread Pekka Paalanen
On Fri, 26 Jan 2018 15:04:56 +0100 Emre Ucan wrote: > ivi_layout_layer_set_visibility has bool > as argument. > > Signed-off-by: Emre Ucan > --- > ivi-shell/ivi-layout-export.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ivi-shell/ivi-layout-export.h b/ivi-shell/i

RE: [PATCH weston v2 6/6] ivi-shell: remove ivi_shell_setting

2018-02-07 Thread Ucan, Emre (ADITG/ESB)
Hi, I did not delete all block. Because block is reading and setting ivi-module from weston config. HMI-controller supports to be load as weston module in 3th patch. Therefore, ivi-shell would not work if I remove all block in the first patch. I could remove the entire if statement in 3th patch

Re: [PATCH weston v2 6/6] ivi-shell: remove ivi_shell_setting

2018-02-07 Thread Pekka Paalanen
On Thu, 25 Jan 2018 14:37:38 +0100 Emre Ucan wrote: > it has only developermode option parameter. > The parameter is only used in init_ivi_shell. > Therefore, we can basically remove the struct, > and check the option locally in the function. > > Signed-off-by: Emre Ucan > Reviewed-by: Pekka Pa

Re: [PATCH weston 0/4] Fix distcheck by overriding file directories

2018-02-07 Thread Pekka Paalanen
On Tue, 6 Feb 2018 21:24:08 + Daniel Stone wrote: > On 6 February 2018 at 21:18, Derek Foreman wrote: > > So apparently for a Very Long Time make distcheck has passed with > > log errors indicating missing files since many icons have been > > searched for in their system wide install directo

Re: [PATCH weston 1/6] ivi-shell: register ivi_layout_interface

2018-02-07 Thread Pekka Paalanen
On Thu, 25 Jan 2018 12:56:37 + "Ucan, Emre (ADITG/ESB)" wrote: > > -Original Message- > > From: Pekka Paalanen [mailto:ppaala...@gmail.com] > > Sent: Montag, 22. Januar 2018 13:28 > > To: Ucan, Emre (ADITG/ESB) > > Cc: wayland-devel@lists.freedesktop.org > > Subject: Re: [PATCH weston